unofficial mirror of notmuch@notmuchmail.org
 help / color / mirror / code / Atom feed
From: Tomi Ollila <tomi.ollila@iki.fi>
To: notmuch@notmuchmail.org
Cc: tomi.ollila@iki.fi
Subject: [PATCH 1/1] emacs/notmuch-show.el: handle bodypart insert error
Date: Sun, 21 Oct 2012 15:58:56 +0300	[thread overview]
Message-ID: <1350824336-11060-1-git-send-email-tomi.ollila@iki.fi> (raw)

When inserting of email bodypart failes, insert a failure message
to the buffer (and continue) instead of halting the insertion of
the rest of that email thread in question.
---

The failure of inserting bodyparts can be experienced in thread
starting with 

id:"m31ul3qo4w.fsf@quad.robs.office"

the email id:"87d31artti.fsf@inf-8657.int-evry.fr"
makes the halt happen -- when this patch is applied
the message !!! bodypart insertion error !!! appears in the
buffer.

for example the email id:"87mwzgxq5l.fsf@inf-8657.int-evry.fr"

is not shown in that thread until this patch is applied.

Whenever everyone can read these emails we can try to figure
out why id:"1349333712-18347-1-git-send-email-tomi.ollila@iki.fi"
did not fix some calendar bodypart for Olivier.

Tomi

 emacs/notmuch-show.el |    4 +++-
 1 files changed, 3 insertions(+), 1 deletions(-)

diff --git a/emacs/notmuch-show.el b/emacs/notmuch-show.el
index f273eb4..651a5ee 100644
--- a/emacs/notmuch-show.el
+++ b/emacs/notmuch-show.el
@@ -815,7 +815,9 @@ message at DEPTH in the current thread."
     ;; Run the content handlers until one of them returns a non-nil
     ;; value.
     (while (and handlers
-		(not (funcall (car handlers) msg part content-type nth depth declared-type)))
+		(not (condition-case nil
+			 (funcall (car handlers) msg part content-type nth depth declared-type)
+		       (error (progn (insert "!!! bodypart insert error !!!\n") nil)))))
       (setq handlers (cdr handlers))))
   t)
 
-- 
1.7.1

             reply	other threads:[~2012-10-21 12:59 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-10-21 12:58 Tomi Ollila [this message]
  -- strict thread matches above, loose matches on Subject: below --
2012-10-21 13:20 [PATCH 1/1] emacs/notmuch-show.el: handle bodypart insert error Tomi Ollila
2012-10-21 13:26 ` Tomi Ollila
2012-10-21 13:35 Tomi Ollila
2012-10-21 14:10 ` Ethan
2012-10-31 20:35 ` David Bremner
2012-11-07 12:10 ` David Bremner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://notmuchmail.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1350824336-11060-1-git-send-email-tomi.ollila@iki.fi \
    --to=tomi.ollila@iki.fi \
    --cc=notmuch@notmuchmail.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://yhetil.org/notmuch.git/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).