From: Austin Clements <amdragon@MIT.EDU>
To: notmuch@notmuchmail.org
Cc: tomi.ollila@iki.fi
Subject: [PATCH v3 00/13] Convert notmuch show to use structure printers
Date: Thu, 2 Aug 2012 21:14:46 -0400 [thread overview]
Message-ID: <1343956499-14543-1-git-send-email-amdragon@mit.edu> (raw)
Relative to version 2 [0], this version fixes a duplicate typedef of
struct sprinter that was not standards compliant and failed to compile
on older gccs [1] (thanks to Tomi for discovering that and figuring
out what was going on).
The diff relative to version 2 follows.
[0] id:"1343449754-9010-1-git-send-email-amdragon@mit.edu"
[1] http://stackoverflow.com/questions/8594954/repeated-typedefs-invalid-in-c-but-valid-in-c
diff --git a/notmuch-client.h b/notmuch-client.h
index de31aa1..ae9344b 100644
--- a/notmuch-client.h
+++ b/notmuch-client.h
@@ -66,12 +66,12 @@ typedef GMimeCipherContext notmuch_crypto_context_t;
#define STRINGIFY_(s) #s
typedef struct mime_node mime_node_t;
-typedef struct sprinter sprinter_t;
+struct sprinter;
struct notmuch_show_params;
typedef struct notmuch_show_format {
- sprinter_t *(*new_sprinter) (const void *ctx, FILE *stream);
- notmuch_status_t (*part) (const void *ctx, sprinter_t *sprinter,
+ struct sprinter *(*new_sprinter) (const void *ctx, FILE *stream);
+ notmuch_status_t (*part) (const void *ctx, struct sprinter *sprinter,
struct mime_node *node, int indent,
const struct notmuch_show_params *params);
} notmuch_show_format_t;
@@ -175,11 +175,11 @@ notmuch_status_t
show_one_part (const char *filename, int part);
void
-format_part_json (const void *ctx, sprinter_t *sp, mime_node_t *node,
+format_part_json (const void *ctx, struct sprinter *sp, mime_node_t *node,
notmuch_bool_t first, notmuch_bool_t output_body);
void
-format_headers_json (sprinter_t *sp, GMimeMessage *message,
+format_headers_json (struct sprinter *sp, GMimeMessage *message,
notmuch_bool_t reply);
typedef enum {
next reply other threads:[~2012-08-03 1:15 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-03 1:14 Austin Clements [this message]
2012-08-03 1:14 ` [PATCH v3 01/13] test: Uniformly canonicalize actual and expected JSON Austin Clements
2012-08-03 1:14 ` [PATCH v3 02/13] test: Remove unnecessary JSON canonicalization Austin Clements
2012-08-03 1:14 ` [PATCH v3 03/13] sprinter: Add a string_len method Austin Clements
2012-08-03 1:14 ` [PATCH v3 04/13] show: Associate an sprinter with each format Austin Clements
2012-08-03 1:14 ` [PATCH v3 05/13] reply: Create a JSON sprinter Austin Clements
2012-08-03 1:14 ` [PATCH v3 06/13] show: Feed the sprinter down to part formatters Austin Clements
2012-08-03 1:14 ` [PATCH v3 07/13] show: Convert format_headers_json to use sprinter Austin Clements
2012-08-03 1:14 ` [PATCH v3 08/13] show: Convert format_part_sigstatus_json " Austin Clements
2012-08-03 1:14 ` [PATCH v3 09/13] show: Convert non-envelope format_part_json " Austin Clements
2012-08-03 1:14 ` [PATCH v3 10/13] show: Convert envelope " Austin Clements
2012-08-03 1:14 ` [PATCH v3 11/13] show: Convert show_message " Austin Clements
2012-08-03 1:14 ` [PATCH v3 12/13] show: Convert do_show " Austin Clements
2012-08-03 1:14 ` [PATCH v3 13/13] show: Remove now unused fields from notmuch_show_format Austin Clements
2012-08-03 9:35 ` [PATCH v3 00/13] Convert notmuch show to use structure printers Tomi Ollila
2012-08-03 23:48 ` David Bremner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://notmuchmail.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1343956499-14543-1-git-send-email-amdragon@mit.edu \
--to=amdragon@mit.edu \
--cc=notmuch@notmuchmail.org \
--cc=tomi.ollila@iki.fi \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://yhetil.org/notmuch.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).