unofficial mirror of notmuch@notmuchmail.org
 help / color / mirror / code / Atom feed
* [PATCH 0/5] Notmuch Pick (WIP or contrib)
@ 2012-07-24 21:21 Mark Walters
  2012-07-24 21:21 ` [PATCH 1/5] emacs: compile and load notmuch-pick.el if present Mark Walters
                   ` (6 more replies)
  0 siblings, 7 replies; 15+ messages in thread
From: Mark Walters @ 2012-07-24 21:21 UTC (permalink / raw)
  To: notmuch

Hello

Notmuch pick is an emacs view which displays a threaded view of
messages: each message has its own line and the thread structure is
shown with UTF-8 graphics characters (so it looks vaguely similar to
mutt's threaded view): see http://kanelephant.com/screen.png for a screenshot.

Pick was originally written by David Edmondon and posted on irc and I
have been developing it on and off since.  Now that almost all the
backend changes it uses are in I would like to see about getting it
into mainline.

The code is not of the same standard as mainline code: in particular a
lot of the code is written by me and is working but unidiomatic
lisp. It has also not had widespread testing so I would expect it to
have several bugs.

We could try getting it into mainline using the normal review type
approach, but the patch is necessarily large (it implements a new view
similar in size to show or search) with the main pick.el file being
nearly 900 lines.

An alternative approach would be to accept it into contrib and then
reviewers/users could submit fixes for the problems directly.

This patch series implements the latter approach, but I am definitely
happy to try for the former or some other approach.

In its current form the user needs to copy (or link) the
notmuch-pick.el from contrib into the emacs directory and then build
notmuch as usual. There are two very small patches to "mainline" code:
one to compile and load the pick file if present and one small tweak
to notmuch-show.el. Then in contrib/notmuch-pick there are three
files: the notmuch-pick.el file itself, a README describing
documenting install and use, and a TODO which contains the main things
I think need doing (and I will try to update this in light of comments
received).

Any comments on the code or the correct approach, patches etc
gratefully received!

Best wishes

Mark

PS If it is in contrib then I am happy to maintain it (with the aim of
an eventual move to mainline).


Mark Walters (5):
  emacs: compile and load notmuch-pick.el if present.
  emacs: make notmuch-show return its buffer
  contrib: add notmuch-pick.el file itself
  contrib: Added pick README.
  contrib: add pick TODO file

 contrib/notmuch-pick/README          |   36 ++
 contrib/notmuch-pick/TODO            |   25 +
 contrib/notmuch-pick/notmuch-pick.el |  876 ++++++++++++++++++++++++++++++++++
 emacs/Makefile.local                 |    3 +-
 emacs/notmuch-show.el                |    3 +-
 emacs/notmuch.el                     |    5 +
 6 files changed, 946 insertions(+), 2 deletions(-)
 create mode 100644 contrib/notmuch-pick/README
 create mode 100644 contrib/notmuch-pick/TODO
 create mode 100644 contrib/notmuch-pick/notmuch-pick.el

-- 
1.7.9.1

^ permalink raw reply	[flat|nested] 15+ messages in thread

end of thread, other threads:[~2012-09-30 15:13 UTC | newest]

Thread overview: 15+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-07-24 21:21 [PATCH 0/5] Notmuch Pick (WIP or contrib) Mark Walters
2012-07-24 21:21 ` [PATCH 1/5] emacs: compile and load notmuch-pick.el if present Mark Walters
2012-07-25  9:17   ` Tomi Ollila
2012-07-25 21:12     ` Mark Walters
2012-07-26  2:54       ` Tomi Ollila
2012-09-02 13:54     ` David Bremner
2012-07-24 21:21 ` [PATCH 2/5] emacs: make notmuch-show return its buffer Mark Walters
2012-07-28 17:01   ` Mark Walters
2012-09-02  2:33   ` David Bremner
2012-07-24 21:21 ` [PATCH 3/5] contrib: add notmuch-pick.el file itself Mark Walters
2012-07-24 21:21 ` [PATCH 4/5] contrib: Added pick README Mark Walters
2012-07-24 21:21 ` [PATCH 5/5] contrib: add pick TODO file Mark Walters
2012-07-25  3:57 ` [PATCH 0/5] Notmuch Pick (WIP or contrib) Aneesh Kumar K.V
2012-09-24 15:00 ` David Bremner
2012-09-30 15:13   ` Mark Walters

Code repositories for project(s) associated with this public inbox

	https://yhetil.org/notmuch.git/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).