unofficial mirror of notmuch@notmuchmail.org
 help / color / mirror / code / Atom feed
From: Mark Walters <markwalters1009@gmail.com>
To: notmuch@notmuchmail.org
Subject: [PATCH 0/4] Add a --body option to notmuch show
Date: Mon, 23 Jul 2012 17:17:17 +0100	[thread overview]
Message-ID: <1343060241-18283-1-git-send-email-markwalters1009@gmail.com> (raw)

After discussion on irc today here is another version of the omit body
patches.  The conclusion on irc was that the option should just make
the body: field in the JSON output optional. The --body=false option
omits this field. The default remains --body=true including the body:
field in the output.

This version includes tests for the new functionality and updates the
manpage and the schemata.

The motivation for this patch is that some callers do not need the
body and omitting it gives a substantial speed up and substantial
reduction in amount of data output.

Previous related patches are at
id:"1342967879-20453-1-git-send-email-markwalters1009@gmail.com" and
id:"1341041595-5858-1-git-send-email-markwalters1009@gmail.com"

Best wishes

Mark



Mark Walters (4):
  cli: add --body=true|false option to notmuch-show.c
  test: add tests for the new --body=true|false option
  man: update man page for the new --body=true|false option
  schemata: update for --body=true|false option

 devel/schemata          |    2 +-
 man/man1/notmuch-show.1 |   16 ++++++++++++++++
 notmuch-client.h        |    3 ++-
 notmuch-reply.c         |    2 +-
 notmuch-show.c          |   23 +++++++++++++++--------
 test/json               |    9 +++++++++
 6 files changed, 44 insertions(+), 11 deletions(-)

-- 
1.7.9.1

             reply	other threads:[~2012-07-23 16:17 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-07-23 16:17 Mark Walters [this message]
2012-07-23 16:17 ` [PATCH 1/4] cli: add --body=true|false option to notmuch-show.c Mark Walters
2012-07-23 16:43   ` Austin Clements
2012-07-23 16:17 ` [PATCH 2/4] test: add tests for the new --body=true|false option Mark Walters
2012-07-23 16:17 ` [PATCH 3/4] man: update man page " Mark Walters
2012-07-23 16:52   ` Austin Clements
2012-07-23 16:17 ` [PATCH 4/4] schemata: update for " Mark Walters

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://notmuchmail.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1343060241-18283-1-git-send-email-markwalters1009@gmail.com \
    --to=markwalters1009@gmail.com \
    --cc=notmuch@notmuchmail.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://yhetil.org/notmuch.git/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).