unofficial mirror of notmuch@notmuchmail.org
 help / color / mirror / code / Atom feed
From: Mark Walters <markwalters1009@gmail.com>
To: notmuch@notmuchmail.org
Subject: [PATCH 0/3] Notmuch pick: a threaded view 
Date: Wed, 11 Jul 2012 19:57:04 +0100	[thread overview]
Message-ID: <1342033027-30286-1-git-send-email-markwalters1009@gmail.com> (raw)

Hello

Notmuch pick is an emacs view which displays a threaded view of
messages: each message has its own line and the thread structure is
shown with UTF-8 graphics characters (so it looks vaguely similar to
mutt's threaded view)

Pick was originally written by David Edmondon and posted on irc and I
have been developing it on and off since.  Now that almost all the
backend changes it uses are in I would like to see about getting it
into mainline.

However, the code is definitely not of the same standard as the main
notmuch code. One suggestion on irc was that we put it in contrib and
ship a stub notmuch-pick.el file in mainline so all a user would need
to do is replace the stub by the full version and compile.

This patch series implements this approach. I have managed to keep the
impact on the main notmuch code minimal: a stub pick file (which is
almost entirely the copyright boilerplate) and a entry from the main
notmuch.el. The way it works is that notmuch unconditionally calls
notmuch-pick-init when started: in the default case (the stub file)
this does nothing, whereas if the user replaces the stub by the full
file this sets up all the keybinding etc.

I have code for another approach which is only a little bigger: I add
a variable notmuch-pick-wanted and if the user sets this (which could
be by using setq in their .emacs file, or we could add a defcustom
option) which tells the code whether to load the pick functionality or
not.

In all the above cases this should give no change for a user who does
not enable the functionality. In the latter two cases notmuch-pick
would show up during compilation, whereas in the former it should be
completely invisible.

Any comments on the preferred approach?

Finally there have been suggestion that the name notmuch-pick is not
intuitive: are there any suggestions for a better name?

Best wishes

Mark

Mark Walters (3):
  emacs: add a stub notmuch-pick.el file
  emacs: add a stub entry to notmuch-pick in notmuch.el
  emacs: make notmuch-show return its buffer

 emacs/Makefile.local  |    3 ++-
 emacs/notmuch-pick.el |   28 ++++++++++++++++++++++++++++
 emacs/notmuch-show.el |    3 ++-
 emacs/notmuch.el      |    2 ++
 4 files changed, 34 insertions(+), 2 deletions(-)
 create mode 100644 emacs/notmuch-pick.el

-- 
1.7.9.1

             reply	other threads:[~2012-07-11 18:57 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-07-11 18:57 Mark Walters [this message]
2012-07-11 18:57 ` [PATCH 1/3] emacs: add a stub notmuch-pick.el file Mark Walters
2012-07-11 18:57 ` [PATCH 2/3] emacs: add a stub entry to notmuch-pick in notmuch.el Mark Walters
2012-07-11 18:57 ` [PATCH 3/3] emacs: make notmuch-show return its buffer Mark Walters
2012-07-11 19:06 ` [PATCH 0/3] Notmuch pick: a threaded view Mark Walters

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://notmuchmail.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1342033027-30286-1-git-send-email-markwalters1009@gmail.com \
    --to=markwalters1009@gmail.com \
    --cc=notmuch@notmuchmail.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://yhetil.org/notmuch.git/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).