* [PATCH 1/2] test: add Emacs notmuch-hello tests for custom tags and queries section.
@ 2012-05-05 14:39 Dmitry Kurochkin
2012-05-05 14:39 ` [PATCH 2/2] emacs: fix custom queries section customization widget in notmuch-hello Dmitry Kurochkin
2012-05-06 23:56 ` [PATCH 1/2] test: add Emacs notmuch-hello tests for custom tags and queries section David Bremner
0 siblings, 2 replies; 3+ messages in thread
From: Dmitry Kurochkin @ 2012-05-05 14:39 UTC (permalink / raw)
To: notmuch
The tests use default values from customization widgets to make sure
that these customization widgets work (at least on basic level).
The custom queries section test is currently broken.
---
test/emacs-hello | 15 +++++++++++++++
.../notmuch-hello-empty-custom-queries-section | 3 +++
.../notmuch-hello-empty-custom-tags-section | 5 +++++
3 files changed, 23 insertions(+)
create mode 100644 test/emacs.expected-output/notmuch-hello-empty-custom-queries-section
create mode 100644 test/emacs.expected-output/notmuch-hello-empty-custom-tags-section
diff --git a/test/emacs-hello b/test/emacs-hello
index be66ba4..936d00e 100755
--- a/test/emacs-hello
+++ b/test/emacs-hello
@@ -44,6 +44,21 @@ test_emacs "(let ((notmuch-hello-sections
(test-output))"
test_expect_equal_file OUTPUT $EXPECTED/notmuch-hello-section-counts
+test_begin_subtest "Empty custom tags section"
+test_emacs "(let* ((widget (widget-create 'notmuch-hello-tags-section))
+ (notmuch-hello-sections (list (widget-value widget))))
+ (notmuch-hello)
+ (test-output))"
+test_expect_equal_file OUTPUT $EXPECTED/notmuch-hello-empty-custom-tags-section
+
+test_begin_subtest "Empty custom queries section"
+test_subtest_known_broken
+test_emacs "(let* ((widget (widget-create 'notmuch-hello-query-section))
+ (notmuch-hello-sections (list (widget-value widget))))
+ (notmuch-hello)
+ (test-output))"
+test_expect_equal_file OUTPUT $EXPECTED/notmuch-hello-empty-custom-queries-section
+
test_begin_subtest "Column alignment for tag/queries with long names"
tag=a-very-long-tag # length carefully calculated for 80 characters window width
notmuch tag +$tag '*'
diff --git a/test/emacs.expected-output/notmuch-hello-empty-custom-queries-section b/test/emacs.expected-output/notmuch-hello-empty-custom-queries-section
new file mode 100644
index 0000000..cd0fdf0
--- /dev/null
+++ b/test/emacs.expected-output/notmuch-hello-empty-custom-queries-section
@@ -0,0 +1,3 @@
+: [hide]
+
+
diff --git a/test/emacs.expected-output/notmuch-hello-empty-custom-tags-section b/test/emacs.expected-output/notmuch-hello-empty-custom-tags-section
new file mode 100644
index 0000000..b56fd67
--- /dev/null
+++ b/test/emacs.expected-output/notmuch-hello-empty-custom-tags-section
@@ -0,0 +1,5 @@
+: [hide]
+
+ 4 attachment 7 signed
+ 52 inbox 52 unread
+
--
1.7.10
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [PATCH 2/2] emacs: fix custom queries section customization widget in notmuch-hello
2012-05-05 14:39 [PATCH 1/2] test: add Emacs notmuch-hello tests for custom tags and queries section Dmitry Kurochkin
@ 2012-05-05 14:39 ` Dmitry Kurochkin
2012-05-06 23:56 ` [PATCH 1/2] test: add Emacs notmuch-hello tests for custom tags and queries section David Bremner
1 sibling, 0 replies; 3+ messages in thread
From: Dmitry Kurochkin @ 2012-05-05 14:39 UTC (permalink / raw)
To: notmuch
The customization widget referred to a non-existing function
`notmuch-hello-insert-query-list'. The patch changes it to the
correct one - `notmuch-hello-insert-searches'. The relevant test is
fixed now.
---
emacs/notmuch-hello.el | 2 +-
test/emacs-hello | 1 -
2 files changed, 1 insertion(+), 2 deletions(-)
diff --git a/emacs/notmuch-hello.el b/emacs/notmuch-hello.el
index f10d98d..684bedc 100644
--- a/emacs/notmuch-hello.el
+++ b/emacs/notmuch-hello.el
@@ -187,7 +187,7 @@ This should only be set by `notmuch-hello-insert-search'.")
:tag "Customized queries section (see docstring for details)"
:type
`(list :tag ""
- (const :tag "" notmuch-hello-insert-query-list)
+ (const :tag "" notmuch-hello-insert-searches)
(string :tag "Title for this section")
(repeat :tag "Queries"
(cons (string :tag "Name") (string :tag "Query")))
diff --git a/test/emacs-hello b/test/emacs-hello
index 936d00e..a998dc4 100755
--- a/test/emacs-hello
+++ b/test/emacs-hello
@@ -52,7 +52,6 @@ test_emacs "(let* ((widget (widget-create 'notmuch-hello-tags-section))
test_expect_equal_file OUTPUT $EXPECTED/notmuch-hello-empty-custom-tags-section
test_begin_subtest "Empty custom queries section"
-test_subtest_known_broken
test_emacs "(let* ((widget (widget-create 'notmuch-hello-query-section))
(notmuch-hello-sections (list (widget-value widget))))
(notmuch-hello)
--
1.7.10
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH 1/2] test: add Emacs notmuch-hello tests for custom tags and queries section.
2012-05-05 14:39 [PATCH 1/2] test: add Emacs notmuch-hello tests for custom tags and queries section Dmitry Kurochkin
2012-05-05 14:39 ` [PATCH 2/2] emacs: fix custom queries section customization widget in notmuch-hello Dmitry Kurochkin
@ 2012-05-06 23:56 ` David Bremner
1 sibling, 0 replies; 3+ messages in thread
From: David Bremner @ 2012-05-06 23:56 UTC (permalink / raw)
To: Dmitry Kurochkin, notmuch
Dmitry Kurochkin <dmitry.kurochkin@gmail.com> writes:
> The tests use default values from customization widgets to make sure
> that these customization widgets work (at least on basic level).
pushed both.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2012-05-06 23:56 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-05-05 14:39 [PATCH 1/2] test: add Emacs notmuch-hello tests for custom tags and queries section Dmitry Kurochkin
2012-05-05 14:39 ` [PATCH 2/2] emacs: fix custom queries section customization widget in notmuch-hello Dmitry Kurochkin
2012-05-06 23:56 ` [PATCH 1/2] test: add Emacs notmuch-hello tests for custom tags and queries section David Bremner
Code repositories for project(s) associated with this public inbox
https://yhetil.org/notmuch.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).