From: Jameson Graef Rollins <jrollins@finestructure.net>
To: Notmuch Mail <notmuch@notmuchmail.org>
Subject: [PATCH 8/8] emacs: eliminate show-tag-message in favor of just show-tag
Date: Sat, 7 Apr 2012 17:35:38 -0700 [thread overview]
Message-ID: <1333845338-22960-9-git-send-email-jrollins@finestructure.net> (raw)
In-Reply-To: <1333845338-22960-8-git-send-email-jrollins@finestructure.net>
notmuch-show-tag-message is now completely redundant with
notmuch-show-tag so we eliminate it to simplify the interface.
---
emacs/notmuch-show.el | 14 ++------------
1 files changed, 2 insertions(+), 12 deletions(-)
diff --git a/emacs/notmuch-show.el b/emacs/notmuch-show.el
index 69bca02..f174910 100644
--- a/emacs/notmuch-show.el
+++ b/emacs/notmuch-show.el
@@ -1396,7 +1396,7 @@ current thread."
(defun notmuch-show-mark-read ()
"Mark the current message as read."
- (notmuch-show-tag-message "-unread"))
+ (notmuch-show-tag "-unread"))
;; Functions for getting attributes of several messages in the current
;; thread.
@@ -1634,16 +1634,6 @@ than only the current message."
(message (format "Command '%s' exited abnormally with code %d"
shell-command exit-code))))))))
-(defun notmuch-show-tag-message (&rest tag-changes)
- "Change tags for the current message.
-
-TAG-CHANGES is a list of tag operations for `notmuch-tag'."
- (let* ((current-tags (notmuch-show-get-tags))
- (new-tags (notmuch-update-tags current-tags tag-changes)))
- (unless (equal current-tags new-tags)
- (funcall 'notmuch-tag (notmuch-show-get-message-id) tag-changes)
- (notmuch-show-set-tags new-tags))))
-
(defun notmuch-show-tag (&optional tag-changes)
"Change tags for the current message.
@@ -1768,7 +1758,7 @@ If a prefix argument is given, the message will be
removed)."
(interactive "P")
(let ((op (if unarchive "+" "-")))
- (notmuch-show-tag-message (concat op "inbox"))))
+ (notmuch-show-tag (concat op "inbox"))))
(defun notmuch-show-archive-message-then-next-or-exit ()
"Archive the current message, then show the next open message in the current thread.
--
1.7.9.1
next prev parent reply other threads:[~2012-04-08 0:35 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-02 8:20 improvements to some emacs search tagging functions Jameson Graef Rollins
2012-04-02 8:20 ` [PATCH 1/6] emacs: update tag-completion function Jameson Graef Rollins
2012-04-02 8:20 ` [PATCH 2/6] emacs: have tag-completion return all tags for nil input Jameson Graef Rollins
2012-04-02 8:20 ` [PATCH 3/6] emacs: modify notmuch-search-tag to not prompt if tags provided as argument Jameson Graef Rollins
2012-04-02 8:20 ` [PATCH 4/6] emacs: remove redundant notmuch-search-tag-thread function Jameson Graef Rollins
2012-04-02 8:20 ` [PATCH 5/6] emacs: change name of search-archive-thread function to just search-archive Jameson Graef Rollins
2012-04-02 8:20 ` [PATCH 6/6] emacs: include tags from excluded messages in tag tab completion Jameson Graef Rollins
2012-04-02 8:44 ` [PATCH 3/6] emacs: modify notmuch-search-tag to not prompt if tags provided as argument Dmitry Kurochkin
2012-04-02 8:35 ` [PATCH 2/6] emacs: have tag-completion return all tags for nil input Dmitry Kurochkin
2012-04-02 8:39 ` improvements to some emacs search tagging functions Jameson Graef Rollins
2012-04-08 0:35 ` emacs tagging cleanup Jameson Graef Rollins
2012-04-08 0:35 ` [PATCH 1/8] emacs: create notmuch-tag.el, and move appropriate functions from notmuch.el Jameson Graef Rollins
2012-04-08 0:35 ` [PATCH 2/8] emacs: update tag-completion function Jameson Graef Rollins
2012-04-08 0:35 ` [PATCH 3/8] emacs: have tag-completion return all tags for nil input Jameson Graef Rollins
2012-04-08 0:35 ` [PATCH 4/8] emacs: allow notmuch-tag to accept string inputs and prompt for tags Jameson Graef Rollins
2012-04-08 0:35 ` [PATCH 5/8] emacs: modify search tag functions to use new notmuch-tag interface Jameson Graef Rollins
2012-04-08 0:35 ` [PATCH 6/8] emacs: eliminate search-tag-thread in favor of just search-tag Jameson Graef Rollins
2012-04-08 0:35 ` [PATCH 7/8] emacs: modify show tag functions to use new notmuch-tag interface Jameson Graef Rollins
2012-04-08 0:35 ` Jameson Graef Rollins [this message]
2012-04-08 3:56 ` Mark Walters
2012-04-09 7:15 ` Jameson Graef Rollins
2012-04-09 18:22 ` Mark Walters
2012-04-09 18:42 ` Mark Walters
2012-04-09 18:39 ` [PATCH 5/8] emacs: modify search " Mark Walters
2012-04-14 19:07 ` Jameson Graef Rollins
2012-04-09 17:57 ` [PATCH 2/8] emacs: update tag-completion function Mark Walters
2012-04-09 18:09 ` Jameson Graef Rollins
2012-04-14 18:52 ` emacs tagging cleanup, v3 Jameson Graef Rollins
2012-04-14 18:52 ` [PATCH 1/5] emacs: create notmuch-tag.el, and move appropriate functions from notmuch.el Jameson Graef Rollins
2012-04-14 18:52 ` [PATCH 2/5] emacs: allow notmuch-tag to accept string inputs and prompt for tags Jameson Graef Rollins
2012-04-14 18:52 ` [PATCH 3/5] emacs: modify search tag functions to use new notmuch-tag interface Jameson Graef Rollins
2012-04-14 18:52 ` [PATCH 4/5] emacs: modify show " Jameson Graef Rollins
2012-04-14 18:52 ` [PATCH 5/5] emacs: eliminate search-tag-thread in favor of just search-tag Jameson Graef Rollins
2012-04-14 20:35 ` [PATCH 2/5] emacs: allow notmuch-tag to accept string inputs and prompt for tags Mark Walters
2012-04-14 20:49 ` [PATCH v2 " Jameson Graef Rollins
2012-04-28 8:30 ` emacs tagging cleanup, v3 Tomi Ollila
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://notmuchmail.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1333845338-22960-9-git-send-email-jrollins@finestructure.net \
--to=jrollins@finestructure.net \
--cc=notmuch@notmuchmail.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://yhetil.org/notmuch.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).