unofficial mirror of notmuch@notmuchmail.org
 help / color / mirror / code / Atom feed
From: Mark Walters <markwalters1009@gmail.com>
To: notmuch@notmuchmail.org
Subject: [PATCH v3 0/6] Move --no-exclude to --exclude=(true|false|flag)
Date: Fri,  6 Apr 2012 13:49:05 +0100	[thread overview]
Message-ID: <1333716551-29153-1-git-send-email-markwalters1009@gmail.com> (raw)

This is the latest version of the patch series (previous version at [1]).
I think this version fixes all the problems raised by Austin in his review.

In particular it 
   rephrases the documentation comment for
   notmuch_query_set_omit_excluded_messages in notmuch.h, and renames
   the function to notmuch_query_set_omit_excluded.

   Corrects the comments and the warning message in notmuch-search.c

   Modifies the generate_thread function in the search-excludes
   test. This function now sets gen_thread_id to the id of the
   generated threads and populates an array gen_thread_msg_id with the
   message ids of the the messages in the threads. It also slightly
   changes the subjects to "subject: top message" and "subject: reply
   n" where n is the depth in the thread.

The last of these should be checked as I am not very familiar with
bash quoting so could easily have omitted needed quotes.

Best wishes

Mark

[1] id:"1333234442-28616-1-git-send-email-markwalters1009@gmail.com"

Mark Walters (6):
  lib: change default for notmuch_query_set_omit_excluded
  cli: move count to the new --exclude=(true|false|flag) naming scheme.
  cli: move search to the new --exclude= naming scheme.
  test: add some exclude tests
  cli: move show to the new --exclude= option naming scheme.
  emacs: make show set --exclude=false

 emacs/notmuch-show.el     |    6 +-
 lib/notmuch.h             |   23 ++++-
 lib/query.cc              |   10 +-
 man/man1/notmuch-count.1  |    5 +-
 man/man1/notmuch-search.1 |   12 ++-
 man/man1/notmuch-show.1   |   16 +++-
 notmuch-client.h          |    1 +
 notmuch-count.c           |   17 +++-
 notmuch-search.c          |   32 +++++--
 notmuch-show.c            |   50 +++++++----
 test/count                |    4 +-
 test/notmuch-test         |    1 +
 test/search               |   48 ----------
 test/search-excludes      |  219 +++++++++++++++++++++++++++++++++++++++++++++
 14 files changed, 342 insertions(+), 102 deletions(-)
 create mode 100755 test/search-excludes

-- 
1.7.9.1

             reply	other threads:[~2012-04-06 12:49 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-04-06 12:49 Mark Walters [this message]
2012-04-06 12:49 ` [PATCH v3 1/6] lib: change default for notmuch_query_set_omit_excluded Mark Walters
2012-04-06 12:49 ` [PATCH v3 2/6] cli: move count to the new --exclude=(true|false|flag) naming scheme Mark Walters
2012-04-06 12:49 ` [PATCH v3 3/6] cli: move search to the new --exclude= " Mark Walters
2012-04-06 12:49 ` [PATCH v3 4/6] test: add some exclude tests Mark Walters
2012-04-06 12:49 ` [PATCH v3 5/6] cli: move show to the new --exclude= option naming scheme Mark Walters
2012-04-06 12:49 ` [PATCH v3 6/6] emacs: make show set --exclude=false Mark Walters
2012-04-06 15:13 ` [PATCH v3 0/6] Move --no-exclude to --exclude=(true|false|flag) Jameson Graef Rollins
2012-04-06 15:38   ` Mark Walters
2012-04-06 16:19     ` Jameson Graef Rollins

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://notmuchmail.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1333716551-29153-1-git-send-email-markwalters1009@gmail.com \
    --to=markwalters1009@gmail.com \
    --cc=notmuch@notmuchmail.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://yhetil.org/notmuch.git/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).