* emacs: Function `remove-if' from cl package called at runtime @ 2012-03-29 3:15 Adam Wolfe Gordon 2012-03-29 4:33 ` [PATCH] emacs: Suppress warnings about using cl " Austin Clements 0 siblings, 1 reply; 4+ messages in thread From: Adam Wolfe Gordon @ 2012-03-29 3:15 UTC (permalink / raw) To: Notmuch Mail Hi everyone, As I was fixing the Refrences bug tonight (patch forthcoming), I introduced another usage of a cl library function that produces the warning from emacs: Warning: Function `remove-if' from cl package called at runtime Reading a bit about this warning, it sounds like the reason for it is that remove-if et al. are functions, so they can be replaced by some other package, and the emacs folks don't want packages included with emacs to use them because they would then break if the functions were redefined. Are we worried about this in notmuch? It seems to me like it's mostly political, but I'm pretty new to the emacs lisp world. I remember that some time ago it was decided that we were OK with using functions the cl library where it improves code quality. What do we think of using functions that cause the "called at runtime" warning? -- Adam Wolfe Gordon ^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH] emacs: Suppress warnings about using cl at runtime 2012-03-29 3:15 emacs: Function `remove-if' from cl package called at runtime Adam Wolfe Gordon @ 2012-03-29 4:33 ` Austin Clements 2012-03-29 4:38 ` Adam Wolfe Gordon 2012-06-03 16:32 ` David Bremner 0 siblings, 2 replies; 4+ messages in thread From: Austin Clements @ 2012-03-29 4:33 UTC (permalink / raw) To: notmuch It was decided in the thread starting at [0] that it is okay for notmuch to use 'cl runtime functions. However, by default, these produce byte compiler warnings. This suppresses those using file-local variables. [0] id:"m262g864dz.fsf@wal122.wireless-pennnet.upenn.edu" --- emacs/notmuch-lib.el | 3 +++ 1 files changed, 3 insertions(+), 0 deletions(-) diff --git a/emacs/notmuch-lib.el b/emacs/notmuch-lib.el index c146748..a9191f8 100644 --- a/emacs/notmuch-lib.el +++ b/emacs/notmuch-lib.el @@ -266,3 +266,6 @@ was called." (provide 'notmuch-lib) +;; Local Variables: +;; byte-compile-warnings: (not cl-functions) +;; End: -- 1.7.9.1 ^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] emacs: Suppress warnings about using cl at runtime 2012-03-29 4:33 ` [PATCH] emacs: Suppress warnings about using cl " Austin Clements @ 2012-03-29 4:38 ` Adam Wolfe Gordon 2012-06-03 16:32 ` David Bremner 1 sibling, 0 replies; 4+ messages in thread From: Adam Wolfe Gordon @ 2012-03-29 4:38 UTC (permalink / raw) To: Austin Clements; +Cc: notmuch Works for me. notmuch-mua.el also uses remove-if, so it should get the same treatment. ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] emacs: Suppress warnings about using cl at runtime 2012-03-29 4:33 ` [PATCH] emacs: Suppress warnings about using cl " Austin Clements 2012-03-29 4:38 ` Adam Wolfe Gordon @ 2012-06-03 16:32 ` David Bremner 1 sibling, 0 replies; 4+ messages in thread From: David Bremner @ 2012-06-03 16:32 UTC (permalink / raw) To: Austin Clements, notmuch Austin Clements <amdragon@MIT.EDU> writes: > It was decided in the thread starting at [0] that it is okay for > notmuch to use 'cl runtime functions. However, by default, these > produce byte compiler warnings. This suppresses those using > file-local variables. Pushed, no idea why it took so long. d ^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2012-06-03 16:32 UTC | newest] Thread overview: 4+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2012-03-29 3:15 emacs: Function `remove-if' from cl package called at runtime Adam Wolfe Gordon 2012-03-29 4:33 ` [PATCH] emacs: Suppress warnings about using cl " Austin Clements 2012-03-29 4:38 ` Adam Wolfe Gordon 2012-06-03 16:32 ` David Bremner
Code repositories for project(s) associated with this public inbox https://yhetil.org/notmuch.git/ This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).