emacs: Function `remove-if' from cl package called at runtime

emacs: Function `remove-if' from cl package called at runtime

[Adam Wolfe Gordon]

Hi everyone,

As I was fixing the Refrences bug tonight (patch forthcoming), I
introduced another usage of a cl library function that produces the
warning from emacs:
Warning: Function `remove-if' from cl package called at runtime

Reading a bit about this warning, it sounds like the reason for it is
that remove-if et al. are functions, so they can be replaced by some
other package, and the emacs folks don't want packages included with
emacs to use them because they would then break if the functions were
redefined. Are we worried about this in notmuch? It seems to me like
it's mostly political, but I'm pretty new to the emacs lisp world.

I remember that some time ago it was decided that we were OK with
using functions the cl library where it improves code quality. What do
we think of using functions that cause the "called at runtime"
warning?

-- 
Adam Wolfe Gordon

[PATCH] emacs: Suppress warnings about using cl at runtime

[Austin Clements]

It was decided in the thread starting at [0] that it is okay for
notmuch to use 'cl runtime functions.  However, by default, these
produce byte compiler warnings.  This suppresses those using
file-local variables.

[0] id:"m262g864dz.fsf@wal122.wireless-pennnet.upenn.edu"
---
 emacs/notmuch-lib.el |    3 +++
 1 files changed, 3 insertions(+), 0 deletions(-)

diff --git a/emacs/notmuch-lib.el b/emacs/notmuch-lib.el
index c146748..a9191f8 100644
--- a/emacs/notmuch-lib.el
+++ b/emacs/notmuch-lib.el
@@ -266,3 +266,6 @@ was called."
 
 (provide 'notmuch-lib)
 
+;; Local Variables:
+;; byte-compile-warnings: (not cl-functions)
+;; End:
-- 
1.7.9.1

Re: [PATCH] emacs: Suppress warnings about using cl at runtime

[Adam Wolfe Gordon]

Works for me. notmuch-mua.el also uses remove-if, so it should get the
same treatment.

Re: [PATCH] emacs: Suppress warnings about using cl at runtime

[David Bremner]

Austin Clements <amdragon@MIT.EDU> writes:

> It was decided in the thread starting at [0] that it is okay for
> notmuch to use 'cl runtime functions.  However, by default, these
> produce byte compiler warnings.  This suppresses those using
> file-local variables.

Pushed, no idea why it took so long.

d