unofficial mirror of notmuch@notmuchmail.org
 help / color / mirror / code / Atom feed
From: Adam Wolfe Gordon <awg+notmuch@xvx.ca>
To: notmuch@notmuchmail.org
Subject: [BUG/PATCH 0/2] Replying from other addresses in emacs
Date: Sat, 24 Mar 2012 18:27:10 -0600	[thread overview]
Message-ID: <1332635232-15269-1-git-send-email-awg+notmuch@xvx.ca> (raw)

Hi everyone,

This patch series adds a test for and fixes a bug that Dmitry pointed
out on IRC yesterday:

When replying to mail sent to an other_address, the CLI correctly sets
the From header to the address that received the message. This works
correctly in the default format and the JSON format.  However, emacs was
ignoring the provided From header and inserting the primary address, due
to an incompatibility between how we construct the header list and how
the `mail-header` function from the message library looks up header
values in the list.

People with other_addresses who are using the latest reply changes
should probably apply this patch right away. Without it, you might end
up replying to messages from the wrong address.

Adam Wolfe Gordon (2):
  test: Tests for reply from alternate addresses in emacs
  emacs: Fix replying from alternate addresses

 emacs/notmuch-mua.el |    4 +-
 test/emacs           |   51 ++++++++++++++++++++++++++++++++++++++++++++++++++
 2 files changed, 53 insertions(+), 2 deletions(-)

-- 
1.7.5.4

             reply	other threads:[~2012-03-25  0:27 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-03-25  0:27 Adam Wolfe Gordon [this message]
2012-03-25  0:27 ` [BUG/PATCH 1/2] test: Tests for reply from alternate addresses in emacs Adam Wolfe Gordon
2012-03-26 17:01   ` Dmitry Kurochkin
2012-03-25  0:27 ` [BUG/PATCH 2/2] emacs: Fix replying from alternate addresses Adam Wolfe Gordon
2012-03-25 12:22   ` Mark Walters
2012-03-26 17:02   ` Dmitry Kurochkin
2012-03-28 13:33 ` [BUG/PATCH v2 0/2] Replying from other addresses in emacs Adam Wolfe Gordon
2012-03-28 13:33   ` [BUG/PATCH v2 1/2] test: Tests for reply from alternate " Adam Wolfe Gordon
2012-03-28 13:33   ` [BUG/PATCH v2 2/2] emacs: Fix replying from alternate addresses Adam Wolfe Gordon
2012-03-28 22:10   ` [BUG/PATCH v2 0/2] Replying from other addresses in emacs Jameson Graef Rollins

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://notmuchmail.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1332635232-15269-1-git-send-email-awg+notmuch@xvx.ca \
    --to=awg+notmuch@xvx.ca \
    --cc=notmuch@notmuchmail.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://yhetil.org/notmuch.git/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).