tiny and obviously correct (tm) fix for 0.12

tiny and obviously correct (tm) fix for 0.12

[Justus Winter]

I've been going through the bindings lately and have some stuff in the
pipeline that has to wait until 0.12 is out, but I've noticed two
small and obvious errors I made when I annotated all the wrapped
libnotmuch functions.

The following patch addresses this problem and since it's a really
small change I'd like to see this in 0.12. What do you think?

Justus

[PATCH] python: fix signature of two wrapped libnotmuch functions

[Justus Winter]

Signed-off-by: Justus Winter <4winter@informatik.uni-hamburg.de>
---
 bindings/python/notmuch/directory.py |    2 +-
 bindings/python/notmuch/threads.py   |    2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/bindings/python/notmuch/directory.py b/bindings/python/notmuch/directory.py
index 0c5e015..284cbdc 100644
--- a/bindings/python/notmuch/directory.py
+++ b/bindings/python/notmuch/directory.py
@@ -177,7 +177,7 @@ class Directory(object):
 
     _destroy = nmlib.notmuch_directory_destroy
     _destroy.argtypes = [NotmuchDirectoryP]
-    _destroy.argtypes = None
+    _destroy.restype = None
 
     def __del__(self):
         """Close and free the Directory"""
diff --git a/bindings/python/notmuch/threads.py b/bindings/python/notmuch/threads.py
index 690206e..225f524 100644
--- a/bindings/python/notmuch/threads.py
+++ b/bindings/python/notmuch/threads.py
@@ -172,7 +172,7 @@ class Threads(Python3StringMixIn):
 
     _destroy = nmlib.notmuch_threads_destroy
     _destroy.argtypes = [NotmuchThreadsP]
-    _destroy.argtypes = None
+    _destroy.restype = None
 
     def __del__(self):
         """Close and free the notmuch Threads"""
-- 
1.7.9.1

Re: [PATCH] python: fix signature of two wrapped libnotmuch functions

[Austin Clements]

Quoth Justus Winter on Mar 16 at  1:56 pm:
> Signed-off-by: Justus Winter <4winter@informatik.uni-hamburg.de>

Ah, ctypes.  Because *of course* it makes sense to guess the type
signatures for an ABI that will crash if you guess wrong.

LGTM.  I'd say it's safe to include in 0.12.

Re: [PATCH] python: fix signature of two wrapped libnotmuch functions

[David Bremner]

On Fri, 16 Mar 2012 13:56:32 +0100, Justus Winter <4winter@informatik.uni-hamburg.de> wrote:
> Signed-off-by: Justus Winter <4winter@informatik.uni-hamburg.de>
> ---
>  bindings/python/notmuch/directory.py |    2 +-
>  bindings/python/notmuch/threads.py   |    2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)

Pushed to 0.12