unofficial mirror of notmuch@notmuchmail.org
 help / color / mirror / code / Atom feed
From: Mark Walters <markwalters1009@gmail.com>
To: notmuch@notmuchmail.org
Subject: [PATCH 0/5] Move to --with-excluded approach to excludes
Date: Sat,  3 Mar 2012 13:05:13 +0000	[thread overview]
Message-ID: <1330779918-28024-1-git-send-email-markwalters1009@gmail.com> (raw)

This series implements the proposal in id:"87y5riuz7v.fsf@qmul.ac.uk"
to move to a consistent --with-excluded approach rather than the
previous --no-exclude approach. See the message there and its
descendants for discussion.

The main user side change is that notmuch-search no longer defaults to
showing all the excluded threads with [0/n] but will do so if the user
says they want all the messages (i.e., by specifying --with-excluded).

However, it makes everything consistent throughout the commandline and
lib interfaces. In all cases a "message" type search only returns the
non-excluded matches (unless --with-excluded is specified) and a
"thread" type search returns all messages (including excluded ones) in
threads that match in a non-excluded message.

The patch series is bigger than I would like but it is relatively
simple: the slightly tricky logic of the original series is
untouched. This series just changes the names and defaults fed to the
existing logic.

The only slightly complicated part is the notmuch-show.c patch as it
has to decide quite what to do in lots of cases. See
id:"87d38t26wp.fsf@qmul.ac.uk" for reasons for the precise choices
made.

Best wishes

Mark

Mark Walters (5):
  lib: rename (and negate) set_omit_excluded set_with_excluded
  cli: move count to the new --with-excluded naming scheme.
  cli: move search to the new --with-excluded naming scheme.
  cli: move show to the new --with-excluded naming scheme.
  emacs: make show set --with-excluded

 emacs/notmuch-show.el     |    6 ++++--
 lib/notmuch.h             |   12 +++++++-----
 lib/query.cc              |   10 +++++-----
 man/man1/notmuch-count.1  |    4 ++--
 man/man1/notmuch-search.1 |    6 ++++--
 man/man1/notmuch-show.1   |    5 +++--
 notmuch-client.h          |    1 +
 notmuch-count.c           |   11 ++++++-----
 notmuch-search.c          |   20 +++++++++++---------
 notmuch-show.c            |   38 +++++++++++++++++++++-----------------
 test/count                |    4 ++--
 test/search               |    9 ++++-----
 12 files changed, 70 insertions(+), 56 deletions(-)

-- 
1.7.2.3

             reply	other threads:[~2012-03-03 13:03 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-03-03 13:05 Mark Walters [this message]
2012-03-03 13:05 ` [PATCH 1/5] lib: rename (and negate) set_omit_excluded set_with_excluded Mark Walters
2012-03-03 13:05 ` [PATCH 2/5] cli: move count to the new --with-excluded naming scheme Mark Walters
2012-03-03 13:05 ` [PATCH 3/5] cli: move search " Mark Walters
2012-03-03 13:05 ` [PATCH 4/5] cli: move show " Mark Walters
2012-03-03 13:05 ` [PATCH 5/5] emacs: make show set --with-excluded Mark Walters
2012-03-11  1:19 ` [PATCH 0/5] Move to --with-excluded approach to excludes Jameson Graef Rollins

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://notmuchmail.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1330779918-28024-1-git-send-email-markwalters1009@gmail.com \
    --to=markwalters1009@gmail.com \
    --cc=notmuch@notmuchmail.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://yhetil.org/notmuch.git/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).