From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by olra.theworths.org (Postfix) with ESMTP id 01E2E41601B for ; Fri, 24 Feb 2012 14:33:33 -0800 (PST) X-Virus-Scanned: Debian amavisd-new at olra.theworths.org X-Spam-Flag: NO X-Spam-Score: -0.7 X-Spam-Level: X-Spam-Status: No, score=-0.7 tagged_above=-999 required=5 tests=[RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled Received: from olra.theworths.org ([127.0.0.1]) by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id VvSucD5MqAo7 for ; Fri, 24 Feb 2012 14:33:31 -0800 (PST) Received: from mail-ww0-f45.google.com (mail-ww0-f45.google.com [74.125.82.45]) (using TLSv1 with cipher RC4-SHA (128/128 bits)) (No client certificate requested) by olra.theworths.org (Postfix) with ESMTPS id 74DBB415D33 for ; Fri, 24 Feb 2012 14:33:30 -0800 (PST) Received: by mail-ww0-f45.google.com with SMTP id dt12so2226566wgb.2 for ; Fri, 24 Feb 2012 14:33:30 -0800 (PST) Received-SPF: pass (google.com: domain of pieter@praet.org designates 10.180.78.6 as permitted sender) client-ip=10.180.78.6; Authentication-Results: mr.google.com; spf=pass (google.com: domain of pieter@praet.org designates 10.180.78.6 as permitted sender) smtp.mail=pieter@praet.org Received: from mr.google.com ([10.180.78.6]) by 10.180.78.6 with SMTP id x6mr9059792wiw.18.1330122810212 (num_hops = 1); Fri, 24 Feb 2012 14:33:30 -0800 (PST) MIME-Version: 1.0 Received: by 10.180.78.6 with SMTP id x6mr7203417wiw.18.1330122810163; Fri, 24 Feb 2012 14:33:30 -0800 (PST) Received: from localhost ([109.131.181.26]) by mx.google.com with ESMTPS id fw5sm6322722wib.0.2012.02.24.14.33.29 (version=TLSv1/SSLv3 cipher=OTHER); Fri, 24 Feb 2012 14:33:29 -0800 (PST) From: Pieter Praet To: David Bremner , Dmitry Kurochkin Subject: [PATCH v2 5/6] emacs: simplify `notmuch-show-get-messages-ids{, -search}' Date: Fri, 24 Feb 2012 23:30:39 +0100 Message-Id: <1330122640-18895-6-git-send-email-pieter@praet.org> X-Mailer: git-send-email 1.7.8.1 In-Reply-To: <1330122640-18895-1-git-send-email-pieter@praet.org> References: <87wr7xqpuf.fsf@rocinante.cs.unb.ca> <1330122640-18895-1-git-send-email-pieter@praet.org> X-Gm-Message-State: ALoCoQnkl5HkH4cNY8FyzGD6qvIaASUz3WPRsQqmpqrT4sq1K5xOpjSmPtanzXFUqXvzrp//iysS Cc: Notmuch Mail X-BeenThere: notmuch@notmuchmail.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 24 Feb 2012 22:33:33 -0000 * emacs/notmuch-show.el (notmuch-show-get-messages-ids): If provided with optional arg SEPARATOR, return a string consisting of all Message-Id's, separated by SEPARATOR. Also improve original docstring wrt default return value. (notmuch-show-get-messages-ids-search): Removed, as its functionality is now in `notmuch-show-get-messages-ids'. (notmuch-show-tag-all): Call `notmuch-show-get-messages-ids' with SEPARATOR arg instead of `notmuch-show-get-messages-ids-search'. --- emacs/notmuch-show.el | 18 +++++++++--------- 1 files changed, 9 insertions(+), 9 deletions(-) diff --git a/emacs/notmuch-show.el b/emacs/notmuch-show.el index 6adbdc0..05606fc 100644 --- a/emacs/notmuch-show.el +++ b/emacs/notmuch-show.el @@ -1339,17 +1339,17 @@ (defun notmuch-show-get-message-id () "Return the message id of the current message." (concat "id:\"" (notmuch-show-get-prop :id) "\"")) -(defun notmuch-show-get-messages-ids () - "Return all message ids of messages in the current thread." +(defun notmuch-show-get-messages-ids (&optional separator) + "Return a list of Message-Id's of all messages in the current buffer. + +If provided with optional argument SEPARATOR, return a string +instead, consisting of all Message-Id's separated by SEPARATOR." (let ((message-ids)) (notmuch-show-mapc (lambda () (push (notmuch-show-get-message-id) message-ids))) - message-ids)) - -(defun notmuch-show-get-messages-ids-search () - "Return a search string for all message ids of messages in the -current thread." - (mapconcat 'identity (notmuch-show-get-messages-ids) " or ")) + (if separator + (mapconcat 'identity message-ids separator) + message-ids))) ;; dme: Would it make sense to use a macro for many of these? @@ -1638,7 +1638,7 @@ (defun notmuch-show-tag-all (&rest tag-changes) TAG-CHANGES is a list of tag operations for `notmuch-tag'." (interactive (notmuch-read-tag-changes nil notmuch-show-thread-id)) - (apply 'notmuch-tag (notmuch-show-get-messages-ids-search) tag-changes) + (apply 'notmuch-tag (notmuch-show-get-messages-ids " or ") tag-changes) (notmuch-show-mapc (lambda () (let* ((current-tags (notmuch-show-get-tags)) -- 1.7.8.1