From: Mark Walters <markwalters1009@gmail.com>
To: notmuch@notmuchmail.org
Subject: [PATCH 0/2] Make elide messages use cli side
Date: Thu, 23 Feb 2012 21:41:32 +0000 [thread overview]
Message-ID: <1330033294-21980-1-git-send-email-markwalters1009@gmail.com> (raw)
Currently the elide messages option in notmuch-show.el fetches all
messages in the thread (via notmuch-show.c) parses the JSON and throws
away all the non-matching messages.
This patch removes the entire-thread assumption for format=json from
notmuch-show.c. This allows the emacs code to call notmuch-show with
out the --entire-thread flag and just receive the matching messages
(but with the full thread structure) in return.
This makes notmuch-show.c much faster (but in practice this is small
anyway) but more importantly substantially improves the speed of the
JSON parsing. Rough wall clock timing on my system shows (best case) a
4 second time for showing a large thread (170 messages) reduced to an
almost instant time for a single matching message from that thread.
For the existing show view the gain is nice but not critical. However,
notmuch-pick shows a single message at a time and the speed increase
will be needed there.
Best wishes
Mark
Mark Walters (2):
emacs/cli: remove entire-thread default from show: JSON
emacs: make elide messages use notmuch-show for omitting messages.
emacs/notmuch-show.el | 15 +++++++++------
notmuch-show.c | 1 -
2 files changed, 9 insertions(+), 7 deletions(-)
--
1.7.2.3
next reply other threads:[~2012-02-23 21:40 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-23 21:41 Mark Walters [this message]
2012-02-23 21:41 ` [PATCH 1/2] emacs/cli: remove entire-thread default from show: JSON Mark Walters
2012-02-23 21:45 ` Adam Wolfe Gordon
2012-02-23 22:04 ` Mark Walters
2012-02-23 21:41 ` [PATCH 2/2] emacs: make elide messages use notmuch-show for omitting messages Mark Walters
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://notmuchmail.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1330033294-21980-1-git-send-email-markwalters1009@gmail.com \
--to=markwalters1009@gmail.com \
--cc=notmuch@notmuchmail.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://yhetil.org/notmuch.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).