unofficial mirror of notmuch@notmuchmail.org
 help / color / mirror / code / Atom feed
From: Adam Wolfe Gordon <awg+notmuch@xvx.ca>
To: notmuch@notmuchmail.org
Subject: [PATCH v6 00/10] Reply improvements
Date: Tue, 21 Feb 2012 23:46:29 -0700	[thread overview]
Message-ID: <1329893199-21630-1-git-send-email-awg+notmuch@xvx.ca> (raw)

Hi all,

This is an updated version of my previous series [1], primarily addressing
the concerns from Austin's review. The big changes are:

* Documentation: add a TODO regarding reply to multiple messages and the
  JSON reply format to schemata.

* Emacs: using plists instead of alists in JSON parsing, and the resulting
  adjustments to the code that consumes the parsed data.

* Emacs: slightly nicer handling of multipart/alternative parts. In
  particular, quote only the last part of desirable type instead of all the
  parts of desirable type.

* Split up the reply patch to make things a bit more clear.

I noticed that the factoring out reply creation patch has been promoted to
"maybe ready" in nmbug. I think this version is unchanged, but since the
old one hasn't been pushed this one can probably replace it there.

[1] id:"1329361957-28493-1-git-send-email-awg+notmuch@xvx.ca"

Adam Wolfe Gordon (10):
  test: Add broken test for the new JSON reply format.
  reply: Factor out reply creation
  reply: Require that only one message is returned
  TODO: Add replying to multiple messages
  reply: Add a JSON reply format.
  schemata: Add documentation for JSON reply format.
  man: Update notmuch-reply man page for JSON format.
  emacs: Factor out useful functions into notmuch-lib
  test: Add broken tests for new emacs reply functionality
  emacs: Use the new JSON reply format and message-cite-original

 devel/TODO               |    5 ++
 devel/schemata           |   27 +++++++-
 emacs/notmuch-lib.el     |   44 ++++++++++++
 emacs/notmuch-mua.el     |  132 +++++++++++++++++++++++++-----------
 emacs/notmuch-show.el    |   24 +------
 man/man1/notmuch-reply.1 |    5 ++
 notmuch-client.h         |   10 ++-
 notmuch-reply.c          |  166 ++++++++++++++++++++++++++++++++--------------
 notmuch-show.c           |   30 ++++++--
 test/emacs               |  101 +++++++++++++++++++++++++++-
 test/multipart           |   51 ++++++++++++++
 11 files changed, 468 insertions(+), 127 deletions(-)

-- 
1.7.5.4

             reply	other threads:[~2012-02-22  6:46 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-02-22  6:46 Adam Wolfe Gordon [this message]
2012-02-22  6:46 ` [PATCH v6 01/10] test: Add broken test for the new JSON reply format Adam Wolfe Gordon
2012-02-22  6:46 ` [PATCH v6 02/10] reply: Factor out reply creation Adam Wolfe Gordon
2012-03-08 22:05   ` Jani Nikula
2012-02-22  6:46 ` [PATCH v6 03/10] reply: Require that only one message is returned Adam Wolfe Gordon
2012-03-09 23:00   ` Jani Nikula
2012-03-10 18:29     ` Adam Wolfe Gordon
2012-03-12  0:29     ` Austin Clements
2012-02-22  6:46 ` [PATCH v6 04/10] TODO: Add replying to multiple messages Adam Wolfe Gordon
2012-02-22  6:46 ` [PATCH v6 05/10] reply: Add a JSON reply format Adam Wolfe Gordon
2012-03-09 23:08   ` Jani Nikula
2012-03-10 18:27     ` Adam Wolfe Gordon
2012-02-22  6:46 ` [PATCH v6 06/10] schemata: Add documentation for " Adam Wolfe Gordon
2012-03-12  0:36   ` Austin Clements
2012-03-12  4:09     ` Adam Wolfe Gordon
2012-03-12 20:57       ` Austin Clements
2012-02-22  6:46 ` [PATCH v6 07/10] man: Update notmuch-reply man page for JSON format Adam Wolfe Gordon
2012-02-22  6:46 ` [PATCH v6 08/10] emacs: Factor out useful functions into notmuch-lib Adam Wolfe Gordon
2012-02-22  6:46 ` [PATCH v6 09/10] test: Add broken tests for new emacs reply functionality Adam Wolfe Gordon
2012-02-22  6:46 ` [PATCH v6] emacs: Use the new JSON reply format and message-cite-original Adam Wolfe Gordon
2012-03-09 23:13   ` Jani Nikula
2012-03-10 18:19     ` Adam Wolfe Gordon
2012-03-12  1:11   ` Austin Clements
2012-02-25 21:29 ` [PATCH v6 00/10] Reply improvements David Bremner
2012-02-25 22:25   ` Adam Wolfe Gordon
2012-02-26  0:23     ` Austin Clements

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://notmuchmail.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1329893199-21630-1-git-send-email-awg+notmuch@xvx.ca \
    --to=awg+notmuch@xvx.ca \
    --cc=notmuch@notmuchmail.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://yhetil.org/notmuch.git/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).