From: Thomas Jost <schnouki@schnouki.net>
To: notmuch@notmuchmail.org
Subject: [PATCH] build: Require gmime 2.6.5
Date: Tue, 21 Feb 2012 20:35:35 +0100 [thread overview]
Message-ID: <1329852935-3019-1-git-send-email-schnouki@schnouki.net> (raw)
In-Reply-To: <m2obssyvwi.fsf@guru.guru-group.fi>
gmime-2.6 had a bug [1] which made it impossible to tell why a signature
verification failed when the signer key was unavailable (empty "sigstatus" field
in the JSON output). Since 00b5623d the corresponding test is marked as broken
when using gmime-2.6 (2.4 is fine).
This bug has been fixed in gmime 2.6.5, which is now the minimal gmime-2.6
version required for building notmuch (gmime-2.4 is still available). As a
consequence the version check in test/crypto can be removed.
[1] https://bugzilla.gnome.org/show_bug.cgi?id=668085
---
Hi Tomi, hi again list,
I agree it's a better solution.
Here is another patch that makes gmime >= 2.6.5 a requirement.
Building against gmime-2.4 is of course still possible.
Apparently gmime 2.6.5 is not available yet in Debian, nor in Fedora,
so I think we should wait a little bit before pushing this.
Best regards,
Thomas
configure | 4 +++-
test/crypto | 2 --
2 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/configure b/configure
index 8b85b9d..279e650 100755
--- a/configure
+++ b/configure
@@ -273,9 +273,11 @@ if [ ${have_xapian} = "0" ]; then
errors=$((errors + 1))
fi
+# If using GMime 2.6, we need to have a version >= 2.6.5 to avoid a
+# crypto bug.
printf "Checking for GMime development files... "
have_gmime=0
-for gmimepc in gmime-2.6 gmime-2.4; do
+for gmimepc in 'gmime-2.6 >= 2.6.5' gmime-2.4; do
if pkg-config --exists $gmimepc; then
printf "Yes ($gmimepc).\n"
have_gmime=1
diff --git a/test/crypto b/test/crypto
index 1dbb60a..6723ef8 100755
--- a/test/crypto
+++ b/test/crypto
@@ -104,8 +104,6 @@ test_expect_equal \
"$expected"
test_begin_subtest "signature verification with signer key unavailable"
-# this is broken with current versions of gmime-2.6
-(ldd $(which notmuch) | grep -Fq gmime-2.6) && test_subtest_known_broken
# move the gnupghome temporarily out of the way
mv "${GNUPGHOME}"{,.bak}
output=$(notmuch show --format=json --verify subject:"test signed message 001" \
--
1.7.9.1
next prev parent reply other threads:[~2012-02-21 19:35 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-21 16:05 [PATCH] Update crypto test for gmime 2.6.5 Thomas Jost
2012-02-21 16:49 ` Tomi Ollila
2012-02-21 19:35 ` Thomas Jost [this message]
2012-03-12 1:29 ` [PATCH] build: Require gmime >= 2.6.7 David Bremner
2012-03-13 7:56 ` Tomi Ollila
2012-03-14 1:18 ` David Bremner
2012-02-21 19:45 ` [PATCH] Update crypto test for gmime 2.6.5 Daniel Kahn Gillmor
2012-02-22 1:55 ` Daniel Kahn Gillmor
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://notmuchmail.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1329852935-3019-1-git-send-email-schnouki@schnouki.net \
--to=schnouki@schnouki.net \
--cc=notmuch@notmuchmail.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://yhetil.org/notmuch.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).