From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by olra.theworths.org (Postfix) with ESMTP id 41C17429E45 for ; Thu, 16 Feb 2012 23:49:32 -0800 (PST) X-Virus-Scanned: Debian amavisd-new at olra.theworths.org X-Spam-Flag: NO X-Spam-Score: 1.061 X-Spam-Level: * X-Spam-Status: No, score=1.061 tagged_above=-999 required=5 tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_BL_SPAMCOP_NET=1.246, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_SORBS_WEB=0.614] autolearn=disabled Received: from olra.theworths.org ([127.0.0.1]) by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id ZggeFi5f0x5r for ; Thu, 16 Feb 2012 23:49:31 -0800 (PST) Received: from mail-bk0-f53.google.com (mail-bk0-f53.google.com [209.85.214.53]) (using TLSv1 with cipher RC4-SHA (128/128 bits)) (No client certificate requested) by olra.theworths.org (Postfix) with ESMTPS id A136A429E42 for ; Thu, 16 Feb 2012 23:49:31 -0800 (PST) Received: by bkcit16 with SMTP id it16so3104161bkc.26 for ; Thu, 16 Feb 2012 23:49:30 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=from:to:subject:date:message-id:x-mailer:in-reply-to:references; bh=1nhnBkVjn9ZxqEWZAvRSVWZmvP1OA0bkCYmYJT14Dd4=; b=B2zoiwKzT4M6+X0nRs6AL9Dz4YnKX+M/jxZf4MWDOM09syeZ6symcG3f5ENJb9UmTo uoQvY+Q4ITiyIMqtuSR25d6t9YOQgdEbBN3AA9QyvuWJSN2oSvGRYLSnhO+WR/l/vD6k 13RDPmwXlMzY8KUra+8q5cBCgUPG5pVFeWC+E= Received: by 10.204.157.17 with SMTP id z17mr3684468bkw.37.1329464970170; Thu, 16 Feb 2012 23:49:30 -0800 (PST) Received: from localhost ([217.26.0.107]) by mx.google.com with ESMTPS id w15sm21279145bku.0.2012.02.16.23.49.26 (version=TLSv1/SSLv3 cipher=OTHER); Thu, 16 Feb 2012 23:49:27 -0800 (PST) From: Dmitry Kurochkin To: notmuch@notmuchmail.org Subject: [PATCH v9 0/2] emacs: User-defined sections in notmuch-hello Date: Fri, 17 Feb 2012 11:48:01 +0400 Message-Id: <1329464884-1653-1-git-send-email-dmitry.kurochkin@gmail.com> X-Mailer: git-send-email 1.7.9 In-Reply-To: <1310079227-19120-1-git-send-email-daniel.schoepe@googlemail.com> References: <1310079227-19120-1-git-send-email-daniel.schoepe@googlemail.com> X-BeenThere: notmuch@notmuchmail.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 17 Feb 2012 07:49:32 -0000 Hi all. I have finished reviewing the user-defined sections v8 series at last. I found only few minor issues, some of which are fixed by this v9 series and others can be fixed later or ignored (e.g. renaming notmuch-hello-insert-* functions to notmuch-hello-section-* or something more appropriate). I believe it does not make to delay this patches any more: they have been waiting long enough and each review/rebase round is hard for both the author and reviewer because the main patch is pretty big and not trivial. So I think we should push this now. I am sure Daniel and I will fix all issues that we may have missed :) Changes in v9 since v8: * correctly merge bc267b70b01c79f6bdda52641e9cd7574a151eff * fix :hide-if-empty description: s/and not hidden by show-if-empty/and not shown by show-empty-searches/ * fix typo in `notmuch-hello-target' docstring: s/globaly/global/ * add docstring for notmuch-hello-first-run * fix indentation in `notmuch-hello-insert-saved-searches' * fix indentation in `notmuch-hello-insert-searches' docstring * fix target position calculation in `notmuch-hello-insert-saved-searches' * s/User defined/User-defined/ in tests * move tests to a new emacs-hello file Regards, Dmitry