From: Adam Wolfe Gordon <awg+notmuch@xvx.ca>
To: notmuch@notmuchmail.org
Subject: [PATCH v4 0/4] Quoting HTML parts in reply (and other reply enhancements)
Date: Wed, 8 Feb 2012 17:21:52 -0700 [thread overview]
Message-ID: <1328746916-25447-1-git-send-email-awg+notmuch@xvx.ca> (raw)
In-Reply-To: <1326995217-27423-1-git-send-email-awg+notmuch@xvx.ca>
Hi everyone,
Here is a new and much-improved version of my series [1] adding support for
quoting HTML parts in replies using a JSON reply format. This version is, as
the diffs indicate, much more ambitious than previous versions, especially
on the emacs front:
* The JSON reply format now only includes headers (for both the original and
reply messages), as Dmitry pointed out that non-UTF8 characters sets cannot
be properly inlined in JSON.
* Thus, emacs now uses notmuch show to fetch the body of the original message
before creating the quoted body of the reply.
* In order to simplify this use of show, the JSON format no longer implies
--entire-thread. The other consumer of --format=json (notmuch-query.el) has
been updated to use --entire-thread when that's what it means, and the man
page has been updated.
* Emacs now pays attention to multipart structures when deciding which parts
to quote in a reply. This uses essentially the same logic as in show, some
of which has been factored out into notmuch-lib.el. In particular, emacs will
include all the text parts of a message, except the non-preferred ones in a
multipart/alternative part.
* There are two new emacs test cases to test and demonstrate the new reply
functionality. They show how it works a multipart/mixed and multipart/alternative
messages.
I think that covers everything... Please let me know if there is something I
haven't explained well. And, of course, please send reviews on this extensive
change.
[1] id:"1326995217-27423-1-git-send-email-awg+notmuch@xvx.ca"
Adam Wolfe Gordon (4):
test: Add broken test for the new JSON reply format.
reply: Add a JSON reply format.
man: Update notmuch-reply man page for JSON format.
emacs: Use the new JSON reply format and message-cite-original
emacs/notmuch-lib.el | 39 +++++++++++
emacs/notmuch-mua.el | 136 +++++++++++++++++++++++++++-----------
emacs/notmuch-query.el | 2 +-
emacs/notmuch-show.el | 24 +------
man/man1/notmuch-reply.1 | 5 ++
man/man1/notmuch-show.1 | 6 +--
notmuch-reply.c | 167 ++++++++++++++++++++++++++++++++++------------
notmuch-show.c | 1 -
test/emacs | 101 +++++++++++++++++++++++++++-
test/multipart | 7 ++
10 files changed, 375 insertions(+), 113 deletions(-)
--
1.7.5.4
next prev parent reply other threads:[~2012-02-09 0:22 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-19 17:46 [PATCH v3 0/5] Quoting HTML emails in reply Adam Wolfe Gordon
2012-01-19 17:46 ` [PATCH v3 1/5] test: Add broken test for the new JSON reply format Adam Wolfe Gordon
2012-01-19 17:46 ` [PATCH v3 2/5] reply: Add a " Adam Wolfe Gordon
2012-02-05 11:50 ` Mark Walters
2012-02-05 12:45 ` Mark Walters
2012-02-05 19:42 ` Adam Wolfe Gordon
2012-02-05 19:50 ` Dmitry Kurochkin
2012-02-06 3:44 ` Austin Clements
2012-02-06 6:27 ` Adam Wolfe Gordon
2012-01-19 17:46 ` [PATCH v3 3/5] man: Update notmuch-reply man page for JSON format Adam Wolfe Gordon
2012-01-19 17:46 ` [PATCH v3 4/5] emacs: Use the new JSON reply format Adam Wolfe Gordon
2012-02-05 12:41 ` Mark Walters
2012-01-19 17:46 ` [PATCH v3 5/5] emacs: Use message-citation-line-format in reply Adam Wolfe Gordon
2012-01-19 18:45 ` Aaron Ecay
2012-01-20 4:46 ` Adam Wolfe Gordon
2012-01-20 5:53 ` Aaron Ecay
2012-01-20 9:14 ` David Edmondson
2012-01-20 17:22 ` Adam Wolfe Gordon
2012-01-20 22:31 ` Tomi Ollila
2012-01-22 18:58 ` [PATCH v3 5/5] emacs: Use message-cite-original " Adam Wolfe Gordon
2012-02-09 0:21 ` Adam Wolfe Gordon [this message]
2012-02-09 0:21 ` [PATCH v4 1/4] test: Add broken test for the new JSON reply format Adam Wolfe Gordon
2012-02-09 0:21 ` [PATCH v4 2/4] reply: Add a " Adam Wolfe Gordon
2012-02-09 7:22 ` Dmitry Kurochkin
2012-02-10 4:27 ` Adam Wolfe Gordon
2012-02-10 8:39 ` Dmitry Kurochkin
2012-02-09 0:21 ` [PATCH v4 3/4] man: Update notmuch-reply man page for JSON format Adam Wolfe Gordon
2012-02-09 0:21 ` [PATCH v4 4/4] emacs: Use the new JSON reply format and message-cite-original Adam Wolfe Gordon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://notmuchmail.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1328746916-25447-1-git-send-email-awg+notmuch@xvx.ca \
--to=awg+notmuch@xvx.ca \
--cc=notmuch@notmuchmail.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://yhetil.org/notmuch.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).