unofficial mirror of notmuch@notmuchmail.org
 help / color / mirror / code / Atom feed
From: Aaron Ecay <aaronecay@gmail.com>
To: notmuch@notmuchmail.org
Subject: [PATCH 1/2] emacs: Add tests for quoting of MML tags in replies
Date: Sun, 29 Jan 2012 01:07:07 -0500	[thread overview]
Message-ID: <1327817229-18124-1-git-send-email-aaronecay@gmail.com> (raw)
In-Reply-To: <20120126191654.GF1940@mit.edu>

The test is broken at this time; the next commit will introduce a fix.
---

Thanks for the reminder, Austin.  Things got hectic, and it took a
little bludgeoning to get the test suite to behave.  I *think* I got
it, although I am by no means confident.  Specifically, I am seeing
some unrelated(?) test failures in the emacs suite, so I'd appreciate
it if someone with a well-functioning test suite tried out these
patches before they are pushed, to be sure I didn't break anything.

I tried to follow the "first patch introduces a failing test, second
patch fixes it" convention.

 test/emacs                           |   14 ++++++++++++++
 test/emacs.expected-output/quote-mml |    9 +++++++++
 2 files changed, 23 insertions(+), 0 deletions(-)
 create mode 100644 test/emacs.expected-output/quote-mml

diff --git a/test/emacs b/test/emacs
index 8ca4c8a..a57513a 100755
--- a/test/emacs
+++ b/test/emacs
@@ -273,6 +273,20 @@ On 01 Jan 2000 12:00:00 -0000, Notmuch Test Suite <test_suite@notmuchmail.org> w
 EOF
 test_expect_equal_file OUTPUT EXPECTED
 
+test_begin_subtest "Quote MML tags on reply"
+test_subtest_known_broken
+add_message '[from]="1337 h4xor <test@test.com>"' \
+            '[to]="Unsuspecting rube <luser@securityhole.com>"' \
+            '[subject]="hackety hack hack"' \
+            '[body]="<#part type="application/octet-stream" filename="foo" disposition=attachment>
+<#/part>"' \
+            '[id]="test-mml-quoting@msg.id"'
+test_emacs "(notmuch-show \"id:test-mml-quoting@msg.id\")
+            (notmuch-show-reply-sender)
+            (test-output)"
+test_expect_equal_file OUTPUT "$EXPECTED/quote-mml"
+
+
 test_begin_subtest "Save attachment from within emacs using notmuch-show-save-attachments"
 # save as archive to test that Emacs does not re-compress .gz
 test_emacs '(let ((standard-input "\"attachment1.gz\""))
diff --git a/test/emacs.expected-output/quote-mml b/test/emacs.expected-output/quote-mml
new file mode 100644
index 0000000..01bd2ca
--- /dev/null
+++ b/test/emacs.expected-output/quote-mml
@@ -0,0 +1,9 @@
+From: Notmuch Test Suite <test_suite@notmuchmail.org>
+To: 1337 h4xor <test@test.com>
+Subject: Re: hackety hack hack
+In-Reply-To: <test-mml-quoting@msg.id>
+Fcc: /home/aecay/development/notmuch/test/tmp.emacs/mail/sent
+--text follows this line--
+On Fri, 05 Jan 2001 15:43:57 +0000, 1337 h4xor <test@test.com> wrote:
+> <#!part type=application/octet-stream filename=foo disposition=attachment>
+> <#!/part>
-- 
1.7.9

  reply	other threads:[~2012-01-29  6:07 UTC|newest]

Thread overview: 40+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-01-19 18:43 [PATCH] emacs: Quote MML tags in replies Aaron Ecay
2012-01-19 22:23 ` Pieter Praet
2012-01-19 22:46   ` Austin Clements
2012-01-19 22:52     ` Aaron Ecay
2012-01-19 23:19       ` Pieter Praet
2012-01-19 22:48 ` Austin Clements
2012-01-19 22:56   ` Aaron Ecay
2012-01-19 23:21     ` Pieter Praet
2012-01-20  3:26       ` Aaron Ecay
2012-01-22  6:39         ` Pieter Praet
2012-01-26 19:16     ` Austin Clements
2012-01-29  6:07       ` Aaron Ecay [this message]
2012-01-29  6:07         ` [PATCH 2/2] " Aaron Ecay
2012-01-30  8:23           ` Tomi Ollila
2012-01-30 21:15         ` [PATCH 1/2] emacs: Add tests for quoting of " David Bremner
2012-01-20  7:33 ` [PATCH] emacs: Quote " David Edmondson
2012-01-20 12:14 ` David Bremner
2012-02-01  2:49 ` emacs: quote " Dmitry Kurochkin
2012-02-01  2:49   ` [PATCH v3 1/2] test: add tests for quoting of " Dmitry Kurochkin
2012-02-01 13:54     ` [PATCH v4 " Pieter Praet
2012-02-01 20:36       ` [PATCH v5 " Pieter Praet
2012-02-01  2:49   ` [PATCH v3 2/2] emacs: quote " Dmitry Kurochkin
2012-02-01 13:51   ` Pieter Praet
2012-02-01 14:18     ` Dmitry Kurochkin
2012-02-01 20:35       ` Pieter Praet
2012-02-01 20:37         ` [PATCH] test: replace occurrences of $PWD with vars that are more stable Pieter Praet
2012-02-01 23:09           ` Dmitry Kurochkin
2012-02-03 10:20             ` Pieter Praet
2012-02-03 10:28               ` Dmitry Kurochkin
2012-02-25 13:54           ` David Bremner
2012-02-02  4:01   ` David Bremner
2012-02-02  4:01     ` [PATCH v4 1/2] test: add tests for quoting of MML tags in replies David Bremner
2012-02-02  4:01     ` [PATCH v4 2/2] emacs: quote " David Bremner
2012-02-03 10:22     ` Pieter Praet
2012-02-03 10:24       ` [PATCH v6 1/3] test: add tests for quoting of MML tags in replies Pieter Praet
2012-02-03 10:24       ` [PATCH v6 2/3] emacs: quote " Pieter Praet
2012-02-03 10:24       ` [PATCH v6 3/3] post-merge fixes Pieter Praet
2012-02-04 19:05         ` David Bremner
2012-02-03 12:54       ` MML Quoting patches David Bremner
2012-02-03 14:28         ` Pieter Praet

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://notmuchmail.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1327817229-18124-1-git-send-email-aaronecay@gmail.com \
    --to=aaronecay@gmail.com \
    --cc=notmuch@notmuchmail.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://yhetil.org/notmuch.git/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).