From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by olra.theworths.org (Postfix) with ESMTP id 7980A431FD2 for ; Tue, 24 Jan 2012 21:27:45 -0800 (PST) X-Virus-Scanned: Debian amavisd-new at olra.theworths.org X-Spam-Flag: NO X-Spam-Score: -0.7 X-Spam-Level: X-Spam-Status: No, score=-0.7 tagged_above=-999 required=5 tests=[RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled Received: from olra.theworths.org ([127.0.0.1]) by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id EPdqheCmEeRn for ; Tue, 24 Jan 2012 21:27:45 -0800 (PST) Received: from mail-ww0-f41.google.com (mail-ww0-f41.google.com [74.125.82.41]) (using TLSv1 with cipher RC4-SHA (128/128 bits)) (No client certificate requested) by olra.theworths.org (Postfix) with ESMTPS id BA32A431FB6 for ; Tue, 24 Jan 2012 21:27:44 -0800 (PST) Received: by wgbdt11 with SMTP id dt11so1055193wgb.2 for ; Tue, 24 Jan 2012 21:27:42 -0800 (PST) MIME-Version: 1.0 Received: by 10.180.95.199 with SMTP id dm7mr25749162wib.9.1327469262062; Tue, 24 Jan 2012 21:27:42 -0800 (PST) Received: from localhost ([109.131.95.182]) by mx.google.com with ESMTPS id hc10sm19102884wib.8.2012.01.24.21.27.40 (version=TLSv1/SSLv3 cipher=OTHER); Tue, 24 Jan 2012 21:27:41 -0800 (PST) From: Pieter Praet To: Notmuch Mail Subject: [PATCH] emacs: make `notmuch-show-open-or-close-all' toggle visibility Date: Wed, 25 Jan 2012 06:25:39 +0100 Message-Id: <1327469139-1968-1-git-send-email-pieter@praet.org> X-Mailer: git-send-email 1.7.8.1 X-Gm-Message-State: ALoCoQmq1RLEmGPcGQcCLsKl07tMMQrVwZg5l3hFVPhPfexcYrgc3FgMhxoYKdPG2YypuYfdJgJs X-BeenThere: notmuch@notmuchmail.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 25 Jan 2012 05:27:45 -0000 * emacs/notmuch-show.el (notmuch-show-open-or-close-all): Rename to `notmuch-show-toggle-all-messages', and make it toggle visibility of all messages based on the visibility of the current message, instead of setting visibility based on whether or not a prefix arg was supplied. Same functionality, less effort (reaching for 'C-u' is a pain)... --- emacs/notmuch-show.el | 22 ++++++++++++---------- 1 files changed, 12 insertions(+), 10 deletions(-) diff --git a/emacs/notmuch-show.el b/emacs/notmuch-show.el index e6a5b31..2d17f74 100644 --- a/emacs/notmuch-show.el +++ b/emacs/notmuch-show.el @@ -1050,8 +1050,8 @@ thread id. If a prefix is given, crypto processing is toggled." (define-key map "p" 'notmuch-show-previous-open-message) (define-key map (kbd "DEL") 'notmuch-show-rewind) (define-key map " " 'notmuch-show-advance-and-archive) - (define-key map (kbd "M-RET") 'notmuch-show-open-or-close-all) (define-key map (kbd "RET") 'notmuch-show-toggle-message) + (define-key map (kbd "M-RET") 'notmuch-show-toggle-all-messages) (define-key map "#" 'notmuch-show-print-message) map) "Keymap for \"notmuch show\" buffers.") @@ -1502,16 +1502,18 @@ the result." (not (plist-get props :message-visible)))) (force-window-update)) -(defun notmuch-show-open-or-close-all () - "Set the visibility all of the messages in the current thread. -By default make all of the messages visible. With a prefix -argument, hide all of the messages." +(defun notmuch-show-toggle-all-messages () + "Toggle the visibility of all messages in the current thread. +If the current message is visible, hide all messages -- and vice versa." (interactive) - (save-excursion - (goto-char (point-min)) - (loop do (notmuch-show-message-visible (notmuch-show-get-message-properties) - (not current-prefix-arg)) - until (not (notmuch-show-goto-message-next)))) + (let ((toggle (notmuch-show-message-visible-p))) + (save-excursion + (goto-char (point-min)) + (loop do (notmuch-show-message-visible + (notmuch-show-get-message-properties) + (not toggle)) + until (not (notmuch-show-goto-message-next))))) + (recenter-top-bottom 1) (force-window-update)) (defun notmuch-show-next-button () -- 1.7.8.1