From: David Edmondson <dme@dme.org>
To: notmuch@notmuchmail.org
Subject: [PATCH 3/3 v2] emacs: Don't insert a part header if it's the first part and text/*.
Date: Mon, 23 Jan 2012 10:33:04 +0000 [thread overview]
Message-ID: <1327314784-22555-3-git-send-email-dme@dme.org> (raw)
In-Reply-To: <1327314784-22555-1-git-send-email-dme@dme.org>
Previously this logic applied only to text/plain. Allow it for other
text/* parts as well.
---
This was not included in version 1 of the patch set.
emacs/notmuch-show.el | 9 ++++-----
1 files changed, 4 insertions(+), 5 deletions(-)
diff --git a/emacs/notmuch-show.el b/emacs/notmuch-show.el
index 39f35ed..55e4e34 100644
--- a/emacs/notmuch-show.el
+++ b/emacs/notmuch-show.el
@@ -300,7 +300,9 @@ CONTENT-TYPE parts."
(defun notmuch-show-insert-part-header (nth content-type declared-type
&optional name comment
&rest button-parameters)
- (unless (notmuch-show-hidden-part-header content-type)
+ (unless (or (notmuch-show-hidden-part-header content-type)
+ (and (= nth 1)
+ (string-match "text/*" content-type)))
(apply #'insert-button
(concat "[ "
(if name (concat name ": ") "")
@@ -561,10 +563,7 @@ current buffer, if possible."
(defun notmuch-show-insert-part-text/plain (msg part content-type nth depth declared-type)
(let ((start (point)))
- ;; If this text/plain part is not the first part in the message,
- ;; insert a header to make this clear.
- (if (> nth 1)
- (notmuch-show-insert-part-header nth declared-type content-type (plist-get part :filename)))
+ (notmuch-show-insert-part-header nth declared-type content-type (plist-get part :filename))
(insert (notmuch-show-get-bodypart-content msg part nth))
(save-excursion
(save-restriction
--
1.7.8.3
next prev parent reply other threads:[~2012-01-23 10:33 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-20 9:43 [PATCH 1/3] emacs: Tidy `notmuch-show-insert-part-header' David Edmondson
2012-01-20 9:43 ` [PATCH 2/3] emacs: Don't return the button from `notmuch-show-insert-part-header' David Edmondson
2012-01-20 20:20 ` Jameson Graef Rollins
2012-01-22 21:38 ` Jameson Graef Rollins
2012-01-23 8:16 ` David Edmondson
2012-01-23 8:52 ` Jameson Graef Rollins
2012-01-23 9:12 ` David Edmondson
2012-01-23 10:33 ` [PATCH 1/3 v2] " David Edmondson
2012-01-23 10:33 ` [PATCH 2/3 v2] emacs: Optionally hide some part headers David Edmondson
2012-01-23 10:33 ` David Edmondson [this message]
2012-01-23 11:32 ` [PATCH 1/3 v2] emacs: Don't return the button from `notmuch-show-insert-part-header' David Edmondson
2012-01-20 9:43 ` [PATCH 3/3] emacs: Optionally hide some part headers David Edmondson
2012-01-24 12:53 ` optional hiding of some part headers v3 David Edmondson
2012-01-24 12:53 ` [PATCH 1/3] emacs: Don't return the button from `notmuch-show-insert-part-header' David Edmondson
2012-01-24 18:46 ` Jameson Graef Rollins
2012-01-24 19:25 ` David Edmondson
2012-01-24 19:52 ` Jameson Graef Rollins
2012-01-25 6:15 ` David Edmondson
2012-01-24 19:33 ` Tomi Ollila
2012-01-24 12:53 ` [PATCH 2/3] emacs: Optionally hide some part headers David Edmondson
2012-01-24 19:34 ` Tomi Ollila
2012-01-24 12:53 ` [PATCH 3/3] emacs: Don't insert a part header if it's the first part and text/* David Edmondson
2012-01-24 19:46 ` Tomi Ollila
2012-02-06 15:39 ` [PATCH v3 0/3] part header code tidying and options David Edmondson
2012-02-06 15:39 ` [PATCH v2] emacs: Add more processing of displayed headers David Edmondson
2012-02-14 12:30 ` David Bremner
2012-02-14 13:28 ` David Edmondson
2012-10-12 19:11 ` Ethan Glasser-Camp
2012-02-06 15:39 ` [PATCH v3 1/3] emacs: Don't return the button from `notmuch-show-insert-part-header' David Edmondson
2012-02-06 15:39 ` [PATCH v3 2/3] emacs: Optionally hide some part headers David Edmondson
2012-02-12 9:21 ` Mark Walters
2012-02-06 15:39 ` [PATCH v3 3/3] emacs: Don't insert a part header if it's the first part and text/* David Edmondson
2012-02-12 9:24 ` Mark Walters
2012-02-12 9:39 ` Mark Walters
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://notmuchmail.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1327314784-22555-3-git-send-email-dme@dme.org \
--to=dme@dme.org \
--cc=notmuch@notmuchmail.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://yhetil.org/notmuch.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).