unofficial mirror of notmuch@notmuchmail.org
 help / color / mirror / code / Atom feed
From: Mark Walters <markwalters1009@gmail.com>
To: notmuch@notmuchmail.org
Subject: [PATCH v4 0/1] 
Date: Thu, 19 Jan 2012 21:23:04 +0000	[thread overview]
Message-ID: <1327008185-21194-1-git-send-email-markwalters1009@gmail.com> (raw)
In-Reply-To: <id:"20120118192147.GF16740@mit.edu">

Here is a new version of the patch incorporating all the review comments. 
I have rebased it on master so, in particular, it fits into the recently
committed customization framework.

To deal with one corner case I decided to go with Austin's suggestion of 
using lexical-let as it is probably more robust to changes in mm-decode.
I would like to thank him for  all his other help improving my original 
patch.

It passes the test-suite and all cases I can think of work correctly.

Best wishes

Mark



Mark Walters (1):
  Make buttons for attachments allow viewing as well as saving

 emacs/notmuch-show.el |  116 ++++++++++++++++++++++++++++++++++++++----------
 1 files changed, 92 insertions(+), 24 deletions(-)

-- 
1.7.2.3

       reply	other threads:[~2012-01-19 21:22 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <id:"20120118192147.GF16740@mit.edu">
2012-01-19 21:23 ` Mark Walters [this message]
2012-01-19 21:48   ` [PATCH v4 0/1] Mark Walters
2012-01-19 21:23 ` [PATCH v4 1/1] Make buttons for attachments allow viewing as well as saving Mark Walters
2012-01-20  4:30   ` Austin Clements
2012-01-20  9:42     ` Mark Walters
2012-01-20  9:44       ` [PATCH v5] " Mark Walters
2012-01-20 16:42         ` Austin Clements
2012-01-21 13:09         ` David Bremner
2012-02-29  9:31           ` [PATCH v5] News for " Mark Walters
2012-02-29 11:27             ` David Bremner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://notmuchmail.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1327008185-21194-1-git-send-email-markwalters1009@gmail.com \
    --to=markwalters1009@gmail.com \
    --cc=notmuch@notmuchmail.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://yhetil.org/notmuch.git/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).