From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by olra.theworths.org (Postfix) with ESMTP id AF94A431FAF for ; Wed, 18 Jan 2012 16:40:18 -0800 (PST) X-Virus-Scanned: Debian amavisd-new at olra.theworths.org X-Spam-Flag: NO X-Spam-Score: -0.7 X-Spam-Level: X-Spam-Status: No, score=-0.7 tagged_above=-999 required=5 tests=[RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled Received: from olra.theworths.org ([127.0.0.1]) by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id xJ1ePPP2Y39a for ; Wed, 18 Jan 2012 16:40:18 -0800 (PST) Received: from dmz-mailsec-scanner-3.mit.edu (DMZ-MAILSEC-SCANNER-3.MIT.EDU [18.9.25.14]) by olra.theworths.org (Postfix) with ESMTP id 144F2431FAE for ; Wed, 18 Jan 2012 16:40:17 -0800 (PST) X-AuditID: 1209190e-b7f7c6d0000008c3-b1-4f1766719e90 Received: from mailhub-auth-3.mit.edu ( [18.9.21.43]) by dmz-mailsec-scanner-3.mit.edu (Symantec Messaging Gateway) with SMTP id 04.6B.02243.176671F4; Wed, 18 Jan 2012 19:40:17 -0500 (EST) Received: from outgoing.mit.edu (OUTGOING-AUTH.MIT.EDU [18.7.22.103]) by mailhub-auth-3.mit.edu (8.13.8/8.9.2) with ESMTP id q0J0eGi5014925 for ; Wed, 18 Jan 2012 19:40:17 -0500 Received: from drake.mit.edu (209-6-116-242.c3-0.arl-ubr1.sbo-arl.ma.cable.rcn.com [209.6.116.242]) (authenticated bits=0) (User authenticated as amdragon@ATHENA.MIT.EDU) by outgoing.mit.edu (8.13.6/8.12.4) with ESMTP id q0J0eEH8016733 (version=TLSv1/SSLv3 cipher=AES256-SHA bits=256 verify=NOT) for ; Wed, 18 Jan 2012 19:40:16 -0500 (EST) Received: from amthrax by drake.mit.edu with local (Exim 4.77) (envelope-from ) id 1Rng34-0004Yj-Mx for notmuch@notmuchmail.org; Wed, 18 Jan 2012 19:40:14 -0500 From: Austin Clements To: notmuch@notmuchmail.org Subject: [PATCH 0/2] Fix or silence "unused result" warnings Date: Wed, 18 Jan 2012 19:40:09 -0500 Message-Id: <1326933611-16898-1-git-send-email-amdragon@mit.edu> X-Mailer: git-send-email 1.7.7.3 X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFprAIsWRmVeSWpSXmKPExsUixCmqrVuYJu5vsOelkMX1mzOZHRg9nq26 xRzAGMVlk5Kak1mWWqRvl8CV8WnfHJaCuawVh6f/Zm5gXMLSxcjJISFgInGnbymULSZx4d56 ti5GLg4hgX2MEmcOdzJBOOcYJV6+a2eGcP4ySZzf/Roqs5dR4nzbY0aQfjYBDYlt+5eD2SIC 0hI7785mBbGFBWwk5lx9xQZiswioSvy7u4gJxOYVcJBYe+IQ1G4FiXOrz7FPYORZwMiwilE2 JbdKNzcxM6c4NVm3ODkxLy+1SNdYLzezRC81pXQTI9jjknw7GL8eVDrEKMDBqMTDGyEi7i/E mlhWXJl7iFGSg0lJlPdRKlCILyk/pTIjsTgjvqg0J7X4EKMEB7OSCO9OE6Acb0piZVVqUT5M SpqDRUmcV03rnZ+QQHpiSWp2ampBahFMVoaDQ0mC1xBkqGBRanpqRVpmTglCmomDE2Q4D9Dw MJAa3uKCxNzizHSI/ClGRSlx3u0gCQGQREZpHlwvLCJfMYoDvSLMGw1SxQOMZrjuV0CDmYAG ezSJgQwuSURISTUwLhdXXR5alP1zWvCVSc9Tps263rJawuDQsxvTpoZuFzss/ch2484tf81j WX645dVe2Nofs6ufcWOsQ4X+O3HVxBcPvHnWbPi782eYNgdjSumCye3pe773LvsvEru8+Kxn 504Buenfdh9i+pi+4hHnM8UF02dFf3A8d2XfDYsnGl+35ybUT1yxd5MSS3FGoqEWc1FxIgDz aqBKowIAAA== X-BeenThere: notmuch@notmuchmail.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 19 Jan 2012 00:40:18 -0000 I'm afraid I bikeshedded dme's original patch for this into oblivion (id:"1324503532-5799-1-git-send-email-dme@dme.org") and we still have these warnings on the buildbot. Tomi convinced me that dme was right and I was wrong, so I'm bringing dme's patch back. The first patch actually fixes the warning, since the code in show was wantonly ignoring errors that could have correctness implications. This write didn't get much attention in the original thread. The second is a rework of dme's patch to silence the warning for the remaining writes. I cleaned up the formatting, simplified the macro magic a little, and added a comment justifying its use.