unofficial mirror of notmuch@notmuchmail.org
 help / color / mirror / code / Atom feed
* [PATCH 1/2] emacs: add invisible dot instead of space at the end of notmuch-hello search box
@ 2012-01-17 13:24 Dmitry Kurochkin
  2012-01-17 13:24 ` [PATCH 2/2] emacs: fix typo in notmuch-hello Dmitry Kurochkin
                   ` (2 more replies)
  0 siblings, 3 replies; 16+ messages in thread
From: Dmitry Kurochkin @ 2012-01-17 13:24 UTC (permalink / raw)
  To: notmuch

This makes `show-trailing-whitespace' happy, i.e. it does not mark the
whole search box line as trailing spaces.

Since the dot is invisible, this change makes no visible difference
for `notmuch-hello'.
---
 emacs/notmuch-hello.el |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/emacs/notmuch-hello.el b/emacs/notmuch-hello.el
index 02017ce..a71f3ce 100644
--- a/emacs/notmuch-hello.el
+++ b/emacs/notmuch-hello.el
@@ -508,9 +508,9 @@ Complete list of currently available key bindings:
 				       (length "Search: ")))
 		       :action (lambda (widget &rest ignore)
 				 (notmuch-hello-search (widget-value widget))))
-	;; add an invisible space to make `widget-end-of-line' ignore
+	;; add an invisible dot to make `widget-end-of-line' ignore
 	;; trailine spaces in the search widget field
-	(widget-insert " ")
+	(widget-insert ".")
 	(put-text-property (1- (point)) (point) 'invisible t)
 	(widget-insert "\n")
 
-- 
1.7.8.3

^ permalink raw reply related	[flat|nested] 16+ messages in thread

* [PATCH 2/2] emacs: fix typo in notmuch-hello
  2012-01-17 13:24 [PATCH 1/2] emacs: add invisible dot instead of space at the end of notmuch-hello search box Dmitry Kurochkin
@ 2012-01-17 13:24 ` Dmitry Kurochkin
  2012-01-17 14:08 ` [PATCH 1/2] emacs: add invisible dot instead of space at the end of notmuch-hello search box David Edmondson
  2012-01-17 15:55 ` [PATCH v2] " Dmitry Kurochkin
  2 siblings, 0 replies; 16+ messages in thread
From: Dmitry Kurochkin @ 2012-01-17 13:24 UTC (permalink / raw)
  To: notmuch

---
 emacs/notmuch-hello.el |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/emacs/notmuch-hello.el b/emacs/notmuch-hello.el
index a71f3ce..aed1fb3 100644
--- a/emacs/notmuch-hello.el
+++ b/emacs/notmuch-hello.el
@@ -509,7 +509,7 @@ Complete list of currently available key bindings:
 		       :action (lambda (widget &rest ignore)
 				 (notmuch-hello-search (widget-value widget))))
 	;; add an invisible dot to make `widget-end-of-line' ignore
-	;; trailine spaces in the search widget field
+	;; trailing spaces in the search widget field
 	(widget-insert ".")
 	(put-text-property (1- (point)) (point) 'invisible t)
 	(widget-insert "\n")
-- 
1.7.8.3

^ permalink raw reply related	[flat|nested] 16+ messages in thread

* Re: [PATCH 1/2] emacs: add invisible dot instead of space at the end of notmuch-hello search box
  2012-01-17 13:24 [PATCH 1/2] emacs: add invisible dot instead of space at the end of notmuch-hello search box Dmitry Kurochkin
  2012-01-17 13:24 ` [PATCH 2/2] emacs: fix typo in notmuch-hello Dmitry Kurochkin
@ 2012-01-17 14:08 ` David Edmondson
  2012-01-17 14:13   ` Dmitry Kurochkin
  2012-01-17 15:55 ` [PATCH v2] " Dmitry Kurochkin
  2 siblings, 1 reply; 16+ messages in thread
From: David Edmondson @ 2012-01-17 14:08 UTC (permalink / raw)
  To: Dmitry Kurochkin, notmuch

[-- Attachment #1: Type: text/plain, Size: 274 bytes --]

On Tue, 17 Jan 2012 17:24:45 +0400, Dmitry Kurochkin <dmitry.kurochkin@gmail.com> wrote:
> This makes `show-trailing-whitespace' happy, i.e. it does not mark the
> whole search box line as trailing spaces.

Why should `whitespace-mode' be active in `notmuch-hello' buffers?

[-- Attachment #2: Type: application/pgp-signature, Size: 197 bytes --]

^ permalink raw reply	[flat|nested] 16+ messages in thread

* Re: [PATCH 1/2] emacs: add invisible dot instead of space at the end of notmuch-hello search box
  2012-01-17 14:08 ` [PATCH 1/2] emacs: add invisible dot instead of space at the end of notmuch-hello search box David Edmondson
@ 2012-01-17 14:13   ` Dmitry Kurochkin
  2012-01-17 14:25     ` David Edmondson
  0 siblings, 1 reply; 16+ messages in thread
From: Dmitry Kurochkin @ 2012-01-17 14:13 UTC (permalink / raw)
  To: David Edmondson, notmuch

On Tue, 17 Jan 2012 14:08:58 +0000, David Edmondson <dme@dme.org> wrote:
> On Tue, 17 Jan 2012 17:24:45 +0400, Dmitry Kurochkin <dmitry.kurochkin@gmail.com> wrote:
> > This makes `show-trailing-whitespace' happy, i.e. it does not mark the
> > whole search box line as trailing spaces.
> 
> Why should `whitespace-mode' be active in `notmuch-hello' buffers?

I do not say that it should be active in notmuch-hello.

For me `show-trailing-whitespace' is activated everywhere with some
exceptions.  Notmuch-hello is one of these exceptions.  This change make
it one step closer to removing the exception.

Regards,
  Dmitry

^ permalink raw reply	[flat|nested] 16+ messages in thread

* Re: [PATCH 1/2] emacs: add invisible dot instead of space at the end of notmuch-hello search box
  2012-01-17 14:13   ` Dmitry Kurochkin
@ 2012-01-17 14:25     ` David Edmondson
  0 siblings, 0 replies; 16+ messages in thread
From: David Edmondson @ 2012-01-17 14:25 UTC (permalink / raw)
  To: Dmitry Kurochkin, notmuch

[-- Attachment #1: Type: text/plain, Size: 814 bytes --]

On Tue, 17 Jan 2012 18:13:26 +0400, Dmitry Kurochkin <dmitry.kurochkin@gmail.com> wrote:
> On Tue, 17 Jan 2012 14:08:58 +0000, David Edmondson <dme@dme.org> wrote:
> > On Tue, 17 Jan 2012 17:24:45 +0400, Dmitry Kurochkin <dmitry.kurochkin@gmail.com> wrote:
> > > This makes `show-trailing-whitespace' happy, i.e. it does not mark the
> > > whole search box line as trailing spaces.
> > 
> > Why should `whitespace-mode' be active in `notmuch-hello' buffers?
> 
> I do not say that it should be active in notmuch-hello.
> 
> For me `show-trailing-whitespace' is activated everywhere with some
> exceptions.  Notmuch-hello is one of these exceptions.  This change make
> it one step closer to removing the exception.

Okay. Please add a comment to explain why it is a . rather than a space,
then +1.

[-- Attachment #2: Type: application/pgp-signature, Size: 197 bytes --]

^ permalink raw reply	[flat|nested] 16+ messages in thread

* [PATCH v2] emacs: add invisible dot instead of space at the end of notmuch-hello search box
  2012-01-17 13:24 [PATCH 1/2] emacs: add invisible dot instead of space at the end of notmuch-hello search box Dmitry Kurochkin
  2012-01-17 13:24 ` [PATCH 2/2] emacs: fix typo in notmuch-hello Dmitry Kurochkin
  2012-01-17 14:08 ` [PATCH 1/2] emacs: add invisible dot instead of space at the end of notmuch-hello search box David Edmondson
@ 2012-01-17 15:55 ` Dmitry Kurochkin
  2012-01-17 16:04   ` David Edmondson
                     ` (3 more replies)
  2 siblings, 4 replies; 16+ messages in thread
From: Dmitry Kurochkin @ 2012-01-17 15:55 UTC (permalink / raw)
  To: notmuch

This makes `show-trailing-whitespace' happy, i.e. it does not mark the
whole search box line as trailing spaces.

Since the dot is invisible, this change makes no visible difference
for `notmuch-hello'.
---
 emacs/notmuch-hello.el |    9 ++++++---
 1 files changed, 6 insertions(+), 3 deletions(-)

diff --git a/emacs/notmuch-hello.el b/emacs/notmuch-hello.el
index 02017ce..38846ef 100644
--- a/emacs/notmuch-hello.el
+++ b/emacs/notmuch-hello.el
@@ -508,9 +508,12 @@ Complete list of currently available key bindings:
 				       (length "Search: ")))
 		       :action (lambda (widget &rest ignore)
 				 (notmuch-hello-search (widget-value widget))))
-	;; add an invisible space to make `widget-end-of-line' ignore
-	;; trailine spaces in the search widget field
-	(widget-insert " ")
+	;; Add an invisible dot to make `widget-end-of-line' ignore
+	;; trailing spaces in the search widget field.  A dot is used
+	;; instead of a space to make `show-trailing-whitespace'
+	;; happy, i.e. avoid it marking the whole line as trailing
+	;; spaces.
+	(widget-insert ".")
 	(put-text-property (1- (point)) (point) 'invisible t)
 	(widget-insert "\n")
 
-- 
1.7.8.3

^ permalink raw reply related	[flat|nested] 16+ messages in thread

* Re: [PATCH v2] emacs: add invisible dot instead of space at the end of notmuch-hello search box
  2012-01-17 15:55 ` [PATCH v2] " Dmitry Kurochkin
@ 2012-01-17 16:04   ` David Edmondson
  2012-01-18 13:49   ` Pieter Praet
                     ` (2 subsequent siblings)
  3 siblings, 0 replies; 16+ messages in thread
From: David Edmondson @ 2012-01-17 16:04 UTC (permalink / raw)
  To: Dmitry Kurochkin, notmuch

[-- Attachment #1: Type: text/plain, Size: 4 bytes --]

+1.

[-- Attachment #2: Type: application/pgp-signature, Size: 197 bytes --]

^ permalink raw reply	[flat|nested] 16+ messages in thread

* Re: [PATCH v2] emacs: add invisible dot instead of space at the end of notmuch-hello search box
  2012-01-17 15:55 ` [PATCH v2] " Dmitry Kurochkin
  2012-01-17 16:04   ` David Edmondson
@ 2012-01-18 13:49   ` Pieter Praet
  2012-01-18 15:02   ` Tomi Ollila
  2012-01-19 21:31   ` [PATCH] emacs: fix tests wrt notmuch-hello invisible dot Pieter Praet
  3 siblings, 0 replies; 16+ messages in thread
From: Pieter Praet @ 2012-01-18 13:49 UTC (permalink / raw)
  To: Dmitry Kurochkin, notmuch

On Tue, 17 Jan 2012 19:55:34 +0400, Dmitry Kurochkin <dmitry.kurochkin@gmail.com> wrote:
> This makes `show-trailing-whitespace' happy, i.e. it does not mark the
> whole search box line as trailing spaces.
> 
> Since the dot is invisible, this change makes no visible difference
> for `notmuch-hello'.
> ---
>  emacs/notmuch-hello.el |    9 ++++++---
>  1 files changed, 6 insertions(+), 3 deletions(-)
> 
> diff --git a/emacs/notmuch-hello.el b/emacs/notmuch-hello.el
> index 02017ce..38846ef 100644
> --- a/emacs/notmuch-hello.el
> +++ b/emacs/notmuch-hello.el
> @@ -508,9 +508,12 @@ Complete list of currently available key bindings:
>  				       (length "Search: ")))
>  		       :action (lambda (widget &rest ignore)
>  				 (notmuch-hello-search (widget-value widget))))
> -	;; add an invisible space to make `widget-end-of-line' ignore
> -	;; trailine spaces in the search widget field
> -	(widget-insert " ")
> +	;; Add an invisible dot to make `widget-end-of-line' ignore
> +	;; trailing spaces in the search widget field.  A dot is used
> +	;; instead of a space to make `show-trailing-whitespace'
> +	;; happy, i.e. avoid it marking the whole line as trailing
> +	;; spaces.
> +	(widget-insert ".")
>  	(put-text-property (1- (point)) (point) 'invisible t)
>  	(widget-insert "\n")
>  
> -- 
> 1.7.8.3
> 
> _______________________________________________
> notmuch mailing list
> notmuch@notmuchmail.org
> http://notmuchmail.org/mailman/listinfo/notmuch

+1


Peace

-- 
Pieter

^ permalink raw reply	[flat|nested] 16+ messages in thread

* Re: [PATCH v2] emacs: add invisible dot instead of space at the end of notmuch-hello search box
  2012-01-17 15:55 ` [PATCH v2] " Dmitry Kurochkin
  2012-01-17 16:04   ` David Edmondson
  2012-01-18 13:49   ` Pieter Praet
@ 2012-01-18 15:02   ` Tomi Ollila
  2012-01-19 21:31   ` [PATCH] emacs: fix tests wrt notmuch-hello invisible dot Pieter Praet
  3 siblings, 0 replies; 16+ messages in thread
From: Tomi Ollila @ 2012-01-18 15:02 UTC (permalink / raw)
  To: Dmitry Kurochkin, notmuch

On Tue, 17 Jan 2012 19:55:34 +0400, Dmitry Kurochkin <dmitry.kurochkin@gmail.com> wrote:
> This makes `show-trailing-whitespace' happy, i.e. it does not mark the
> whole search box line as trailing spaces.
> 
> Since the dot is invisible, this change makes no visible difference
> for `notmuch-hello'.
> ---

+1

^ permalink raw reply	[flat|nested] 16+ messages in thread

* [PATCH] emacs: fix tests wrt notmuch-hello invisible dot
  2012-01-17 15:55 ` [PATCH v2] " Dmitry Kurochkin
                     ` (2 preceding siblings ...)
  2012-01-18 15:02   ` Tomi Ollila
@ 2012-01-19 21:31   ` Pieter Praet
  2012-01-19 22:37     ` Dmitry Kurochkin
  3 siblings, 1 reply; 16+ messages in thread
From: Pieter Praet @ 2012-01-19 21:31 UTC (permalink / raw)
  To: Dmitry Kurochkin; +Cc: Notmuch Mail

Not meant to be applied!

Should be merged into
  id:"1326815734-20421-1-git-send-email-dmitry.kurochkin@gmail.com"

---
 test/emacs.expected-output/notmuch-hello           |    2 +-
 .../notmuch-hello-no-saved-searches                |    2 +-
 .../emacs.expected-output/notmuch-hello-with-empty |    2 +-
 3 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/test/emacs.expected-output/notmuch-hello b/test/emacs.expected-output/notmuch-hello
index de57de2..196112e 100644
--- a/test/emacs.expected-output/notmuch-hello
+++ b/test/emacs.expected-output/notmuch-hello
@@ -4,7 +4,7 @@ Saved searches: [edit]
 
 	  52 inbox           52 unread    
 
-Search:                                                                      
+Search:                                                                     .
 
 [Show all tags]
 
diff --git a/test/emacs.expected-output/notmuch-hello-no-saved-searches b/test/emacs.expected-output/notmuch-hello-no-saved-searches
index f1fc4d6..f4cfe49 100644
--- a/test/emacs.expected-output/notmuch-hello-no-saved-searches
+++ b/test/emacs.expected-output/notmuch-hello-no-saved-searches
@@ -1,6 +1,6 @@
    Welcome to notmuch. You have 52 messages.
 
-Search:                                                                      
+Search:                                                                     .
 
 [Show all tags]
 
diff --git a/test/emacs.expected-output/notmuch-hello-with-empty b/test/emacs.expected-output/notmuch-hello-with-empty
index dd8728b..a860a72 100644
--- a/test/emacs.expected-output/notmuch-hello-with-empty
+++ b/test/emacs.expected-output/notmuch-hello-with-empty
@@ -4,7 +4,7 @@ Saved searches: [edit]
 
 	  52 inbox           52 unread           0 empty     
 
-Search:                                                                      
+Search:                                                                     .
 
 [Show all tags]
 
-- 
1.7.8.1

^ permalink raw reply related	[flat|nested] 16+ messages in thread

* Re: [PATCH] emacs: fix tests wrt notmuch-hello invisible dot
  2012-01-19 21:31   ` [PATCH] emacs: fix tests wrt notmuch-hello invisible dot Pieter Praet
@ 2012-01-19 22:37     ` Dmitry Kurochkin
  2012-01-19 23:50       ` Pieter Praet
  0 siblings, 1 reply; 16+ messages in thread
From: Dmitry Kurochkin @ 2012-01-19 22:37 UTC (permalink / raw)
  To: Pieter Praet, Notmuch Mail

On Thu, 19 Jan 2012 22:31:14 +0100, Pieter Praet <pieter@praet.org> wrote:
> Not meant to be applied!
> 
> Should be merged into
>   id:"1326815734-20421-1-git-send-email-dmitry.kurochkin@gmail.com"
> 

Oops.  I managed to miss the failing tests.  I would send a new patch
version.

Regards,
  Dmitry

> ---
>  test/emacs.expected-output/notmuch-hello           |    2 +-
>  .../notmuch-hello-no-saved-searches                |    2 +-
>  .../emacs.expected-output/notmuch-hello-with-empty |    2 +-
>  3 files changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/test/emacs.expected-output/notmuch-hello b/test/emacs.expected-output/notmuch-hello
> index de57de2..196112e 100644
> --- a/test/emacs.expected-output/notmuch-hello
> +++ b/test/emacs.expected-output/notmuch-hello
> @@ -4,7 +4,7 @@ Saved searches: [edit]
>  
>  	  52 inbox           52 unread    
>  
> -Search:                                                                      
> +Search:                                                                     .
>  
>  [Show all tags]
>  
> diff --git a/test/emacs.expected-output/notmuch-hello-no-saved-searches b/test/emacs.expected-output/notmuch-hello-no-saved-searches
> index f1fc4d6..f4cfe49 100644
> --- a/test/emacs.expected-output/notmuch-hello-no-saved-searches
> +++ b/test/emacs.expected-output/notmuch-hello-no-saved-searches
> @@ -1,6 +1,6 @@
>     Welcome to notmuch. You have 52 messages.
>  
> -Search:                                                                      
> +Search:                                                                     .
>  
>  [Show all tags]
>  
> diff --git a/test/emacs.expected-output/notmuch-hello-with-empty b/test/emacs.expected-output/notmuch-hello-with-empty
> index dd8728b..a860a72 100644
> --- a/test/emacs.expected-output/notmuch-hello-with-empty
> +++ b/test/emacs.expected-output/notmuch-hello-with-empty
> @@ -4,7 +4,7 @@ Saved searches: [edit]
>  
>  	  52 inbox           52 unread           0 empty     
>  
> -Search:                                                                      
> +Search:                                                                     .
>  
>  [Show all tags]
>  
> -- 
> 1.7.8.1
> 

^ permalink raw reply	[flat|nested] 16+ messages in thread

* Re: [PATCH] emacs: fix tests wrt notmuch-hello invisible dot
  2012-01-19 22:37     ` Dmitry Kurochkin
@ 2012-01-19 23:50       ` Pieter Praet
  2012-01-19 23:52         ` [PATCH v3] emacs: add invisible dot instead of space at the end of notmuch-hello search box Pieter Praet
  2012-01-20  6:35         ` [PATCH] emacs: fix tests wrt notmuch-hello invisible dot Dmitry Kurochkin
  0 siblings, 2 replies; 16+ messages in thread
From: Pieter Praet @ 2012-01-19 23:50 UTC (permalink / raw)
  To: Dmitry Kurochkin, Notmuch Mail

On Fri, 20 Jan 2012 02:37:30 +0400, Dmitry Kurochkin <dmitry.kurochkin@gmail.com> wrote:
> On Thu, 19 Jan 2012 22:31:14 +0100, Pieter Praet <pieter@praet.org> wrote:
> > Not meant to be applied!
> > 
> > Should be merged into
> >   id:"1326815734-20421-1-git-send-email-dmitry.kurochkin@gmail.com"
> > 
> 
> Oops.  I managed to miss the failing tests.  I would send a new patch
> version.
> 

Sorry, yeah, that would probably have been a better idea.

Amended patch follows (let's hope `git send-email' does the right thing).


> Regards,
>   Dmitry
> 
> > ---
> >  test/emacs.expected-output/notmuch-hello           |    2 +-
> >  .../notmuch-hello-no-saved-searches                |    2 +-
> >  .../emacs.expected-output/notmuch-hello-with-empty |    2 +-
> >  3 files changed, 3 insertions(+), 3 deletions(-)
> > 
> > diff --git a/test/emacs.expected-output/notmuch-hello b/test/emacs.expected-output/notmuch-hello
> > index de57de2..196112e 100644
> > --- a/test/emacs.expected-output/notmuch-hello
> > +++ b/test/emacs.expected-output/notmuch-hello
> > @@ -4,7 +4,7 @@ Saved searches: [edit]
> >  
> >  	  52 inbox           52 unread    
> >  
> > -Search:                                                                      
> > +Search:                                                                     .
> >  
> >  [Show all tags]
> >  
> > diff --git a/test/emacs.expected-output/notmuch-hello-no-saved-searches b/test/emacs.expected-output/notmuch-hello-no-saved-searches
> > index f1fc4d6..f4cfe49 100644
> > --- a/test/emacs.expected-output/notmuch-hello-no-saved-searches
> > +++ b/test/emacs.expected-output/notmuch-hello-no-saved-searches
> > @@ -1,6 +1,6 @@
> >     Welcome to notmuch. You have 52 messages.
> >  
> > -Search:                                                                      
> > +Search:                                                                     .
> >  
> >  [Show all tags]
> >  
> > diff --git a/test/emacs.expected-output/notmuch-hello-with-empty b/test/emacs.expected-output/notmuch-hello-with-empty
> > index dd8728b..a860a72 100644
> > --- a/test/emacs.expected-output/notmuch-hello-with-empty
> > +++ b/test/emacs.expected-output/notmuch-hello-with-empty
> > @@ -4,7 +4,7 @@ Saved searches: [edit]
> >  
> >  	  52 inbox           52 unread           0 empty     
> >  
> > -Search:                                                                      
> > +Search:                                                                     .
> >  
> >  [Show all tags]
> >  
> > -- 
> > 1.7.8.1
> > 


Peace

-- 
Pieter

^ permalink raw reply	[flat|nested] 16+ messages in thread

* [PATCH v3] emacs: add invisible dot instead of space at the end of notmuch-hello search box
  2012-01-19 23:50       ` Pieter Praet
@ 2012-01-19 23:52         ` Pieter Praet
  2012-01-20 11:08           ` Tomi Ollila
  2012-01-21 13:12           ` David Bremner
  2012-01-20  6:35         ` [PATCH] emacs: fix tests wrt notmuch-hello invisible dot Dmitry Kurochkin
  1 sibling, 2 replies; 16+ messages in thread
From: Pieter Praet @ 2012-01-19 23:52 UTC (permalink / raw)
  To: Dmitry Kurochkin; +Cc: Notmuch Mail

From: Dmitry Kurochkin <dmitry.kurochkin@gmail.com>

This makes `show-trailing-whitespace' happy, i.e. it does not mark the
whole search box line as trailing spaces.

Since the dot is invisible, this change makes no visible difference
for `notmuch-hello'.

Edited-by: Pieter Praet <pieter@praet.org> to fix the tests.
---
 emacs/notmuch-hello.el                             |    9 ++++++---
 test/emacs.expected-output/notmuch-hello           |    2 +-
 .../notmuch-hello-no-saved-searches                |    2 +-
 .../emacs.expected-output/notmuch-hello-with-empty |    2 +-
 4 files changed, 9 insertions(+), 6 deletions(-)

diff --git a/emacs/notmuch-hello.el b/emacs/notmuch-hello.el
index bff95ac..55b7877 100644
--- a/emacs/notmuch-hello.el
+++ b/emacs/notmuch-hello.el
@@ -511,9 +511,12 @@ Complete list of currently available key bindings:
 				       (length "Search: ")))
 		       :action (lambda (widget &rest ignore)
 				 (notmuch-hello-search (widget-value widget))))
-	;; add an invisible space to make `widget-end-of-line' ignore
-	;; trailine spaces in the search widget field
-	(widget-insert " ")
+	;; Add an invisible dot to make `widget-end-of-line' ignore
+	;; trailing spaces in the search widget field.  A dot is used
+	;; instead of a space to make `show-trailing-whitespace'
+	;; happy, i.e. avoid it marking the whole line as trailing
+	;; spaces.
+	(widget-insert ".")
 	(put-text-property (1- (point)) (point) 'invisible t)
 	(widget-insert "\n")
 
diff --git a/test/emacs.expected-output/notmuch-hello b/test/emacs.expected-output/notmuch-hello
index de57de2..196112e 100644
--- a/test/emacs.expected-output/notmuch-hello
+++ b/test/emacs.expected-output/notmuch-hello
@@ -4,7 +4,7 @@ Saved searches: [edit]
 
 	  52 inbox           52 unread    
 
-Search:                                                                      
+Search:                                                                     .
 
 [Show all tags]
 
diff --git a/test/emacs.expected-output/notmuch-hello-no-saved-searches b/test/emacs.expected-output/notmuch-hello-no-saved-searches
index f1fc4d6..f4cfe49 100644
--- a/test/emacs.expected-output/notmuch-hello-no-saved-searches
+++ b/test/emacs.expected-output/notmuch-hello-no-saved-searches
@@ -1,6 +1,6 @@
    Welcome to notmuch. You have 52 messages.
 
-Search:                                                                      
+Search:                                                                     .
 
 [Show all tags]
 
diff --git a/test/emacs.expected-output/notmuch-hello-with-empty b/test/emacs.expected-output/notmuch-hello-with-empty
index dd8728b..a860a72 100644
--- a/test/emacs.expected-output/notmuch-hello-with-empty
+++ b/test/emacs.expected-output/notmuch-hello-with-empty
@@ -4,7 +4,7 @@ Saved searches: [edit]
 
 	  52 inbox           52 unread           0 empty     
 
-Search:                                                                      
+Search:                                                                     .
 
 [Show all tags]
 
-- 
1.7.8.1

^ permalink raw reply related	[flat|nested] 16+ messages in thread

* Re: [PATCH] emacs: fix tests wrt notmuch-hello invisible dot
  2012-01-19 23:50       ` Pieter Praet
  2012-01-19 23:52         ` [PATCH v3] emacs: add invisible dot instead of space at the end of notmuch-hello search box Pieter Praet
@ 2012-01-20  6:35         ` Dmitry Kurochkin
  1 sibling, 0 replies; 16+ messages in thread
From: Dmitry Kurochkin @ 2012-01-20  6:35 UTC (permalink / raw)
  To: Pieter Praet, Notmuch Mail

On Fri, 20 Jan 2012 00:50:49 +0100, Pieter Praet <pieter@praet.org> wrote:
> On Fri, 20 Jan 2012 02:37:30 +0400, Dmitry Kurochkin <dmitry.kurochkin@gmail.com> wrote:
> > On Thu, 19 Jan 2012 22:31:14 +0100, Pieter Praet <pieter@praet.org> wrote:
> > > Not meant to be applied!
> > > 
> > > Should be merged into
> > >   id:"1326815734-20421-1-git-send-email-dmitry.kurochkin@gmail.com"
> > > 
> > 
> > Oops.  I managed to miss the failing tests.  I would send a new patch
> > version.
> > 
> 
> Sorry, yeah, that would probably have been a better idea.
> 
> Amended patch follows (let's hope `git send-email' does the right thing).
> 

Thanks!

Regards,
  Dmitry

> 
> > Regards,
> >   Dmitry
> > 
> > > ---
> > >  test/emacs.expected-output/notmuch-hello           |    2 +-
> > >  .../notmuch-hello-no-saved-searches                |    2 +-
> > >  .../emacs.expected-output/notmuch-hello-with-empty |    2 +-
> > >  3 files changed, 3 insertions(+), 3 deletions(-)
> > > 
> > > diff --git a/test/emacs.expected-output/notmuch-hello b/test/emacs.expected-output/notmuch-hello
> > > index de57de2..196112e 100644
> > > --- a/test/emacs.expected-output/notmuch-hello
> > > +++ b/test/emacs.expected-output/notmuch-hello
> > > @@ -4,7 +4,7 @@ Saved searches: [edit]
> > >  
> > >  	  52 inbox           52 unread    
> > >  
> > > -Search:                                                                      
> > > +Search:                                                                     .
> > >  
> > >  [Show all tags]
> > >  
> > > diff --git a/test/emacs.expected-output/notmuch-hello-no-saved-searches b/test/emacs.expected-output/notmuch-hello-no-saved-searches
> > > index f1fc4d6..f4cfe49 100644
> > > --- a/test/emacs.expected-output/notmuch-hello-no-saved-searches
> > > +++ b/test/emacs.expected-output/notmuch-hello-no-saved-searches
> > > @@ -1,6 +1,6 @@
> > >     Welcome to notmuch. You have 52 messages.
> > >  
> > > -Search:                                                                      
> > > +Search:                                                                     .
> > >  
> > >  [Show all tags]
> > >  
> > > diff --git a/test/emacs.expected-output/notmuch-hello-with-empty b/test/emacs.expected-output/notmuch-hello-with-empty
> > > index dd8728b..a860a72 100644
> > > --- a/test/emacs.expected-output/notmuch-hello-with-empty
> > > +++ b/test/emacs.expected-output/notmuch-hello-with-empty
> > > @@ -4,7 +4,7 @@ Saved searches: [edit]
> > >  
> > >  	  52 inbox           52 unread           0 empty     
> > >  
> > > -Search:                                                                      
> > > +Search:                                                                     .
> > >  
> > >  [Show all tags]
> > >  
> > > -- 
> > > 1.7.8.1
> > > 
> 
> 
> Peace
> 
> -- 
> Pieter

^ permalink raw reply	[flat|nested] 16+ messages in thread

* Re: [PATCH v3] emacs: add invisible dot instead of space at the end of notmuch-hello search box
  2012-01-19 23:52         ` [PATCH v3] emacs: add invisible dot instead of space at the end of notmuch-hello search box Pieter Praet
@ 2012-01-20 11:08           ` Tomi Ollila
  2012-01-21 13:12           ` David Bremner
  1 sibling, 0 replies; 16+ messages in thread
From: Tomi Ollila @ 2012-01-20 11:08 UTC (permalink / raw)
  To: Pieter Praet, notmuch

On Fri, 20 Jan 2012 00:52:14 +0100, Pieter Praet <pieter@praet.org> wrote:
> From: Dmitry Kurochkin <dmitry.kurochkin@gmail.com>
> 
> This makes `show-trailing-whitespace' happy, i.e. it does not mark the
> whole search box line as trailing spaces.
> 
> Since the dot is invisible, this change makes no visible difference
> for `notmuch-hello'.
> 
> Edited-by: Pieter Praet <pieter@praet.org> to fix the tests.
> ---

+1

Tomi

^ permalink raw reply	[flat|nested] 16+ messages in thread

* Re: [PATCH v3] emacs: add invisible dot instead of space at the end of notmuch-hello search box
  2012-01-19 23:52         ` [PATCH v3] emacs: add invisible dot instead of space at the end of notmuch-hello search box Pieter Praet
  2012-01-20 11:08           ` Tomi Ollila
@ 2012-01-21 13:12           ` David Bremner
  1 sibling, 0 replies; 16+ messages in thread
From: David Bremner @ 2012-01-21 13:12 UTC (permalink / raw)
  To: Pieter Praet, Dmitry Kurochkin; +Cc: Notmuch Mail

On Fri, 20 Jan 2012 00:52:14 +0100, Pieter Praet <pieter@praet.org> wrote:
> From: Dmitry Kurochkin <dmitry.kurochkin@gmail.com>
> 
> This makes `show-trailing-whitespace' happy, i.e. it does not mark the
> whole search box line as trailing spaces.

Pushed

d

^ permalink raw reply	[flat|nested] 16+ messages in thread

end of thread, other threads:[~2012-01-21 13:12 UTC | newest]

Thread overview: 16+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-01-17 13:24 [PATCH 1/2] emacs: add invisible dot instead of space at the end of notmuch-hello search box Dmitry Kurochkin
2012-01-17 13:24 ` [PATCH 2/2] emacs: fix typo in notmuch-hello Dmitry Kurochkin
2012-01-17 14:08 ` [PATCH 1/2] emacs: add invisible dot instead of space at the end of notmuch-hello search box David Edmondson
2012-01-17 14:13   ` Dmitry Kurochkin
2012-01-17 14:25     ` David Edmondson
2012-01-17 15:55 ` [PATCH v2] " Dmitry Kurochkin
2012-01-17 16:04   ` David Edmondson
2012-01-18 13:49   ` Pieter Praet
2012-01-18 15:02   ` Tomi Ollila
2012-01-19 21:31   ` [PATCH] emacs: fix tests wrt notmuch-hello invisible dot Pieter Praet
2012-01-19 22:37     ` Dmitry Kurochkin
2012-01-19 23:50       ` Pieter Praet
2012-01-19 23:52         ` [PATCH v3] emacs: add invisible dot instead of space at the end of notmuch-hello search box Pieter Praet
2012-01-20 11:08           ` Tomi Ollila
2012-01-21 13:12           ` David Bremner
2012-01-20  6:35         ` [PATCH] emacs: fix tests wrt notmuch-hello invisible dot Dmitry Kurochkin

Code repositories for project(s) associated with this public inbox

	https://yhetil.org/notmuch.git/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).