From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by olra.theworths.org (Postfix) with ESMTP id 6A5BB431FD0 for ; Fri, 30 Dec 2011 13:58:45 -0800 (PST) X-Virus-Scanned: Debian amavisd-new at olra.theworths.org X-Spam-Flag: NO X-Spam-Score: -0.799 X-Spam-Level: X-Spam-Status: No, score=-0.799 tagged_above=-999 required=5 tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled Received: from olra.theworths.org ([127.0.0.1]) by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id yZKvLLIKZuwL for ; Fri, 30 Dec 2011 13:58:44 -0800 (PST) Received: from mail-qy0-f181.google.com (mail-qy0-f181.google.com [209.85.216.181]) (using TLSv1 with cipher RC4-SHA (128/128 bits)) (No client certificate requested) by olra.theworths.org (Postfix) with ESMTPS id 81D4F431FB6 for ; Fri, 30 Dec 2011 13:58:44 -0800 (PST) Received: by qcha6 with SMTP id a6so10990719qch.26 for ; Fri, 30 Dec 2011 13:58:43 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=from:to:cc:subject:date:message-id:x-mailer:in-reply-to:references; bh=lauABo9r4FwiAtE0C1cxn4KP7g1IqOPGWBSLsaZ7+4Q=; b=FciZ7qpSVbnDFNURDu8pcaPhw7DtrUnObTk1msm+JN4U2GUWauSPc6hcZXlpBNj64T xJPgFoXkxo3LcmZclkQlx4AzQO/B8An1TFCVmg+ADv6pZrtHyjP/t7cFKEL2axRWcgDN +efTTfs/9PKdFLSrLUzjbw+dPdQIEny0XVfEA= Received: by 10.229.75.144 with SMTP id y16mr15035739qcj.87.1325282323835; Fri, 30 Dec 2011 13:58:43 -0800 (PST) Received: from localhost.localdomain (201-1-35-143.dsl.telesp.net.br. [201.1.35.143]) by mx.google.com with ESMTPS id z1sm74916346qao.1.2011.12.30.13.58.41 (version=TLSv1/SSLv3 cipher=OTHER); Fri, 30 Dec 2011 13:58:43 -0800 (PST) From: Kazuo Teramoto To: notmuch@notmuchmail.org, David Bremner Subject: [PATCH 0/2] Multiples calls of g_mime_init Date: Fri, 30 Dec 2011 19:58:08 -0200 Message-Id: <1325282290-29565-1-git-send-email-kaz.rag@gmail.com> X-Mailer: git-send-email 1.7.8.1 In-Reply-To: <877h1e6r9d.fsf@zancas.localnet> References: <877h1e6r9d.fsf@zancas.localnet> X-BeenThere: notmuch@notmuchmail.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 30 Dec 2011 21:58:45 -0000 The gmime docs don't says if is ok to call g_mime_init multiple times, but the code have a check for it in a form like this: ~~~~~~~~ static unsigned int initialized = 0; g_mime_init (guint32 flags) { if (initialized++) return; ~~~~~~~~ so the init code is run only once and notmuch don't need to explicit check for an already initialized gmime. This make possible to call g_mime_init again in lib/database.cc and this call really solve the OP segmentation fault in python bindings. Kazuo Teramoto (2): lib: Remove unnecessary checks when calling g_mime_init lib: call g_mime_init from notmuch_database_open lib/database.cc | 5 +++++ lib/index.cc | 4 ---- lib/message-file.c | 4 ---- 3 files changed, 5 insertions(+), 8 deletions(-) -- 1.7.8.1