From: Austin Clements <amdragon@MIT.EDU>
To: notmuch@notmuchmail.org
Subject: [PATCH v4 1/4] show: Pass notmuch_message_t instead of path to show_message_body.
Date: Fri, 23 Dec 2011 22:45:45 -0500 [thread overview]
Message-ID: <1324698348-27620-2-git-send-email-amdragon@mit.edu> (raw)
In-Reply-To: <1324698348-27620-1-git-send-email-amdragon@mit.edu>
In addition to simplifying the code, we'll need the notmuch_message_t*
in show_message_body shortly.
---
notmuch-client.h | 2 +-
notmuch-reply.c | 3 +--
notmuch-show.c | 3 +--
show-message.c | 3 ++-
4 files changed, 5 insertions(+), 6 deletions(-)
diff --git a/notmuch-client.h b/notmuch-client.h
index c602e2e..c521efa 100644
--- a/notmuch-client.h
+++ b/notmuch-client.h
@@ -162,7 +162,7 @@ char *
query_string_from_args (void *ctx, int argc, char *argv[]);
notmuch_status_t
-show_message_body (const char *filename,
+show_message_body (notmuch_message_t *message,
const notmuch_show_format_t *format,
notmuch_show_params_t *params);
diff --git a/notmuch-reply.c b/notmuch-reply.c
index 7ac879f..f8d5f64 100644
--- a/notmuch-reply.c
+++ b/notmuch-reply.c
@@ -546,8 +546,7 @@ notmuch_reply_format_default(void *ctx,
notmuch_message_get_header (message, "date"),
notmuch_message_get_header (message, "from"));
- show_message_body (notmuch_message_get_filename (message),
- format, params);
+ show_message_body (message, format, params);
notmuch_message_destroy (message);
}
diff --git a/notmuch-show.c b/notmuch-show.c
index 19fb49f..0200b9c 100644
--- a/notmuch-show.c
+++ b/notmuch-show.c
@@ -758,8 +758,7 @@ show_message (void *ctx,
}
if (format->part_content)
- show_message_body (notmuch_message_get_filename (message),
- format, params);
+ show_message_body (message, format, params);
if (params->part <= 0) {
fputs (format->body_end, stdout);
diff --git a/show-message.c b/show-message.c
index d83f04e..09fa607 100644
--- a/show-message.c
+++ b/show-message.c
@@ -175,7 +175,7 @@ show_message_part (GMimeObject *part,
}
notmuch_status_t
-show_message_body (const char *filename,
+show_message_body (notmuch_message_t *message,
const notmuch_show_format_t *format,
notmuch_show_params_t *params)
{
@@ -183,6 +183,7 @@ show_message_body (const char *filename,
GMimeParser *parser = NULL;
GMimeMessage *mime_message = NULL;
notmuch_status_t ret = NOTMUCH_STATUS_SUCCESS;
+ const char *filename = notmuch_message_get_filename (message);
FILE *file = NULL;
show_message_state_t state;
--
1.7.7.3
next prev parent reply other threads:[~2011-12-24 3:45 UTC|newest]
Thread overview: 57+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-28 2:21 [PATCH 0/4] First step of 'show' rewrite Austin Clements
2011-11-28 2:21 ` [PATCH 1/4] show: Pass notmuch_message_t instead of path to show_message_body Austin Clements
2011-11-28 2:21 ` [PATCH 2/4] Introduce a generic tree-like abstraction for MIME traversal Austin Clements
2011-11-29 19:11 ` Jani Nikula
2011-12-04 19:26 ` Austin Clements
2011-11-28 2:21 ` [PATCH 3/4] Utility function to seek in MIME trees in depth-first order Austin Clements
2011-11-28 2:21 ` [PATCH 4/4] show: Rewrite show_message_body to use the MIME tree interface Austin Clements
2011-11-28 19:44 ` Jani Nikula
2011-11-29 14:37 ` [PATCH 0/4] First step of 'show' rewrite Jameson Graef Rollins
2011-12-04 19:31 ` [PATCH v2 " Austin Clements
2011-12-04 19:31 ` [PATCH 1/4] show: Pass notmuch_message_t instead of path to show_message_body Austin Clements
2011-12-09 19:05 ` Dmitry Kurochkin
2011-12-09 19:54 ` Austin Clements
2011-12-09 19:59 ` Dmitry Kurochkin
2011-12-04 19:31 ` [PATCH 2/4] Introduce a generic tree-like abstraction for MIME traversal Austin Clements
2011-12-04 19:31 ` [PATCH 3/4] Utility function to seek in MIME trees in depth-first order Austin Clements
2011-12-04 19:31 ` [PATCH 4/4] show: Rewrite show_message_body to use the MIME tree interface Austin Clements
2011-12-09 17:39 ` [PATCH v2 0/4] First step of 'show' rewrite Austin Clements
2011-12-09 17:40 ` Dmitry Kurochkin
2011-12-09 17:51 ` Jameson Graef Rollins
2011-12-09 19:54 ` [PATCH v3 " Austin Clements
2011-12-09 19:54 ` [PATCH 1/4] show: Pass notmuch_message_t instead of path to show_message_body Austin Clements
2011-12-09 19:54 ` [PATCH 2/4] Introduce a generic tree-like abstraction for MIME traversal Austin Clements
2011-12-09 23:25 ` Dmitry Kurochkin
2011-12-10 21:17 ` Jameson Graef Rollins
2011-12-24 3:45 ` Austin Clements
2011-12-24 3:45 ` Austin Clements
2011-12-27 14:27 ` Daniel Kahn Gillmor
2011-12-28 3:23 ` Austin Clements
2011-12-10 21:19 ` Jameson Graef Rollins
2011-12-09 19:54 ` [PATCH 3/4] Utility function to seek in MIME trees in depth-first order Austin Clements
2011-12-10 11:43 ` Dmitry Kurochkin
2011-12-24 3:46 ` Austin Clements
2011-12-25 23:39 ` Dmitry Kurochkin
2011-12-09 19:54 ` [PATCH 4/4] show: Rewrite show_message_body to use the MIME tree interface Austin Clements
2011-12-11 10:34 ` Dmitry Kurochkin
2011-12-24 3:46 ` Austin Clements
2011-12-10 21:16 ` [PATCH v3 0/4] First step of 'show' rewrite Jameson Graef Rollins
2011-12-11 10:41 ` Dmitry Kurochkin
2011-12-15 11:03 ` David Bremner
2011-12-24 3:45 ` [PATCH v4 " Austin Clements
2011-12-24 3:45 ` Austin Clements [this message]
2011-12-24 3:45 ` [PATCH v4 2/4] Introduce a generic tree-like abstraction for MIME traversal Austin Clements
2011-12-24 7:55 ` Jameson Graef Rollins
2011-12-24 8:05 ` Dmitry Kurochkin
2011-12-24 19:03 ` Austin Clements
2011-12-24 3:45 ` [PATCH v4 3/4] Utility function to seek in MIME trees in depth-first order Austin Clements
2011-12-24 3:45 ` [PATCH v4 4/4] show: Rewrite show_message_body to use the MIME tree interface Austin Clements
2011-12-24 3:58 ` [PATCH v4 0/4] First step of 'show' rewrite Dmitry Kurochkin
2011-12-24 7:55 ` Jameson Graef Rollins
2011-12-24 18:52 ` [PATCH v5 " Austin Clements
2011-12-24 18:52 ` [PATCH v5 1/4] show: Pass notmuch_message_t instead of path to show_message_body Austin Clements
2011-12-24 18:52 ` [PATCH v5 2/4] Introduce a generic tree-like abstraction for MIME traversal Austin Clements
2011-12-24 18:52 ` [PATCH v5 3/4] Utility function to seek in MIME trees in depth-first order Austin Clements
2011-12-24 18:52 ` [PATCH v5 4/4] show: Rewrite show_message_body to use the MIME tree interface Austin Clements
2011-12-25 23:35 ` [PATCH v5 0/4] First step of 'show' rewrite Dmitry Kurochkin
2011-12-26 2:42 ` David Bremner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://notmuchmail.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1324698348-27620-2-git-send-email-amdragon@mit.edu \
--to=amdragon@mit.edu \
--cc=notmuch@notmuchmail.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://yhetil.org/notmuch.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).