From: David Edmondson <dme@dme.org>
To: notmuch@notmuchmail.org
Subject: [RFC][PATCH] notmuch: Workaround to allow ignoring non-void function return.
Date: Wed, 21 Dec 2011 21:38:52 +0000 [thread overview]
Message-ID: <1324503532-5799-1-git-send-email-dme@dme.org> (raw)
---
The mechanism used here works for me in an isolated test case and no
warnings appear when using it as below, but I'm unsure why the
original warning that it is intended to address didn't appear when I
build. Any thoughts?
compat/compat.h | 6 ++++++
notmuch-new.c | 2 +-
notmuch-show.c | 2 +-
notmuch-tag.c | 2 +-
4 files changed, 9 insertions(+), 3 deletions(-)
diff --git a/compat/compat.h b/compat/compat.h
index 7767fe8..1160301 100644
--- a/compat/compat.h
+++ b/compat/compat.h
@@ -30,6 +30,12 @@
extern "C" {
#endif
+#ifdef __GNUC__
+#define ignore_result(x) ({ __typeof__(x) z = x; (void) sizeof (z); })
+#else /* !__GNUC__ */
+#define ignore_result(x) x
+#endif /* __GNUC__ */
+
#if !HAVE_GETLINE
#include <stdio.h>
#include <unistd.h>
diff --git a/notmuch-new.c b/notmuch-new.c
index 3512de7..0ac04cc 100644
--- a/notmuch-new.c
+++ b/notmuch-new.c
@@ -67,7 +67,7 @@ handle_sigint (unused (int sig))
{
static char msg[] = "Stopping... \n";
- (void) write(2, msg, sizeof(msg)-1);
+ ignore_result(write(STDERR_FILENO, msg, sizeof(msg)-1));
interrupted = 1;
}
diff --git a/notmuch-show.c b/notmuch-show.c
index 19fb49f..681f778 100644
--- a/notmuch-show.c
+++ b/notmuch-show.c
@@ -866,7 +866,7 @@ do_show_single (void *ctx,
while (!feof (file)) {
size = fread (buf, 1, sizeof (buf), file);
- (void) fwrite (buf, size, 1, stdout);
+ ignore_result(fwrite (buf, size, 1, stdout));
}
fclose (file);
diff --git a/notmuch-tag.c b/notmuch-tag.c
index 292c5da..2cbfdc3 100644
--- a/notmuch-tag.c
+++ b/notmuch-tag.c
@@ -26,7 +26,7 @@ static void
handle_sigint (unused (int sig))
{
static char msg[] = "Stopping... \n";
- (void) write(2, msg, sizeof(msg)-1);
+ ignore_result(write(STDERR_FILENO, msg, sizeof(msg)-1));
interrupted = 1;
}
--
1.7.7.3
next reply other threads:[~2011-12-21 21:39 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-21 21:38 David Edmondson [this message]
2011-12-22 7:03 ` [RFC][PATCH] notmuch: Workaround to allow ignoring non-void function return Austin Clements
2011-12-22 7:21 ` David Edmondson
2011-12-22 19:03 ` Austin Clements
2011-12-22 19:25 ` David Edmondson
2011-12-22 20:04 ` David Edmondson
2011-12-22 20:15 ` Austin Clements
2011-12-22 20:15 ` [PATCH] Properly handle short writes in sigint handlers Austin Clements
2011-12-23 8:10 ` David Edmondson
2011-12-23 12:30 ` Tomi Ollila
2011-12-25 0:38 ` Austin Clements
2011-12-25 0:38 ` Austin Clements
2011-12-23 19:10 ` Dmitry Kurochkin
2012-01-10 11:13 ` David Bremner
2012-01-11 13:04 ` Tomi Ollila
2011-12-22 9:32 ` [RFC][PATCH] notmuch: Workaround to allow ignoring non-void function return Dmitry Kurochkin
2011-12-22 11:24 ` David Edmondson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://notmuchmail.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1324503532-5799-1-git-send-email-dme@dme.org \
--to=dme@dme.org \
--cc=notmuch@notmuchmail.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://yhetil.org/notmuch.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).