From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by olra.theworths.org (Postfix) with ESMTP id 3140C431FD0 for ; Sat, 17 Dec 2011 07:36:32 -0800 (PST) X-Virus-Scanned: Debian amavisd-new at olra.theworths.org X-Spam-Flag: NO X-Spam-Score: -0.799 X-Spam-Level: X-Spam-Status: No, score=-0.799 tagged_above=-999 required=5 tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled Received: from olra.theworths.org ([127.0.0.1]) by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 4Vbiqvk6FWIS for ; Sat, 17 Dec 2011 07:36:31 -0800 (PST) Received: from mail-qw0-f53.google.com (mail-qw0-f53.google.com [209.85.216.53]) (using TLSv1 with cipher RC4-SHA (128/128 bits)) (No client certificate requested) by olra.theworths.org (Postfix) with ESMTPS id C635A431FB6 for ; Sat, 17 Dec 2011 07:36:31 -0800 (PST) Received: by qadb15 with SMTP id b15so3033899qad.5 for ; Sat, 17 Dec 2011 07:36:31 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=from:to:subject:date:message-id:x-mailer; bh=Av5hVVEBxjDIqVidRKNudpugZadQc9GcZ8usFaYAl+s=; b=iD2j+kA6WOFxUtvyiylyxZHZJAviuMz88OqAg60GXj/jbIiAgRzzgScmZnWSCdDiFC l6TLQccHSkPWfI89dSnniVcihb64Jw+6s9fix2UvFqBLeqv2vwPMeiUeGDgfaQbACz7S bUmKZ9c4BpJfCD0WhIOLPZlR0XhgFyZSM9dKc= Received: by 10.224.200.197 with SMTP id ex5mr17039147qab.88.1324136191188; Sat, 17 Dec 2011 07:36:31 -0800 (PST) Received: from localhost.localdomain (c-68-80-94-73.hsd1.pa.comcast.net. [68.80.94.73]) by mx.google.com with ESMTPS id eb5sm26946945qab.10.2011.12.17.07.36.30 (version=TLSv1/SSLv3 cipher=OTHER); Sat, 17 Dec 2011 07:36:30 -0800 (PST) From: Aaron Ecay To: notmuch@notmuchmail.org Subject: [PATCH] Give a path name to mktemp in Makefile.local Date: Sat, 17 Dec 2011 10:36:25 -0500 Message-Id: <1324136185-4509-1-git-send-email-aaronecay@gmail.com> X-Mailer: git-send-email 1.7.8 X-BeenThere: notmuch@notmuchmail.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 17 Dec 2011 15:36:32 -0000 On some systems (incl. OS X 10.6), mktemp expects an argument giving it the place to put the new temporary file. --- On my machine without this patch, make prints a message from mktemp about expecting an argument each time it is run. At some point, make got into a situation where it would print this message and exit cleanly, but not build any changed files. A "make clean" was necessary to kick it into working again. A disadvantage of this approach is that it drops an empty file into /tmp on every make run. It would be better to only create this file when doing "make debian-snapshot", but I am not sure how to do that (cleanly; my best idea is to put the build commands into a subshell and export an environment variable for the temp file). Any make/debian experts want to take a stab? Makefile.local | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/Makefile.local b/Makefile.local index c94402b..6eb4b18 100644 --- a/Makefile.local +++ b/Makefile.local @@ -139,7 +139,7 @@ pre-release: mv $(TAR_FILE) $(DEB_TAR_FILE) releases .PHONY: debian-snapshot -debian-snapshot: TMPFILE := $(shell mktemp) +debian-snapshot: TMPFILE := $(shell mktemp /tmp/notmuch.XXXXXX) debian-snapshot: make VERSION=$(VERSION) clean cp debian/changelog $(TMPFILE) -- 1.7.8