unofficial mirror of notmuch@notmuchmail.org
 help / color / mirror / code / Atom feed
From: Jani Nikula <jani@nikula.org>
To: notmuch@notmuchmail.org
Subject: [PATCH v3] emacs: support "notmuch new" as a notmuch-poll-script
Date: Mon, 12 Dec 2011 22:50:04 +0200	[thread overview]
Message-ID: <1323723004-32605-1-git-send-email-jani@nikula.org> (raw)
In-Reply-To: <1323640100-18326-1-git-send-email-jani@nikula.org>

Support nil value for notmuch-poll-script to run "notmuch new" instead of
an external script, and make this the new default. "notmuch new" is run
using the configured notmuch-command.

This allows taking better advantage of the "notmuch new" hooks from emacs
without intermediate scripts.

Signed-off-by: Jani Nikula <jani@nikula.org>

---

v3: only documentation changes suggested by Austin and Dmitry.
---
 emacs/notmuch.el |   35 +++++++++++++++++++++++++----------
 1 files changed, 25 insertions(+), 10 deletions(-)

diff --git a/emacs/notmuch.el b/emacs/notmuch.el
index 8936149..675a110 100644
--- a/emacs/notmuch.el
+++ b/emacs/notmuch.el
@@ -965,28 +965,43 @@ same relative position within the new buffer."
     (notmuch-search query oldest-first target-thread target-line continuation)
     (goto-char (point-min))))
 
-(defcustom notmuch-poll-script ""
+(defcustom notmuch-poll-script nil
   "An external script to incorporate new mail into the notmuch database.
 
-If this variable is non empty, then it should name a script to be
-invoked by `notmuch-search-poll-and-refresh-view' and
+This variable controls the action invoked by
+`notmuch-search-poll-and-refresh-view' and
 `notmuch-hello-poll-and-update' (each have a default keybinding
-of 'G'). The script could do any of the following depending on
+of 'G') to incorporate new mail into the notmuch database.
+
+If set to nil (the default), new mail is processed by invoking
+\"notmuch new\". Otherwise, this should be set to a string that
+gives the name of an external script that processes new mail. If
+set to the empty string, no command will be run.
+
+The external script could do any of the following depending on
 the user's needs:
 
 1. Invoke a program to transfer mail to the local mail store
 2. Invoke \"notmuch new\" to incorporate the new mail
-3. Invoke one or more \"notmuch tag\" commands to classify the mail"
-  :type 'string
+3. Invoke one or more \"notmuch tag\" commands to classify the mail
+
+Note that the recommended way of achieving the same is using
+\"notmuch new\" hooks."
+  :type '(choice (const :tag "notmuch new" nil)
+		 (const :tag "Disabled" "")
+		 (string :tag "Custom script"))
   :group 'notmuch)
 
 (defun notmuch-poll ()
-  "Run external script to import mail.
+  "Run \"notmuch new\" or an external script to import mail.
 
-Invokes `notmuch-poll-script' if it is not set to an empty string."
+Invokes `notmuch-poll-script', \"notmuch new\", or does nothing
+depending on the value of `notmuch-poll-script'."
   (interactive)
-  (if (not (string= notmuch-poll-script ""))
-      (call-process notmuch-poll-script nil nil)))
+  (if (stringp notmuch-poll-script)
+      (if (not (string= notmuch-poll-script ""))
+	  (call-process notmuch-poll-script nil nil))
+    (call-process notmuch-command nil nil nil "new")))
 
 (defun notmuch-search-poll-and-refresh-view ()
   "Invoke `notmuch-poll' to import mail, then refresh the current view."
-- 
1.7.5.4

  parent reply	other threads:[~2011-12-12 20:50 UTC|newest]

Thread overview: 54+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-12-11 21:48 [PATCH] emacs: support "notmuch new" as a notmuch-poll-script Jani Nikula
2011-12-11 22:00 ` Dmitry Kurochkin
2011-12-11 22:19   ` Jani Nikula
2011-12-11 22:39     ` Dmitry Kurochkin
2011-12-11 22:58   ` Austin Clements
2011-12-11 23:10     ` Jani Nikula
2011-12-12  0:31       ` Austin Clements
2011-12-12  0:39         ` Dmitry Kurochkin
2011-12-12 10:15         ` Tomi Ollila
2011-12-12 10:21           ` Dmitry Kurochkin
2011-12-12 11:38             ` Tomi Ollila
2011-12-12 15:42             ` Austin Clements
2011-12-12 19:57 ` [PATCH v2] " Jani Nikula
2011-12-12 20:12   ` Dmitry Kurochkin
2011-12-12 20:24   ` Austin Clements
2011-12-12 20:50 ` Jani Nikula [this message]
2011-12-12 20:53   ` [PATCH v3] " Dmitry Kurochkin
2011-12-12 21:13     ` Jani Nikula
2011-12-12 21:24       ` Austin Clements
2011-12-12 21:34         ` Dmitry Kurochkin
2011-12-12 21:01   ` Austin Clements
2011-12-15  4:24   ` David Bremner
2012-01-12 17:31   ` Pieter Praet
2012-01-12 17:33     ` [PATCH] emacs: globally replace non-branching "(if (not ..." with "(unless ..." Pieter Praet
2012-01-12 17:40       ` Dmitry Kurochkin
2012-01-12 22:10       ` Xavier Maillard
2012-01-13  8:23       ` David Edmondson
2012-01-13 12:42         ` Xavier Maillard
2012-01-13 12:37           ` Tomi Ollila
2012-01-13 13:01           ` David Edmondson
2012-01-14  9:14         ` Pieter Praet
2012-01-14  9:17           ` [PATCH] emacs: globally replace non-branching "(if COND (progn ..." with "(when ..." Pieter Praet
2012-01-28 12:41             ` David Bremner
2012-01-28 12:55               ` Jani Nikula
2012-01-28 17:14                 ` David Bremner
2012-01-30  9:23                   ` David Edmondson
2012-02-01 13:46                     ` Pieter Praet
2012-02-01 14:21                       ` Dmitry Kurochkin
2012-01-30  7:03               ` Pieter Praet
2012-01-30  7:59                 ` Tomi Ollila
2012-02-01 13:46                   ` Pieter Praet
2012-01-31  3:34             ` David Bremner
2012-02-01 13:47               ` Pieter Praet
2012-02-01 13:50                 ` [PATCH v2] " Pieter Praet
2012-02-01 14:05                   ` David Edmondson
2012-02-02  1:31                   ` David Bremner
2012-01-14  9:52           ` [PATCH] emacs: globally replace non-branching "(if (not ..." with "(unless ..." Pieter Praet
2012-01-13 16:06       ` David Edmondson
2012-01-14  9:18         ` Pieter Praet
2012-01-15 11:55           ` David Edmondson
2012-01-16 10:56             ` [PATCH v2] " Pieter Praet
2012-01-16 11:06               ` David Edmondson
2012-01-16 12:39               ` Tomi Ollila
2012-01-21 12:21               ` David Bremner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://notmuchmail.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1323723004-32605-1-git-send-email-jani@nikula.org \
    --to=jani@nikula.org \
    --cc=notmuch@notmuchmail.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://yhetil.org/notmuch.git/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).