unofficial mirror of notmuch@notmuchmail.org
 help / color / mirror / code / Atom feed
From: David Bremner <bremner@debian.org>
To: notmuch@notmuchmail.org
Cc: David Bremner <bremner@debian.org>
Subject: [PATCH 2/2] test/symbol-hiding: compare exported symbols with existing one
Date: Mon, 28 Nov 2011 22:51:16 -0800	[thread overview]
Message-ID: <1322549476-17208-3-git-send-email-bremner@debian.org> (raw)
In-Reply-To: <1322549476-17208-1-git-send-email-bremner@debian.org>

We assume that any symbol starting with notmuch_ in lib/*.o should be
exported, and that only those symbols should be exported.
---
 test/symbol-hiding |    6 ++++++
 1 files changed, 6 insertions(+), 0 deletions(-)

diff --git a/test/symbol-hiding b/test/symbol-hiding
index 6d4e4ff..68f0d1b 100755
--- a/test/symbol-hiding
+++ b/test/symbol-hiding
@@ -24,4 +24,10 @@ test_expect_success 'running test' run_test
 
 test_begin_subtest 'checking output'
 test_expect_equal "$result" "$output" 
+
+test_begin_subtest 'comparing existing to exported symbols'
+objdump -t $TEST_DIRECTORY/../lib/*.o | awk '$4 == ".text" && $6 ~ "^notmuch" {print $6}' | sort | uniq > ACTUAL
+sed -n 's/[[:blank:]]*\(notmuch_[^;]*\);/\1/p' $TEST_DIRECTORY/../notmuch.sym | sort | uniq > EXPORTED
+test_expect_equal_file EXPORTED ACTUAL
+
 test_done
-- 
1.7.5.4

  parent reply	other threads:[~2011-11-29  7:06 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-06-27  1:08 [PATCH] libnotmuch: build symbols list without relying on gcc -aux-info david
2011-06-27  2:42 ` david
2011-06-28 19:04   ` Carl Worth
2011-06-28 19:45     ` David Bremner
2011-11-29  6:51   ` New test for exported symbols David Bremner
2011-11-29  6:51     ` [PATCH 1/2] test/symbol-hiding: add some whitespace between tests David Bremner
2011-11-29  6:51     ` David Bremner [this message]
2011-12-08  0:59     ` New test for exported symbols David Bremner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://notmuchmail.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1322549476-17208-3-git-send-email-bremner@debian.org \
    --to=bremner@debian.org \
    --cc=notmuch@notmuchmail.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://yhetil.org/notmuch.git/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).