From: "Amadeusz Żołnowski" <aidecoe@aidecoe.name>
To: notmuch <notmuch@notmuchmail.org>
Subject: Re: [PATCH] Build symbol-test with make a not manually in symbol-hiding.
Date: Fri, 25 Nov 2011 11:03:05 +0100 [thread overview]
Message-ID: <1322215147-sup-1990@ittemni> (raw)
In-Reply-To: <1322214736-31335-1-git-send-email-aidecoe@aidecoe.name>
[-- Attachment #1: Type: text/plain, Size: 568 bytes --]
Excerpts from Amadeusz Żołnowski's message of 2011-11-25 10:52:16 +0100:
> Fixed warnings in symbol-test.cc, btw.
I forgot to add: why. If symbol-test is built in symbol-hiding with
hardcoded g++ invokation, it's not so easy to pass $(srcdir) which is
required to find notmuch.h when srcdir and builddir are separate
directories. When moved building to Makefile, it works fine.
PS.
"[PATCH] Build symbol-test with make a not manually in symbol-hiding."
^--- it should be "and" or ", "
--
Amadeusz Żołnowski
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 490 bytes --]
next prev parent reply other threads:[~2011-11-25 10:03 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-25 9:52 [PATCH] Build symbol-test with make a not manually in symbol-hiding Amadeusz Żołnowski
2011-11-25 10:03 ` Amadeusz Żołnowski [this message]
2011-11-25 10:09 ` [PATCH] Build symbol-test with make instead of hardcoding " Amadeusz Żołnowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://notmuchmail.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1322215147-sup-1990@ittemni \
--to=aidecoe@aidecoe.name \
--cc=notmuch@notmuchmail.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://yhetil.org/notmuch.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).