* [PATCH] emacs: fix `mm-make-handle' content-type parameter
@ 2011-11-18 18:13 Dmitry Kurochkin
2011-11-18 23:50 ` Dmitry Kurochkin
0 siblings, 1 reply; 2+ messages in thread
From: Dmitry Kurochkin @ 2011-11-18 18:13 UTC (permalink / raw)
To: notmuch
`notmuch-show-mm-display-part-inline' uses undocumented
`mm-make-handle' function. One of the parameters for `mm-make-handle'
is charset. Before the change, an unparsed content-type was given to
`mm-make-handle' (this was probably copied from Gnus source which uses
simple hard-coded values in a similar manner). But in fact,
`mm-make-handle' expects a content-type value parsed by
`mail-header-parse-content-type'. In particular, this is needed for
MIME display functions to correctly determine charset.
---
emacs/notmuch-show.el | 3 ++-
1 files changed, 2 insertions(+), 1 deletions(-)
diff --git a/emacs/notmuch-show.el b/emacs/notmuch-show.el
index d5c95d8..9fafafa 100644
--- a/emacs/notmuch-show.el
+++ b/emacs/notmuch-show.el
@@ -316,7 +316,8 @@ current buffer, if possible."
(let ((display-buffer (current-buffer)))
(with-temp-buffer
(insert content)
- (let ((handle (mm-make-handle (current-buffer) (list content-type))))
+ (let ((handle (mm-make-handle (current-buffer)
+ (mail-header-parse-content-type content-type))))
(set-buffer display-buffer)
(if (and (mm-inlinable-p handle)
(mm-inlined-p handle))
--
1.7.7.3
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] emacs: fix `mm-make-handle' content-type parameter
2011-11-18 18:13 [PATCH] emacs: fix `mm-make-handle' content-type parameter Dmitry Kurochkin
@ 2011-11-18 23:50 ` Dmitry Kurochkin
0 siblings, 0 replies; 2+ messages in thread
From: Dmitry Kurochkin @ 2011-11-18 23:50 UTC (permalink / raw)
To: notmuch
Please ignore this patch. Apparently, it is not enough to fix the
issue. A proper fix is available in [1].
Regards,
Dmitry
[1] id:"1321659905-24367-1-git-send-email-dmitry.kurochkin@gmail.com"
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2011-11-18 23:51 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-11-18 18:13 [PATCH] emacs: fix `mm-make-handle' content-type parameter Dmitry Kurochkin
2011-11-18 23:50 ` Dmitry Kurochkin
Code repositories for project(s) associated with this public inbox
https://yhetil.org/notmuch.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).