unofficial mirror of notmuch@notmuchmail.org
 help / color / mirror / code / Atom feed
From: Dmitry Kurochkin <dmitry.kurochkin@gmail.com>
To: notmuch@notmuchmail.org
Subject: [PATCH] emacs: fix `mm-make-handle' content-type parameter
Date: Fri, 18 Nov 2011 22:13:37 +0400	[thread overview]
Message-ID: <1321640017-25414-1-git-send-email-dmitry.kurochkin@gmail.com> (raw)

`notmuch-show-mm-display-part-inline' uses undocumented
`mm-make-handle' function.  One of the parameters for `mm-make-handle'
is charset.  Before the change, an unparsed content-type was given to
`mm-make-handle' (this was probably copied from Gnus source which uses
simple hard-coded values in a similar manner).  But in fact,
`mm-make-handle' expects a content-type value parsed by
`mail-header-parse-content-type'.  In particular, this is needed for
MIME display functions to correctly determine charset.
---
 emacs/notmuch-show.el |    3 ++-
 1 files changed, 2 insertions(+), 1 deletions(-)

diff --git a/emacs/notmuch-show.el b/emacs/notmuch-show.el
index d5c95d8..9fafafa 100644
--- a/emacs/notmuch-show.el
+++ b/emacs/notmuch-show.el
@@ -316,7 +316,8 @@ current buffer, if possible."
   (let ((display-buffer (current-buffer)))
     (with-temp-buffer
       (insert content)
-      (let ((handle (mm-make-handle (current-buffer) (list content-type))))
+      (let ((handle (mm-make-handle (current-buffer)
+				    (mail-header-parse-content-type content-type))))
 	(set-buffer display-buffer)
 	(if (and (mm-inlinable-p handle)
 		 (mm-inlined-p handle))
-- 
1.7.7.3

             reply	other threads:[~2011-11-18 18:13 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-11-18 18:13 Dmitry Kurochkin [this message]
2011-11-18 23:50 ` [PATCH] emacs: fix `mm-make-handle' content-type parameter Dmitry Kurochkin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://notmuchmail.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1321640017-25414-1-git-send-email-dmitry.kurochkin@gmail.com \
    --to=dmitry.kurochkin@gmail.com \
    --cc=notmuch@notmuchmail.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://yhetil.org/notmuch.git/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).