unofficial mirror of notmuch@notmuchmail.org
 help / color / mirror / code / Atom feed
From: Thomas Jost <schnouki@schnouki.net>
To: notmuch@notmuchmail.org
Subject: [PATCH 0/6] Rebase of Pieter's "set test prereqs"
Date: Wed, 16 Nov 2011 15:33:49 +0100	[thread overview]
Message-ID: <1321454035-22023-1-git-send-email-schnouki@schnouki.net> (raw)
In-Reply-To: <1320176954-4897-1-git-send-email-pieter@praet.org>

Hello list,

This is another rebased version of Pieter's series to add GPG and Emacs as test
prereqs, plus some additions on my own. (Rebased and posted as requested by
Pieter [1].)

Changes as compared to Pieter's patches (including parts from [2]):
- prereqs are not tested using test_expect_success as they were in Pieter's
  original patches, but using a new function called test_set_bin_prereq. I wrote
  this before the gdb prereq was added, hence the different way to set it.

- some fixes in Pieter's patches so that it actually works when gpg is not
  installed. Can't exactly remember what (...but you can just check his original
  patches), but in the end it was working fine in a chroot without gpg.

- since Emacs is now run using dtach, the emacs prereq also depends on dtach.
  The presence of emacs and dtach is also checked in the test_emacs() function
  of the test suite.

- testing for prereqs is now done using the "hash" built-in instead of "which",
  as suggested in [3].

Tested with and without dtach. A previous version of this series was also
without emacs/gpg in a chroot, but not this one :)

[1] id:"874ny4fcdz.fsf@praet.org"
[2] id:"1317660447-27520-1-git-send-email-schnouki@schnouki.net"
[3] id:"87zkgemodd.fsf@praet.org"

Pieter Praet (4):
  test: add 'GnuPG' prereq to dependent 'crypto' tests
  test: add 'Emacs' prereq to dependent 'crypto' tests
  test: add 'Emacs' prereq to dependent 'emacs' tests
  test: add 'Emacs' prereq to dependent 'emacs-large-search-buffer'
    tests

Thomas Jost (2):
  test: define a helper function for defining prereqs on executables
  test: check if emacs and dtach are available in test_emacs()

 test/crypto                    |   46 +++++++++++++++-------
 test/emacs                     |   82 +++++++++++++++++++++------------------
 test/emacs-large-search-buffer |    9 +++-
 test/test-lib.sh               |   17 ++++++++
 4 files changed, 99 insertions(+), 55 deletions(-)

-- 
1.7.7.3

  parent reply	other threads:[~2011-11-16 14:34 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-11-01 19:49 set test prereqs (Emacs, GDB, GPG) v4 Pieter Praet
2011-11-01 19:49 ` [PATCH 1/4] test: add 'GnuPG' prereq to dependent 'crypto' tests Pieter Praet
2011-11-01 21:17   ` Jameson Graef Rollins
2011-11-02 17:20     ` Pieter Praet
2011-11-01 19:49 ` [PATCH 2/4] test: add 'Emacs' " Pieter Praet
2011-11-01 19:49 ` [PATCH 3/4] test: add 'Emacs' prereq to dependent 'emacs' tests Pieter Praet
2011-11-01 19:49 ` [PATCH 4/4] test: add 'Emacs' prereq to dependent 'emacs-large-search-buffer' tests Pieter Praet
2011-11-01 20:20 ` set test prereqs (Emacs, GDB, GPG) v4 Ali Polatel
2011-11-02 17:21   ` Pieter Praet
2011-11-16 14:33 ` Thomas Jost [this message]
2011-11-16 14:33   ` [PATCH 1/6] test: define a helper function for defining prereqs on executables Thomas Jost
2011-11-16 14:33   ` [PATCH 2/6] test: check if emacs and dtach are available in test_emacs() Thomas Jost
2011-11-16 14:33   ` [PATCH 3/6] test: add 'GnuPG' prereq to dependent 'crypto' tests Thomas Jost
2011-11-16 14:33   ` [PATCH 4/6] test: add 'Emacs' " Thomas Jost
2011-11-16 14:33   ` [PATCH 5/6] test: add 'Emacs' prereq to dependent 'emacs' tests Thomas Jost
2011-11-16 14:33   ` [PATCH 6/6] test: add 'Emacs' prereq to dependent 'emacs-large-search-buffer' tests Thomas Jost
2011-11-16 18:53   ` [PATCH 0/6] Rebase of Pieter's "set test prereqs" Jameson Graef Rollins
2011-11-16 20:17     ` Thomas Jost
2011-11-16 20:50   ` Pieter Praet
2011-11-17 10:14     ` Thomas Jost
2012-01-12 17:07       ` Pieter Praet

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://notmuchmail.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1321454035-22023-1-git-send-email-schnouki@schnouki.net \
    --to=schnouki@schnouki.net \
    --cc=notmuch@notmuchmail.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://yhetil.org/notmuch.git/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).