unofficial mirror of notmuch@notmuchmail.org
 help / color / mirror / code / Atom feed
* [PATCH] lib/database.cc: use flush Xapian method instead of commit
@ 2011-10-28 14:56 David Bremner
  2011-11-02 14:18 ` Austin Clements
  0 siblings, 1 reply; 2+ messages in thread
From: David Bremner @ 2011-10-28 14:56 UTC (permalink / raw)
  To: notmuch; +Cc: David Bremner

From: David Bremner <bremner@debian.org>

Apparently the method was renamed in Xapian 1.1.0 but the old method
name will stay around for a while. It seems better to stick with the
old name to make notmuch compile with older versions of Xapian, at
least for now.
---
 lib/database.cc |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/lib/database.cc b/lib/database.cc
index e77fd53..5440df2 100644
--- a/lib/database.cc
+++ b/lib/database.cc
@@ -1030,7 +1030,7 @@ notmuch_database_end_atomic (notmuch_database_t *notmuch)
 	 * However, we rely on flushing to test atomicity. */
 	const char *thresh = getenv ("XAPIAN_FLUSH_THRESHOLD");
 	if (thresh && atoi (thresh) == 1)
-	    db->commit ();
+	    db->flush ();
     } catch (const Xapian::Error &error) {
 	fprintf (stderr, "A Xapian exception occurred committing transaction: %s.\n",
 		 error.get_msg().c_str());
-- 
1.7.5.4

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] lib/database.cc: use flush Xapian method instead of commit
  2011-10-28 14:56 [PATCH] lib/database.cc: use flush Xapian method instead of commit David Bremner
@ 2011-11-02 14:18 ` Austin Clements
  0 siblings, 0 replies; 2+ messages in thread
From: Austin Clements @ 2011-11-02 14:18 UTC (permalink / raw)
  To: David Bremner; +Cc: notmuch, David Bremner

On Fri, Oct 28, 2011 at 10:56 AM, David Bremner <david@tethera.net> wrote:
> From: David Bremner <bremner@debian.org>
>
> Apparently the method was renamed in Xapian 1.1.0 but the old method
> name will stay around for a while. It seems better to stick with the
> old name to make notmuch compile with older versions of Xapian, at
> least for now.

LGTM

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2011-11-02 14:18 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-10-28 14:56 [PATCH] lib/database.cc: use flush Xapian method instead of commit David Bremner
2011-11-02 14:18 ` Austin Clements

Code repositories for project(s) associated with this public inbox

	https://yhetil.org/notmuch.git/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).