From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by olra.theworths.org (Postfix) with ESMTP id 3F9F9431FD0 for ; Thu, 29 Sep 2011 11:25:40 -0700 (PDT) X-Virus-Scanned: Debian amavisd-new at olra.theworths.org X-Spam-Flag: NO X-Spam-Score: 0 X-Spam-Level: X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[RCVD_IN_DNSWL_NONE=-0.0001] autolearn=disabled Received: from olra.theworths.org ([127.0.0.1]) by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id p5Ot73H4gxIr for ; Thu, 29 Sep 2011 11:25:39 -0700 (PDT) Received: from smtprelay04.ispgateway.de (smtprelay04.ispgateway.de [80.67.31.27]) by olra.theworths.org (Postfix) with ESMTP id 820F4431FB6 for ; Thu, 29 Sep 2011 11:25:39 -0700 (PDT) Received: from [87.180.87.168] (helo=stokes.schwinge.homeip.net) by smtprelay04.ispgateway.de with esmtpa (Exim 4.68) (envelope-from ) id 1R9LHn-0003cA-4q for notmuch@notmuchmail.org; Thu, 29 Sep 2011 20:24:43 +0200 Received: (qmail 25126 invoked from network); 29 Sep 2011 18:24:14 -0000 Received: from boole.schwinge.homeip.net (192.168.111.208) by stokes.schwinge.homeip.net with QMQP; 29 Sep 2011 18:24:14 -0000 Received: (nullmailer pid 15103 invoked by uid 1000); Thu, 29 Sep 2011 18:24:14 -0000 From: Thomas Schwinge To: notmuch@notmuchmail.org Subject: [PATCH] patchformatting: Test Suite Enhancements Date: Thu, 29 Sep 2011 20:24:05 +0200 Message-Id: <1317320646-15062-1-git-send-email-thomas@schwinge.name> X-Mailer: git-send-email 1.7.6.3 In-Reply-To: <87boutee61.fsf@servo.factory.finestructure.net> References: <87boutee61.fsf@servo.factory.finestructure.net> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Df-Sender: dGhvbWFzQHNjaHdpbmdlLm5hbWU= Cc: Thomas Schwinge X-BeenThere: notmuch@notmuchmail.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 29 Sep 2011 18:25:40 -0000 Based on the emails starting at id:"87liu2kcq6.fsf@servo.factory.finestructure.net". --- Hi! I applied the attached patch, based on this thread's discussion. Grüße, Thomas --- patchformatting.mdwn | 10 ++++++++++ 1 files changed, 10 insertions(+), 0 deletions(-) diff --git a/patchformatting.mdwn b/patchformatting.mdwn index cf5bf81..914371d 100644 --- a/patchformatting.mdwn +++ b/patchformatting.mdwn @@ -41,6 +41,16 @@ Eric S. Raymond has written good [Software Release Practice HOWTO](http://tldp.org/HOWTO/Software-Release-Practice-HOWTO/). Check what he has to say about this issue. +### Test Suite Enhancements + +New features as well as bug fixes should typically come with test suite +enhancements. The test suite changes should be done first (tagged as *expected +to fail*), and the feature implementation or bug fix should come second +(removing the *expected to fail* tag). This way, the test suite specifies the +behavior you're trying to implement, be it a new feature or a bug fix. By +defining beforehand exactly what you expect to happen, everyone can confirm +that your patch achieves what it is meant it to. + ## Prepare patches for e-mail submission If you've made just one commit (containing just one bugfix or new feature) -- 1.7.6.3