unofficial mirror of notmuch@notmuchmail.org
 help / color / mirror / code / Atom feed
From: Thomas Schwinge <thomas@schwinge.name>
To: notmuch@notmuchmail.org
Cc: Thomas Schwinge <thomas@schwinge.name>
Subject: [PATCH] patchformatting: Test Suite Enhancements
Date: Thu, 29 Sep 2011 20:24:05 +0200	[thread overview]
Message-ID: <1317320646-15062-1-git-send-email-thomas@schwinge.name> (raw)
In-Reply-To: <87boutee61.fsf@servo.factory.finestructure.net>

Based on the emails starting at
id:"87liu2kcq6.fsf@servo.factory.finestructure.net".
---

Hi!

I applied the attached patch, based on this thread's discussion.


Grüße,
 Thomas


---
 patchformatting.mdwn |   10 ++++++++++
 1 files changed, 10 insertions(+), 0 deletions(-)

diff --git a/patchformatting.mdwn b/patchformatting.mdwn
index cf5bf81..914371d 100644
--- a/patchformatting.mdwn
+++ b/patchformatting.mdwn
@@ -41,6 +41,16 @@ Eric S. Raymond has written good
 [Software Release Practice HOWTO](http://tldp.org/HOWTO/Software-Release-Practice-HOWTO/).
 Check what he has to say about this issue. 
 
+### Test Suite Enhancements
+
+New features as well as bug fixes should typically come with test suite
+enhancements.  The test suite changes should be done first (tagged as *expected
+to fail*), and the feature implementation or bug fix should come second
+(removing the *expected to fail* tag).  This way, the test suite specifies the
+behavior you're trying to implement, be it a new feature or a bug fix.  By
+defining beforehand exactly what you expect to happen, everyone can confirm
+that your patch achieves what it is meant it to.
+
 ## Prepare patches for e-mail submission
 
 If you've made just one commit (containing just one bugfix or new feature)
-- 
1.7.6.3

  reply	other threads:[~2011-09-29 18:25 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-09-05 19:07 [PATCH] notmuch restore --accumulate Thomas Schwinge
2011-09-05 19:31 ` Jameson Graef Rollins
2011-09-09  9:06   ` Louis Rilling
2011-09-09  9:45     ` Thomas Schwinge
2011-09-09 16:13       ` Austin Clements
2011-09-09 17:22         ` Thomas Schwinge
2011-09-09 17:35           ` Austin Clements
2011-09-09 18:58           ` Jameson Graef Rollins
2011-09-29 18:24             ` Thomas Schwinge [this message]
2011-09-29 17:36 ` [PATCH, v2] " Thomas Schwinge
2011-09-29 17:37   ` Thomas Schwinge
2011-10-21 19:47     ` Updated v3 patches for " David Bremner
2011-10-21 19:47       ` [PATCH 1/6] test/test-lib.sh: update comments David Bremner
2011-10-21 19:47       ` [PATCH 2/6] test/dump-restore: expand test suite for dump-restore, make more robust David Bremner
2011-10-21 19:47       ` [PATCH 3/6] test/dump-restore: add tests for restore --accumulate David Bremner
2011-10-21 19:47       ` [PATCH 4/6] notmuch-restore: implement --accumulate option David Bremner
2011-10-21 19:47       ` [PATCH 5/6] test/dump-restore: Fix quoting on grep David Bremner
2011-10-21 19:47       ` [PATCH 6/6] notmuch-restore: check for extra arguments David Bremner
2011-10-21 22:21         ` [PATCH 1/2] notmuch.1: typo fixes new wording for dump/restore David Bremner
2011-10-21 22:21           ` [PATCH 2/2] docs: Update news, man page, and online help for restore --accumulate David Bremner
2011-10-23 19:50       ` Updated v3 patches for notmuch " David Bremner
2011-10-16 21:48   ` [PATCH, v2] " David Bremner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://notmuchmail.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1317320646-15062-1-git-send-email-thomas@schwinge.name \
    --to=thomas@schwinge.name \
    --cc=notmuch@notmuchmail.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://yhetil.org/notmuch.git/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).