unofficial mirror of notmuch@notmuchmail.org
 help / color / mirror / code / Atom feed
From: Martin Owens <doctormo@gmail.com>
To: Austin Clements <amdragon@mit.edu>
Cc: Paul Tagliamonte <paultag@ubuntu.com>,
	Notmuch developer list <notmuch@notmuchmail.org>
Subject: Re: Patch: Flush and Reopen
Date: Thu, 08 Sep 2011 22:54:21 -0400	[thread overview]
Message-ID: <1315536861.2435.34.camel@delen> (raw)
In-Reply-To: <CAH-f9WtuYYuksfTHL1ZMmoRF6kyL7iFu9BXDzGn-wWGniSvf9w@mail.gmail.com>

Hey Austin,

Thanks for the review :-) I'll attempt to fix some of the style
guidelines, but see below.

On Thu, 2011-09-08 at 22:42 -0400, Austin Clements wrote:
> Did you mean to change this?

This fails to build on Ubuntu maverick with the extra .3 and I see no
reason to have that sub-minor version. Pushing it in would probably be
useful unless there is a real reason.

> This cast will fail.  Shouldn't this just be a wrapper around
> notmuch->xapian_db->reopen? 

I'm a python programmer, c wrappers are beyond me unfortunately. Your
help implementing that would be really good.

Best regards, Martin Owens

  reply	other threads:[~2011-09-09  2:54 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-09-08  1:34 Patch: Flush and Reopen Martin Owens
2011-09-09  2:42 ` Austin Clements
2011-09-09  2:54   ` Martin Owens [this message]
2011-09-09 11:06     ` David Bremner
2011-09-09 17:55       ` Martin Owens
2011-09-09 23:40         ` Austin Clements
2011-09-10  0:43           ` Martin Owens
2011-09-12  0:23             ` Austin Clements
2011-09-12  1:03               ` Martin Owens
2011-09-12  1:04               ` Martin Owens
2011-09-12 12:23                 ` Sebastian Spaeth

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://notmuchmail.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1315536861.2435.34.camel@delen \
    --to=doctormo@gmail.com \
    --cc=amdragon@mit.edu \
    --cc=notmuch@notmuchmail.org \
    --cc=paultag@ubuntu.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://yhetil.org/notmuch.git/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).