From: Pieter Praet <pieter@praet.org>
To: Notmuch Mail <notmuch@notmuchmail.org>
Subject: [PATCH 5/6] test: emacs: `notmuch-search-operate-all' should operate on threads, not messages
Date: Sun, 10 Jul 2011 17:55:34 +0200 [thread overview]
Message-ID: <1310313335-4159-6-git-send-email-pieter@praet.org> (raw)
In-Reply-To: <1310313335-4159-1-git-send-email-pieter@praet.org>
In order to be consistent with `notmuch-search-{add,remove}-tag' ("+"/"-"),
`notmuch-search-operate-all' ("*") should operate on matching threads
instead of matching messages.
This test exposes an existing bug, so is currently failing.
It should be fixed in the next commit.
Signed-off-by: Pieter Praet <pieter@praet.org>
---
test/emacs-search-operate-all | 8 ++++----
1 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/test/emacs-search-operate-all b/test/emacs-search-operate-all
index 2bd50ba..48326c8 100755
--- a/test/emacs-search-operate-all
+++ b/test/emacs-search-operate-all
@@ -7,7 +7,7 @@ EXPECTED=$TEST_DIRECTORY/emacs.expected-output
add_email_corpus
-test_begin_subtest "Add/remove tags to/from all matching messages."
+test_begin_subtest "Add/remove tags to/from all matching threads."
test_emacs '(notmuch-search "tag:inbox AND tags")
(notmuch-test-wait)
(notmuch-search-operate-all "+matching -inbox")
@@ -15,13 +15,13 @@ test_emacs '(notmuch-search "tag:inbox AND tags")
(notmuch-test-wait)
(test-output)'
cat <<EOF >EXPECTED
+ 2009-11-18 [2/2] Ingmar Vanhassel, Carl Worth [notmuch] [PATCH] Typsos (matching unread)
2009-11-18 [3/3] Adrian Perez de Castro, Keith Packard, Carl Worth [notmuch] Introducing myself (matching signed unread)
- 2009-11-18 [1/3] Carl Worth, Israel Herraiz, Keith Packard [notmuch] New to the list (inbox matching unread)
+ 2009-11-18 [3/3] Israel Herraiz, Keith Packard, Carl Worth [notmuch] New to the list (matching unread)
2009-11-18 [2/2] Keith Packard, Carl Worth [notmuch] [PATCH] Make notmuch-show 'X' (and 'x') commands remove inbox (and unread) tags (matching unread)
- 2009-11-18 [1/2] Keith Packard, Alexander Botero-Lowry [notmuch] [PATCH] Create a default notmuch-show-hook that highlights URLs and uses word-wrap (inbox matching unread)
+ 2009-11-18 [2/2] Keith Packard, Alexander Botero-Lowry [notmuch] [PATCH] Create a default notmuch-show-hook that highlights URLs and uses word-wrap (matching unread)
2009-11-18 [1/1] Jan Janak [notmuch] [PATCH] notmuch new: Support for conversion of spool subdirectories into tags (matching unread)
2009-11-18 [1/1] Stewart Smith [notmuch] [PATCH] Fix linking with gcc to use g++ to link in C++ libs. (matching unread)
- 2009-11-17 [1/2] Ingmar Vanhassel, Carl Worth [notmuch] [PATCH] Typsos (inbox matching unread)
End of search results.
EOF
test_expect_equal_file OUTPUT EXPECTED
--
1.7.5.4
next prev parent reply other threads:[~2011-07-10 15:56 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-10 15:55 Extend test coverage wrt tagging Pieter Praet
2011-07-10 15:55 ` [PATCH 1/6] test: emacs: rename subtest "Reply within emacs" to "Compose reply in emacs" Pieter Praet
2011-07-10 15:55 ` [PATCH 2/6] test: emacs: add test for sending a reply from within Emacs Pieter Praet
2011-07-10 15:55 ` [PATCH 3/6] test: emacs: add test to verify that the message being replied to is tagged as such Pieter Praet
2011-07-10 15:55 ` [PATCH 4/6] test: emacs: add test for `notmuch-search-operate-all' Pieter Praet
2011-07-10 15:55 ` Pieter Praet [this message]
2011-07-10 15:55 ` [PATCH 6/6] emacs: make `notmuch-search-operate-all' operate on threads, not messages Pieter Praet
2011-11-12 16:13 ` David Bremner
2011-11-12 16:35 ` Austin Clements
2011-11-16 13:55 ` Pieter Praet
2012-02-19 20:38 ` Pieter Praet
2012-02-19 20:38 ` [PATCH v2 1/4] test: emacs: rename subtest "Reply within emacs" Pieter Praet
2012-02-20 12:16 ` Dmitry Kurochkin
2012-02-19 20:38 ` [PATCH v2 2/4] test: emacs: new test "notmuch-search: replying to a thread (sending)" Pieter Praet
2012-02-19 21:04 ` Tomi Ollila
2012-02-22 18:49 ` Pieter Praet
2012-02-20 12:44 ` Dmitry Kurochkin
2012-02-22 18:51 ` Pieter Praet
2012-02-19 20:38 ` [PATCH v2 3/4] test: emacs: new test "notmuch-search: when reply is sent, parent message should be tagged 'replied'" Pieter Praet
2012-02-20 12:20 ` Dmitry Kurochkin
2012-02-22 18:52 ` Pieter Praet
2012-02-19 20:38 ` [PATCH v2 4/4] test: emacs: new test "notmuch-search: change tags of all matching messages" Pieter Praet
2012-02-19 21:08 ` Tomi Ollila
2012-02-22 18:53 ` Pieter Praet
2012-02-20 12:25 ` Dmitry Kurochkin
2012-02-22 18:53 ` Pieter Praet
2012-02-22 18:54 ` [PATCH v3] " Pieter Praet
2012-03-07 19:49 ` [PATCH v4] " Pieter Praet
2012-03-11 18:42 ` Tomi Ollila
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://notmuchmail.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1310313335-4159-6-git-send-email-pieter@praet.org \
--to=pieter@praet.org \
--cc=notmuch@notmuchmail.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://yhetil.org/notmuch.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).