From: david@tethera.net
To: notmuch@notmuchmail.org
Cc: David Bremner <bremner@debian.org>
Subject: [PATCH] libnotmuch: fix typos in CLEAN setting, add file
Date: Sat, 25 Jun 2011 09:45:58 -0300 [thread overview]
Message-ID: <1309005958-10409-1-git-send-email-david@tethera.net> (raw)
In-Reply-To: <87aad7ce2w.fsf@yoom.home.cworth.org>
From: David Bremner <bremner@debian.org>
- c0961e6 introduced a missing slash between $(dir)$(LIBNAME) and missing
$(dir) in front of libnotmuch.a
- cdf1c70a created a file $(dir)/notmuch.h.gch and neglected to
add it to CLEAN
---
Here is an updated version. I'm not sure the best way to do a test of
the cleaning; maybe we should ship a MANIFEST file containing the
output of git ls-files. I'm not sure how much churn this would cause
in git. Perhaps it could be treated like version, and generated from
git if possible. In any case I guess this couldn't really be part of
our regular test suite, because all the other tests would fail ;).
lib/Makefile.local | 4 +++-
1 files changed, 3 insertions(+), 1 deletions(-)
diff --git a/lib/Makefile.local b/lib/Makefile.local
index a33ba34..eaa8af4 100644
--- a/lib/Makefile.local
+++ b/lib/Makefile.local
@@ -103,4 +103,6 @@ install-$(dir): $(dir)/$(LIBNAME)
$(LIBRARY_INSTALL_POST_COMMAND)
SRCS := $(SRCS) $(libnotmuch_c_srcs) $(libnotmuch_cxx_srcs)
-CLEAN := $(CLEAN) $(libnotmuch_modules) $(dir)/$(SONAME) $(dir)/$(LINKER_NAME) $(dir)$(LIBNAME) libnotmuch.a notmuch.aux notmuch.sym
+CLEAN += $(libnotmuch_modules) $(dir)/$(SONAME) $(dir)/$(LINKER_NAME)
+CLEAN += $(dir)/$(LIBNAME) $(dir)/libnotmuch.a notmuch.aux notmuch.sym
+CLEAN += $(dir)/notmuch.h.gch
--
1.7.5.3
next prev parent reply other threads:[~2011-06-25 12:46 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-24 10:53 [PATCH] libnotmuch: fix typo in CLEAN setting, add file david
2011-06-24 17:51 ` Carl Worth
2011-06-25 12:45 ` david [this message]
2011-06-28 18:55 ` [PATCH] libnotmuch: fix typos " Carl Worth
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://notmuchmail.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1309005958-10409-1-git-send-email-david@tethera.net \
--to=david@tethera.net \
--cc=bremner@debian.org \
--cc=notmuch@notmuchmail.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://yhetil.org/notmuch.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).