From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by olra.theworths.org (Postfix) with ESMTP id 17878429E30 for ; Wed, 15 Jun 2011 04:12:01 -0700 (PDT) X-Virus-Scanned: Debian amavisd-new at olra.theworths.org X-Spam-Flag: NO X-Spam-Score: -0.799 X-Spam-Level: X-Spam-Status: No, score=-0.799 tagged_above=-999 required=5 tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled Received: from olra.theworths.org ([127.0.0.1]) by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id Bx5ufUuB0g7x for ; Wed, 15 Jun 2011 04:11:59 -0700 (PDT) Received: from mail-fx0-f53.google.com (mail-fx0-f53.google.com [209.85.161.53]) (using TLSv1 with cipher RC4-SHA (128/128 bits)) (No client certificate requested) by olra.theworths.org (Postfix) with ESMTPS id EC5B8429E2C for ; Wed, 15 Jun 2011 04:11:56 -0700 (PDT) Received: by mail-fx0-f53.google.com with SMTP id 8so337389fxm.26 for ; Wed, 15 Jun 2011 04:11:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:from:to:cc:subject:date:message-id:x-mailer :in-reply-to:references; bh=PAuLW78XBk3bbf/o5yZ2bjSkHsgYekhy4VfBC7BYaew=; b=MKMEpVUjD8AZChPBwBrvy+sJHC1vDVmj59/qoh30V7thNyCKUacIDZQvxrJRA0HkGw 3WRcsqQ1sSZ2bbUviabB2w7G/kVi8sViYCn2XnyYZea6KyGfTUXoxG/LcHElaVS4S8qH qmce3kYY3M/fUcspFoyZQAo1Li89+9H0MQo5g= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=from:to:cc:subject:date:message-id:x-mailer:in-reply-to:references; b=VW0SzORig0VLd2sn7eiO3ucELY/FVOZcqWXKCr4sK37p/2IAqDNKIBk2emHH6qyi0U MMz3NcGLyoIl2dtQElTElkT3ObLY62XT+6DSMiCDKL5Z92VfAwC5ArCqWB9l9ULkTjSO 7HP2ck8BfWNBdM97j02H8eDAKN4aF3FihY33k= Received: by 10.223.127.210 with SMTP id h18mr445302fas.46.1308136316547; Wed, 15 Jun 2011 04:11:56 -0700 (PDT) Received: from localhost ([91.144.186.21]) by mx.google.com with ESMTPS id n15sm160960fag.18.2011.06.15.04.11.55 (version=TLSv1/SSLv3 cipher=OTHER); Wed, 15 Jun 2011 04:11:55 -0700 (PDT) From: Dmitry Kurochkin To: notmuch@notmuchmail.org Subject: [PATCH 2/3] Fix memory leak in guess_from_received_header(). Date: Wed, 15 Jun 2011 15:12:13 +0400 Message-Id: <1308136334-9219-2-git-send-email-dmitry.kurochkin@gmail.com> X-Mailer: git-send-email 1.7.5.4 In-Reply-To: <1308136334-9219-1-git-send-email-dmitry.kurochkin@gmail.com> References: <1308136334-9219-1-git-send-email-dmitry.kurochkin@gmail.com> X-BeenThere: notmuch@notmuchmail.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 15 Jun 2011 11:12:01 -0000 Mta variable was not free()d in one case. --- notmuch-reply.c | 4 +++- 1 files changed, 3 insertions(+), 1 deletions(-) diff --git a/notmuch-reply.c b/notmuch-reply.c index dab69e6..64f70bf 100644 --- a/notmuch-reply.c +++ b/notmuch-reply.c @@ -401,8 +401,10 @@ guess_from_received_header (notmuch_config_t *config, notmuch_message_t *message break; mta = xstrdup (by); token = strtok(mta," \t"); - if (token == NULL) + if (token == NULL) { + free (mta); break; + } /* Now extract the last two components of the MTA host name * as domain and tld. */ -- 1.7.5.4