From: Jameson Graef Rollins <jrollins@finestructure.net>
To: Notmuch Mail <notmuch@notmuchmail.org>
Subject: [PATCH 2/4] Fix notmuch-reply to not output "Non-text part:" lines for non-leafnode parts.
Date: Wed, 8 Jun 2011 12:30:07 -0700 [thread overview]
Message-ID: <1307561409-5646-3-git-send-email-jrollins@finestructure.net> (raw)
In-Reply-To: <1307561409-5646-2-git-send-email-jrollins@finestructure.net>
These lines are just cruft in this case, and can be removed.
---
notmuch-reply.c | 11 ++++++-----
1 files changed, 6 insertions(+), 5 deletions(-)
diff --git a/notmuch-reply.c b/notmuch-reply.c
index a19eb19..7a76ba3 100644
--- a/notmuch-reply.c
+++ b/notmuch-reply.c
@@ -93,7 +93,12 @@ reply_part_content (GMimeObject *part)
GMimeContentType *content_type = g_mime_object_get_content_type (GMIME_OBJECT (part));
GMimeContentDisposition *disposition = g_mime_object_get_content_disposition (part);
- if (g_mime_content_type_is_type (content_type, "text", "*") &&
+ if (g_mime_content_type_is_type (content_type, "multipart", "*") ||
+ g_mime_content_type_is_type (content_type, "message", "rfc822"))
+ {
+ /* Output nothing, since multipart subparts will be handled individually. */
+ }
+ else if (g_mime_content_type_is_type (content_type, "text", "*") &&
!g_mime_content_type_is_type (content_type, "text", "html"))
{
GMimeStream *stream_stdout = NULL, *stream_filter = NULL;
@@ -120,10 +125,6 @@ reply_part_content (GMimeObject *part)
if (stream_stdout)
g_object_unref(stream_stdout);
}
- else if (g_mime_content_type_is_type (content_type, "message", "rfc822"))
- {
- /* Output nothing, since rfc822 subparts will be handled individually. */
- }
else
{
if (disposition &&
--
1.7.5.3
next prev parent reply other threads:[~2011-06-08 19:30 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-02 17:13 problems with message/rfc822 parts Jameson Graef Rollins
2011-06-06 0:29 ` improving message/rfc822 part handling Jameson Graef Rollins
2011-06-06 0:29 ` [PATCH 1/5] test: some small fixes to multipart test Jameson Graef Rollins
2011-06-06 0:29 ` [PATCH 2/5] test: Fix date in test message in " Jameson Graef Rollins
2011-06-06 0:29 ` [PATCH 3/5] test: overhaul multipart test to test for improved message/rfc822 handling Jameson Graef Rollins
2011-06-06 0:29 ` [PATCH 4/5] Improve handling of message/rfc822 parts by adding a new header_message_part function to the formating structure Jameson Graef Rollins
2011-06-06 0:29 ` [PATCH 5/5] emacs: Improve support for message/rfc822 parts Jameson Graef Rollins
2011-06-08 19:30 ` tweaks for handling parts in reply Jameson Graef Rollins
2011-06-08 19:30 ` [PATCH 1/4] test/multipart: test for absence of "Non-text part:" lines in reply for multipart/* and message/rfc822 parts Jameson Graef Rollins
2011-06-08 19:30 ` Jameson Graef Rollins [this message]
2011-06-08 19:30 ` [PATCH 3/4] test: test for absence of "Non-text part: application/pgp-*" lines in reply Jameson Graef Rollins
2011-06-08 19:30 ` [PATCH 4/4] Ignore "application/pgp-*" parts " Jameson Graef Rollins
2011-06-10 1:58 ` tweaks for handling " Austin Clements
2011-10-06 13:29 ` David Bremner
2011-10-06 17:24 ` Jameson Graef Rollins
2011-09-05 19:01 ` [PATCH] test: overhaul multipart test to test for improved message/rfc822 handling Jameson Graef Rollins
2011-09-06 2:08 ` David Bremner
2011-09-05 12:06 ` [PATCH 2/5] test: Fix date in test message in multipart test David Bremner
2011-06-06 0:33 ` improving message/rfc822 part handling Jameson Graef Rollins
2011-06-06 3:56 ` Jameson Graef Rollins
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://notmuchmail.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1307561409-5646-3-git-send-email-jrollins@finestructure.net \
--to=jrollins@finestructure.net \
--cc=notmuch@notmuchmail.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://yhetil.org/notmuch.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).