unofficial mirror of notmuch@notmuchmail.org
 help / color / mirror / code / Atom feed
From: Jameson Graef Rollins <jrollins@finestructure.net>
To: Notmuch Mail <notmuch@notmuchmail.org>
Subject: [PATCH 5/5] emacs: Improve support for message/rfc822 parts.
Date: Sun,  5 Jun 2011 17:29:29 -0700	[thread overview]
Message-ID: <1307320169-29905-6-git-send-email-jrollins@finestructure.net> (raw)
In-Reply-To: <1307320169-29905-5-git-send-email-jrollins@finestructure.net>

The insert-part-message/rfc822 function is overhauled to properly
processes the new formatting of message/rfc822 parts.  The json output
for message parts now includes "headers" and "body" fields, which are
now parsed and output appropriately.
---
 emacs/notmuch-show.el |   21 +++++++++++++--------
 1 files changed, 13 insertions(+), 8 deletions(-)

diff --git a/emacs/notmuch-show.el b/emacs/notmuch-show.el
index 7d848e3..0f1fe69 100644
--- a/emacs/notmuch-show.el
+++ b/emacs/notmuch-show.el
@@ -519,21 +519,26 @@ current buffer, if possible."
   t)
 
 (defun notmuch-show-insert-part-message/rfc822 (msg part content-type nth depth declared-type)
-  (let* ((message-part (plist-get part :content))
-	 (inner-parts (plist-get message-part :content)))
-    (notmuch-show-insert-part-header nth declared-type content-type nil)
+  (notmuch-show-insert-part-header nth declared-type content-type nil)
+  (let* ((message (car (plist-get part :content)))
+	 (headers (plist-get message :headers))
+	 (body (car (plist-get message :body)))
+	 (start (point)))
+
     ;; Override `notmuch-message-headers' to force `From' to be
     ;; displayed.
     (let ((notmuch-message-headers '("From" "Subject" "To" "Cc" "Date")))
-      (notmuch-show-insert-headers (plist-get part :headers)))
+      (notmuch-show-insert-headers (plist-get message :headers)))
+
     ;; Blank line after headers to be compatible with the normal
     ;; message display.
     (insert "\n")
 
-    ;; Show all of the parts.
-    (mapc (lambda (inner-part)
-	    (notmuch-show-insert-bodypart msg inner-part depth))
-	  inner-parts))
+    ;; Show the body
+    (notmuch-show-insert-bodypart msg body depth)
+
+    (when notmuch-show-indent-multipart
+      (indent-rigidly start (point) 1)))
   t)
 
 (defun notmuch-show-insert-part-text/plain (msg part content-type nth depth declared-type)
-- 
1.7.4.4

  reply	other threads:[~2011-06-06  0:29 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-06-02 17:13 problems with message/rfc822 parts Jameson Graef Rollins
2011-06-06  0:29 ` improving message/rfc822 part handling Jameson Graef Rollins
2011-06-06  0:29   ` [PATCH 1/5] test: some small fixes to multipart test Jameson Graef Rollins
2011-06-06  0:29     ` [PATCH 2/5] test: Fix date in test message in " Jameson Graef Rollins
2011-06-06  0:29       ` [PATCH 3/5] test: overhaul multipart test to test for improved message/rfc822 handling Jameson Graef Rollins
2011-06-06  0:29         ` [PATCH 4/5] Improve handling of message/rfc822 parts by adding a new header_message_part function to the formating structure Jameson Graef Rollins
2011-06-06  0:29           ` Jameson Graef Rollins [this message]
2011-06-08 19:30         ` tweaks for handling parts in reply Jameson Graef Rollins
2011-06-08 19:30           ` [PATCH 1/4] test/multipart: test for absence of "Non-text part:" lines in reply for multipart/* and message/rfc822 parts Jameson Graef Rollins
2011-06-08 19:30             ` [PATCH 2/4] Fix notmuch-reply to not output "Non-text part:" lines for non-leafnode parts Jameson Graef Rollins
2011-06-08 19:30               ` [PATCH 3/4] test: test for absence of "Non-text part: application/pgp-*" lines in reply Jameson Graef Rollins
2011-06-08 19:30                 ` [PATCH 4/4] Ignore "application/pgp-*" parts " Jameson Graef Rollins
2011-06-10  1:58           ` tweaks for handling " Austin Clements
2011-10-06 13:29           ` David Bremner
2011-10-06 17:24             ` Jameson Graef Rollins
2011-09-05 19:01         ` [PATCH] test: overhaul multipart test to test for improved message/rfc822 handling Jameson Graef Rollins
2011-09-06  2:08           ` David Bremner
2011-09-05 12:06       ` [PATCH 2/5] test: Fix date in test message in multipart test David Bremner
2011-06-06  0:33   ` improving message/rfc822 part handling Jameson Graef Rollins
2011-06-06  3:56   ` Jameson Graef Rollins

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://notmuchmail.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1307320169-29905-6-git-send-email-jrollins@finestructure.net \
    --to=jrollins@finestructure.net \
    --cc=notmuch@notmuchmail.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://yhetil.org/notmuch.git/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).