From: Jameson Graef Rollins <jrollins@finestructure.net>
To: Notmuch Mail <notmuch@notmuchmail.org>
Subject: [PATCH] Do not attept to output part raw if part is not GMimePart.
Date: Fri, 3 Jun 2011 10:01:06 -0700 [thread overview]
Message-ID: <1307120466-4980-1-git-send-email-jrollins@finestructure.net> (raw)
In-Reply-To: <1307032735-27427-1-git-send-email-jrollins@finestructure.net>
This was a minor oversite in checking of part type when outputing
content raw. This was causing gmime was to throw an exception to
stderr.
Unfortunately the gmime exception was not being caught by notmuch, or
the test suite. I'm not sure if notmuch should have done anything in
this case, but certainly the test suite should be capable of detecting
that something unexpected was output to stderr.
---
This is a cleaner version of this patch.
notmuch-show.c | 3 +++
1 files changed, 3 insertions(+), 0 deletions(-)
diff --git a/notmuch-show.c b/notmuch-show.c
index 9267d02..59f7078 100644
--- a/notmuch-show.c
+++ b/notmuch-show.c
@@ -644,6 +644,9 @@ format_part_end_json (GMimeObject *part)
static void
format_part_content_raw (GMimeObject *part)
{
+ if (! GMIME_IS_PART (part))
+ return;
+
GMimeStream *stream_stdout;
GMimeStream *stream_filter = NULL;
GMimeDataWrapper *wrapper;
--
1.7.4.4
next prev parent reply other threads:[~2011-06-03 17:01 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-02 16:38 [PATCH] Do not attept to output part raw if part is not GMimePart Jameson Graef Rollins
2011-06-03 17:01 ` Jameson Graef Rollins [this message]
2011-06-23 23:33 ` Carl Worth
2011-06-27 17:07 ` Jameson Graef Rollins
2011-06-27 20:43 ` Austin Clements
2011-06-27 21:04 ` Daniel Kahn Gillmor
2011-06-27 21:44 ` Jameson Graef Rollins
2011-06-27 22:07 ` Austin Clements
2011-06-27 22:41 ` interaction between --format=raw and multipart handling [was: Re: Do not attept to output part raw if part is not GMimePart.] Daniel Kahn Gillmor
2011-06-28 2:12 ` Austin Clements
2011-09-06 16:43 ` [PATCH] Do not attept to output part raw if part is not GMimePart Jameson Graef Rollins
2011-09-06 16:49 ` Dmitry Kurochkin
2011-09-06 22:51 ` Jameson Graef Rollins
2011-09-07 21:46 ` David Bremner
2011-09-07 22:10 ` Jameson Graef Rollins
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://notmuchmail.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1307120466-4980-1-git-send-email-jrollins@finestructure.net \
--to=jrollins@finestructure.net \
--cc=notmuch@notmuchmail.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://yhetil.org/notmuch.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).