unofficial mirror of notmuch@notmuchmail.org
 help / color / mirror / code / Atom feed
From: Dmitry Kurochkin <dmitry.kurochkin@gmail.com>
To: notmuch@notmuchmail.org
Subject: [PATCH 4/5] Set higher priority for headers and hidden citation overlays.
Date: Thu, 26 May 2011 02:10:15 +0400	[thread overview]
Message-ID: <1306361416-5019-5-git-send-email-dmitry.kurochkin@gmail.com> (raw)
In-Reply-To: <1306361416-5019-1-git-send-email-dmitry.kurochkin@gmail.com>

Before the patch, message, headers and hidden citation overlays
had zero priority.  All these overlay have `invisible' property.
Emacs documentation says that we should not make assumptions
about which overlay will prevail when they have the same priority
[1].  It happens to work as we need, but we should not rely on
undocumented behavior.

[1] http://www.gnu.org/s/emacs/manual/html_node/elisp/Overlay-Properties.html
---
 emacs/notmuch-show.el |    4 +++-
 emacs/notmuch-wash.el |    1 +
 2 files changed, 4 insertions(+), 1 deletions(-)

diff --git a/emacs/notmuch-show.el b/emacs/notmuch-show.el
index 34c0b79..e1846bc 100644
--- a/emacs/notmuch-show.el
+++ b/emacs/notmuch-show.el
@@ -733,7 +733,9 @@ current buffer, if possible."
     ;; message.
     (put-text-property message-start message-end :notmuch-message-extent (cons message-start message-end))
 
-    (overlay-put (make-overlay headers-start headers-end) 'invisible headers-invis-spec)
+    (let ((headers-overlay (make-overlay headers-start headers-end)))
+      (overlay-put headers-overlay 'invisible headers-invis-spec)
+      (overlay-put headers-overlay 'priority 10))
     (overlay-put (make-overlay body-start body-end) 'invisible message-invis-spec)
 
     ;; Save the properties for this message. Currently this saves the
diff --git a/emacs/notmuch-wash.el b/emacs/notmuch-wash.el
index bd521ba..992fa8f 100644
--- a/emacs/notmuch-wash.el
+++ b/emacs/notmuch-wash.el
@@ -139,6 +139,7 @@ insert before the button, probably for indentation."
     (add-to-invisibility-spec invis-spec)
     (overlay-put overlay 'invisible (list invis-spec message-invis-spec))
     (overlay-put overlay 'isearch-open-invisible #'notmuch-wash-region-isearch-show)
+    (overlay-put overlay 'priority 10)
     (overlay-put overlay 'type type)
     (goto-char (1+ end))
     (save-excursion
-- 
1.7.5.1

  parent reply	other threads:[~2011-05-25 22:10 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-05-25 22:10 [PATCH] Fix hiding a message while some citations are visible Dmitry Kurochkin
2011-05-25 22:10 ` [PATCH 1/5] Pass message to the `notmuch-show-insert-text/plain-hook' hook Dmitry Kurochkin
2011-05-25 22:10 ` [PATCH 2/5] Set message invisibility spec properties before inserting the body Dmitry Kurochkin
2011-05-25 22:10 ` [PATCH 3/5] Fix hiding a message while some citations are shown in notmuch-show view Dmitry Kurochkin
2011-05-25 22:23   ` Carl Worth
2011-05-25 22:34     ` Dmitry Kurochkin
2011-05-25 22:46       ` Carl Worth
2011-05-25 23:10         ` Dmitry Kurochkin
2011-05-26  1:02           ` Carl Worth
2011-05-26 10:26             ` Dmitry Kurochkin
2011-05-26 21:31               ` Carl Worth
2011-05-26 21:42                 ` Dmitry Kurochkin
2011-06-15 14:06                   ` Carl Worth
2011-06-15 14:25                     ` Dmitry Kurochkin
2011-06-15 16:16                       ` Jameson Graef Rollins
2011-06-15 17:00                       ` Carl Worth
2011-06-15 17:10                         ` Dmitry Kurochkin
2011-05-25 22:10 ` Dmitry Kurochkin [this message]
2011-05-25 22:10 ` [PATCH 5/5] Simplify message and headers visibility code " Dmitry Kurochkin
2011-05-26 21:38 ` [PATCH 1/2] test: add tests for hiding messages " Dmitry Kurochkin
2011-05-26 21:38   ` [PATCH 2/2] Workaround for Emacs bug #8721 Dmitry Kurochkin
2011-05-26 21:48     ` Dmitry Kurochkin
2011-05-28  1:29       ` Dmitry Kurochkin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://notmuchmail.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1306361416-5019-5-git-send-email-dmitry.kurochkin@gmail.com \
    --to=dmitry.kurochkin@gmail.com \
    --cc=notmuch@notmuchmail.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://yhetil.org/notmuch.git/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).