From: Dmitry Kurochkin <dmitry.kurochkin@gmail.com>
To: notmuch@notmuchmail.org
Subject: [PATCH] Save and restore point explicitly in `notmuch-wash-toggle-invisible-action'.
Date: Wed, 25 May 2011 03:02:43 +0400 [thread overview]
Message-ID: <1306278163-20784-1-git-send-email-dmitry.kurochkin@gmail.com> (raw)
In-Reply-To: <87y61vpuuc.fsf@gmail.com>
Before the change, save-excursion was used to save the point.
But the restored position is affected by buffer modifications,
which results in jumping cursor. The patch saves and restores
point explicitly by using a variable instead of save-excursion.
---
emacs/notmuch-wash.el | 13 +++++++------
1 files changed, 7 insertions(+), 6 deletions(-)
diff --git a/emacs/notmuch-wash.el b/emacs/notmuch-wash.el
index 863459e..115c3bb 100644
--- a/emacs/notmuch-wash.el
+++ b/emacs/notmuch-wash.el
@@ -82,13 +82,14 @@ collapse the remaining lines into a button.")
(let* ((new-start (button-start cite-button))
(overlay (button-get cite-button 'overlay))
(button-label (notmuch-wash-button-label overlay))
+ (old-point (point))
(inhibit-read-only t))
- (save-excursion
- (goto-char new-start)
- (insert button-label)
- (let ((old-end (button-end cite-button)))
- (move-overlay cite-button new-start (point))
- (delete-region (point) old-end))))
+ (goto-char new-start)
+ (insert button-label)
+ (let ((old-end (button-end cite-button)))
+ (move-overlay cite-button new-start (point))
+ (delete-region (point) old-end))
+ (goto-char (min old-point (1- (button-end cite-button)))))
(force-window-update)
(redisplay t))
--
1.7.5.1
next prev parent reply other threads:[~2011-05-24 23:02 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-22 18:57 [PATCH 1/3] Use different labels for wash buttons when text is visible or hidden Dmitry Kurochkin
2011-05-22 18:57 ` [PATCH 2/3] test: fix expected output for emacs tests after the wash button label changes Dmitry Kurochkin
2011-05-22 18:57 ` [PATCH 3/3] test: add test for hiding/showing signature in notmuch-show view Dmitry Kurochkin
2011-05-23 15:29 ` [PATCH] Save and restore point explicitly in `notmuch-wash-toggle-invisible-action' Dmitry Kurochkin
2011-05-24 20:20 ` Carl Worth
2011-05-24 20:43 ` Dmitry Kurochkin
2011-05-24 22:01 ` Carl Worth
2011-05-24 22:16 ` Dmitry Kurochkin
2011-05-24 22:22 ` Carl Worth
2011-05-24 22:43 ` Austin Clements
2011-05-24 22:57 ` Carl Worth
2011-05-24 23:00 ` Dmitry Kurochkin
2011-05-24 23:02 ` Dmitry Kurochkin [this message]
2011-05-24 23:20 ` Carl Worth
2011-05-24 23:27 ` Dmitry Kurochkin
2011-05-24 23:36 ` Carl Worth
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://notmuchmail.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1306278163-20784-1-git-send-email-dmitry.kurochkin@gmail.com \
--to=dmitry.kurochkin@gmail.com \
--cc=notmuch@notmuchmail.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://yhetil.org/notmuch.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).