unofficial mirror of notmuch@notmuchmail.org
 help / color / mirror / code / Atom feed
* [PATCH] test/search: add check for slightly trick search
@ 2011-02-06 13:21 Felipe Contreras
  2011-02-06 22:39 ` Felipe Contreras
  0 siblings, 1 reply; 2+ messages in thread
From: Felipe Contreras @ 2011-02-06 13:21 UTC (permalink / raw)
  To: notmuch

It's not really tricky, there are many addresses with a '-' in them. I
personally really want to differentiate between foo, foo-testing, and
foo-patches.

This fails, but it shouldn't:

 FAIL   Search by from (tricky):
	--- search.17.expected	2011-02-06 13:16:31.871509560 +0000
	+++ search.17.output	2011-02-06 13:16:31.871509560 +0000
	@@ -1 +1,3 @@
	+thread:XXX   2000-01-01 [1/1] Search By From Name; search by from (name) (inbox unread)
	+thread:XXX   2000-01-01 [1/1] search-by-from-trick; search by from (tricky trick) (inbox unread)
	 thread:XXX   2000-01-01 [1/1] search-by-from; search by from (tricky) (inbox unread)

Signed-off-by: Felipe Contreras <felipe.contreras@gmail.com>
---
 test/search |    6 ++++++
 1 files changed, 6 insertions(+), 0 deletions(-)

diff --git a/test/search b/test/search
index b180c7f..ad5bbaa 100755
--- a/test/search
+++ b/test/search
@@ -123,4 +123,10 @@ echo -n > expected &&
 notmuch search "no-message-matches-this" > actual &&
 test_cmp expected actual'
 
+test_begin_subtest "Search by from (tricky):"
+add_message '[subject]="search by from (tricky trick)"' '[date]="Sat, 01 Jan 2000 12:00:00 -0000"' '[from]=search-by-from-trick'
+add_message '[subject]="search by from (tricky)"' '[date]="Sat, 01 Jan 2000 12:00:00 -0000"' '[from]=search-by-from'
+output=$(notmuch search from:'search-by-from' | notmuch_search_sanitize)
+test_expect_equal "$output" "thread:XXX   2000-01-01 [1/1] search-by-from; search by from (tricky) (inbox unread)"
+
 test_done
-- 
1.7.4.1.g4f7e4.dirty

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] test/search: add check for slightly trick search
  2011-02-06 13:21 [PATCH] test/search: add check for slightly trick search Felipe Contreras
@ 2011-02-06 22:39 ` Felipe Contreras
  0 siblings, 0 replies; 2+ messages in thread
From: Felipe Contreras @ 2011-02-06 22:39 UTC (permalink / raw)
  To: notmuch

On Sun, Feb 6, 2011 at 3:21 PM, Felipe Contreras
<felipe.contreras@gmail.com> wrote:
> It's not really tricky, there are many addresses with a '-' in them. I
> personally really want to differentiate between foo, foo-testing, and
> foo-patches.
>
> This fails, but it shouldn't:

As discussed in IRC, perhaps the query should be 'search-by-from@',
but that would require notmuch to distinguish @ as something special.
Perhaps s/@/-at-/.

Cheers.

-- 
Felipe Contreras

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2011-02-06 22:39 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-02-06 13:21 [PATCH] test/search: add check for slightly trick search Felipe Contreras
2011-02-06 22:39 ` Felipe Contreras

Code repositories for project(s) associated with this public inbox

	https://yhetil.org/notmuch.git/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).