unofficial mirror of notmuch@notmuchmail.org
 help / color / mirror / code / Atom feed
* [PATCH] Workaround broken check for old-style notmuch-fcc-dirs
@ 2010-11-24 21:00 Carl Worth
  2010-11-25 10:59 ` [PATCH 1/3] test: Add ERT for emacs testing David Edmondson
                   ` (2 more replies)
  0 siblings, 3 replies; 6+ messages in thread
From: Carl Worth @ 2010-11-24 21:00 UTC (permalink / raw)
  To: notmuch

This check actually makes a new-style setting not work.
---
 emacs/notmuch-maildir-fcc.el |    8 ++++----
 1 files changed, 4 insertions(+), 4 deletions(-)

I don't intend this commit for the central repository. Better would be
a new test case for a new-style notmuch-fcc-dirs setting, then a fix
to make the code below work as intended (rather than being commented
out).

diff --git a/emacs/notmuch-maildir-fcc.el b/emacs/notmuch-maildir-fcc.el
index e5e0549..54d5528 100644
--- a/emacs/notmuch-maildir-fcc.el
+++ b/emacs/notmuch-maildir-fcc.el
@@ -87,10 +87,10 @@ will NOT be removed or replaced."
 	  ((stringp notmuch-fcc-dirs)
 	   notmuch-fcc-dirs)
 
-	  ((and (listp notmuch-fcc-dirs)
-		(= 1 (length (car notmuch-fcc-dirs))))
-	   ;; Old style - no longer works.
-	   (error "Invalid `notmuch-fcc-dirs' setting (old style)"))
+;	  ((and (listp notmuch-fcc-dirs)
+;		(= 1 (length (car notmuch-fcc-dirs))))
+;	   ;; Old style - no longer works.
+;	   (error "Invalid `notmuch-fcc-dirs' setting (old style)"))
 
 	  ((listp notmuch-fcc-dirs)
 	   (let* ((from (message-fetch-field "From"))
-- 
1.7.2.3

^ permalink raw reply related	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2010-11-25 14:13 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-11-24 21:00 [PATCH] Workaround broken check for old-style notmuch-fcc-dirs Carl Worth
2010-11-25 10:59 ` [PATCH 1/3] test: Add ERT for emacs testing David Edmondson
2010-11-25 12:02   ` David Edmondson
2010-11-25 14:09   ` [PATCH] test: Add some more emacs tests David Edmondson
2010-11-25 10:59 ` [PATCH 2/3] emacs: Fix Fcc generation David Edmondson
2010-11-25 10:59 ` [PATCH 3/3] test: Add ERT tests for Fcc determination David Edmondson

Code repositories for project(s) associated with this public inbox

	https://yhetil.org/notmuch.git/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).