unofficial mirror of notmuch@notmuchmail.org
 help / color / mirror / code / Atom feed
From: Carl Worth <cworth@cworth.org>
To: notmuch@notmuchmail.org
Subject: [PATCH] Workaround broken check for old-style notmuch-fcc-dirs
Date: Wed, 24 Nov 2010 13:00:44 -0800	[thread overview]
Message-ID: <1290632444-10046-1-git-send-email-cworth@cworth.org> (raw)

This check actually makes a new-style setting not work.
---
 emacs/notmuch-maildir-fcc.el |    8 ++++----
 1 files changed, 4 insertions(+), 4 deletions(-)

I don't intend this commit for the central repository. Better would be
a new test case for a new-style notmuch-fcc-dirs setting, then a fix
to make the code below work as intended (rather than being commented
out).

diff --git a/emacs/notmuch-maildir-fcc.el b/emacs/notmuch-maildir-fcc.el
index e5e0549..54d5528 100644
--- a/emacs/notmuch-maildir-fcc.el
+++ b/emacs/notmuch-maildir-fcc.el
@@ -87,10 +87,10 @@ will NOT be removed or replaced."
 	  ((stringp notmuch-fcc-dirs)
 	   notmuch-fcc-dirs)
 
-	  ((and (listp notmuch-fcc-dirs)
-		(= 1 (length (car notmuch-fcc-dirs))))
-	   ;; Old style - no longer works.
-	   (error "Invalid `notmuch-fcc-dirs' setting (old style)"))
+;	  ((and (listp notmuch-fcc-dirs)
+;		(= 1 (length (car notmuch-fcc-dirs))))
+;	   ;; Old style - no longer works.
+;	   (error "Invalid `notmuch-fcc-dirs' setting (old style)"))
 
 	  ((listp notmuch-fcc-dirs)
 	   (let* ((from (message-fetch-field "From"))
-- 
1.7.2.3

             reply	other threads:[~2010-11-24 21:00 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-11-24 21:00 Carl Worth [this message]
2010-11-25 10:59 ` [PATCH 1/3] test: Add ERT for emacs testing David Edmondson
2010-11-25 12:02   ` David Edmondson
2010-11-25 14:09   ` [PATCH] test: Add some more emacs tests David Edmondson
2010-11-25 10:59 ` [PATCH 2/3] emacs: Fix Fcc generation David Edmondson
2010-11-25 10:59 ` [PATCH 3/3] test: Add ERT tests for Fcc determination David Edmondson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://notmuchmail.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1290632444-10046-1-git-send-email-cworth@cworth.org \
    --to=cworth@cworth.org \
    --cc=notmuch@notmuchmail.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://yhetil.org/notmuch.git/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).